Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5323)

Unified Diff: base/bind_helpers.h

Issue 6981001: Make the Pepper proxy support in-process font rendering. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/all.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/bind_helpers.h
===================================================================
--- base/bind_helpers.h (revision 84713)
+++ base/bind_helpers.h (working copy)
@@ -123,6 +123,9 @@
//
// TODO(ajwong): Move to ref_counted.h or template_util.h when we've vetted
// this works well.
+//
+// TODO(ajwong): Make this check for Release() as well.
+// See http://crbug.com/82038.
template <typename T>
class SupportsAddRefAndRelease {
typedef char Yes[1];
@@ -130,7 +133,6 @@
struct BaseMixin {
void AddRef();
- void Release();
};
// MSVC warns when you try to use Base if T has a private destructor, the
@@ -148,13 +150,13 @@
template <void(BaseMixin::*)(void)> struct Helper {};
template <typename C>
- static No& Check(Helper<&C::AddRef>*, Helper<&C::Release>*);
+ static No& Check(Helper<&C::AddRef>*);
template <typename >
static Yes& Check(...);
public:
- static const bool value = sizeof(Check<Base>(0,0)) == sizeof(Yes);
+ static const bool value = sizeof(Check<Base>(0)) == sizeof(Yes);
};
« no previous file with comments | « no previous file | build/all.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698