Issue 698002: Added zone-inl.h to test-heap-profiler to fix test build failure after header...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 698002: Added zone-inl.h to test-heap-profiler to fix test build failure after header... (Closed)

Created:
10 years, 9 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium), Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Added zone-inl.h to test-heap-profiler to fix test build failure after header file refactoring in revision 4058. Committed: http://code.google.com/p/v8/source/detail?r=4059

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	test/cctest/test-heap-profiler.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

Small addition to rev 4058 to make cctest compile - test-heap-profiler relies implicitly on zone-inl.h

10 years, 9 months ago (2010-03-09 07:53:52 UTC) #1

Mads Ager (chromium)

10 years, 9 months ago (2010-03-09 08:22:38 UTC) #2

LGTM

This will only fix the release build though.  There is an issue with
objects-debug.cc as well in the debug build.  Please commit this change and then
we can fix the debug build.

Expand Messages | Collapse Messages