Issue 6979021: Mac. Build bookmark tooltips more intelligently, not showing title if same as URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6979021: Mac. Build bookmark tooltips more intelligently, not showing title if same as URL. (Closed)

Created:
9 years, 7 months ago by mafv

Modified:
9 years, 6 months ago

Reviewers:
mrossetti

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Mac. Build bookmark tooltips more intelligently, not showing title if same as URL. Refactor tooltip string code to remove duplication. R=mrossetti@chromium.org BUG=70709 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86753

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -22 lines)			Patch
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm	View	1 2 3	3 chunks	+16 lines, -16 lines	1 comment	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm	View	1	1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mrossetti

9 years, 7 months ago (2011-05-25 23:35:54 UTC) #2

LGTM

http://codereview.chromium.org/6979021/diff/6001/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right):

http://codereview.chromium.org/6979021/diff/6001/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:1232: NSString *url
= [NSString stringWithUTF8String:url_string.c_str()];
Nit: Move asterisk left.

Expand Messages | Collapse Messages