When --disable-gpu-vsync, run requestAnimFrame callbacks at top speed.

When --disable-gpu-vsync, run requestAnimFrame callbacks at top speed.

BUG=82869
TEST=--disable-gpu-vsync should cause http://www.corp.google.com/~nduca/test/anim-timing/raftime_accel.html to run much faster than 60 FPS

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87745

[jamesr, 2011-05-26 02:20:14]

http://codereview.chromium.org/6979020/diff/1/content/renderer/render_widget.cc
File content/renderer/render_widget.cc (right):

http://codereview.chromium.org/6979020/diff/1/content/renderer/render_widget....
content/renderer/render_widget.cc:615: this, &RenderWidget::AnimationCallback),
16);
would it be sufficient to leave this function unchanged except to replace all
instances of '16' with 'IsRenderingVSyncd() ? 16 : 0' (although not as ugly as
with a ternary)?  I'm a bit brain tired but it's not immediately clear what
all's going on here and I'm kinda hoping that's an easy way out.

[nduca, 2011-05-26 05:25:02]

No harm in trying! I'll see what happens and let you know. I think I was brain
tired and took my equivalent easy way out. :)

[nduca, 2011-06-02 17:20:44]

jamesr: ping

[jamesr, 2011-06-02 22:07:53]

LGTM, just some nits to ponder at your discretion

http://codereview.chromium.org/6979020/diff/3001/content/renderer/render_widg...
File content/renderer/render_widget.cc (right):

http://codereview.chromium.org/6979020/diff/3001/content/renderer/render_widg...
content/renderer/render_widget.cc:651: return
!CommandLine::ForCurrentProcess()->HasSwitch(
nitpick: this is doing a string comparison (and a conversion to lowercase on
windows) on every tick, which with vsync off will be pretty often.  this value
can never change for the lifetime of the process, so could you stash the results
in a static bool and just return that?  the command line strings can be pretty
long sometimes

http://codereview.chromium.org/6979020/diff/3001/content/renderer/render_widg...
File content/renderer/render_widget.h (right):

http://codereview.chromium.org/6979020/diff/3001/content/renderer/render_widg...
content/renderer/render_widget.h:172: bool IsRenderingVSyncd();
nitpick: what about VSynced?  Feels a bit more like english

[jamesr, 2011-06-02 22:08:53]

Also I have no OWNERS power for content/browser, so Avi or someone else in that
dir needs to approve that bit

[Avi (use Gerrit), 2011-06-02 23:45:08]

kathunk. owner rubber stamp LGTM