Issue 6979019: base/i18n: Make BreakIterator::IsWord() more readable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6979019: base/i18n: Make BreakIterator::IsWord() more readable. (Closed)

Created:
9 years, 7 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Tom Sepez, Evan Martin

CC:
chromium-reviews, jshin+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base/i18n: Make BreakIterator::IsWord() more readable. Unrelated changes: - Remove unnecessary {} around if clause. - Tweak some comments in the header file. - Move prev() and pos() getters to the end of public section. BUG=None TEST=out/Debug/base_unittests --gtest_filter=BreakIteratorTest.* R=tsepez@chromium.org,evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86747

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -19 lines)			Patch
	M	base/i18n/break_iterator.h	View	1 2	3 chunks	+15 lines, -14 lines	0 comments	Download
	M	base/i18n/break_iterator.cc	View		2 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages