Move user cloud policy to BrowserProcess.

chrome/browser/policy/browser_policy_connector.h

Index: chrome/browser/policy/browser_policy_connector.h
diff --git a/chrome/browser/policy/browser_policy_connector.h b/chrome/browser/policy/browser_policy_connector.h
index 5c15b93cc6e37e50dc93fb66f9d4349d775d8c35..81f7cefa5ac82f9bc252faf744641ce2247ff747 100644
--- a/chrome/browser/policy/browser_policy_connector.h
+++ b/chrome/browser/policy/browser_policy_connector.h
@@ -23,6 +23,7 @@ class URLRequestContextGetter;
 
 namespace policy {
 
+class CloudPolicyProvider;
 class CloudPolicySubsystem;
 class ConfigurationPolicyProvider;
 class DevicePolicyIdentityStrategy;
@@ -35,9 +36,9 @@ class BrowserPolicyConnector {
   ~BrowserPolicyConnector();
 
   ConfigurationPolicyProvider* GetManagedPlatformProvider() const;
-  ConfigurationPolicyProvider* GetManagedCloudProvider() const;
+  CloudPolicyProvider* GetManagedCloudProvider() const;

[Mattias Nissler (ping if slow), 2011/05/31 14:14:19]

You shouldn't need to now that these are CloudPolicyProviders. I know that
currently you rely on this since the user policy stuff goes through this
accessor to get to the device policy maps. But that seems wrong too... Can't we
just give the user policy providers access directly to the
BrowserPolicyConnector's cache?

[sfeuz, 2011/06/03 08:30:35]

Obsolete.

   ConfigurationPolicyProvider* GetRecommendedPlatformProvider() const;
-  ConfigurationPolicyProvider* GetRecommendedCloudProvider() const;
+  CloudPolicyProvider* GetRecommendedCloudProvider() const;
 
   // Returns a weak pointer to the CloudPolicySubsystem managed by this
   // policy connector, or NULL if no such subsystem exists (i.e. when running
@@ -86,6 +87,9 @@ class BrowserPolicyConnector {
   // Activates the cloud policy subsystem.
   void Initialize();
 
+  scoped_ptr<CloudPolicyProvider> managed_cloud_provider_;
+  scoped_ptr<CloudPolicyProvider> recommended_cloud_provider_;

[Joao da Silva, 2011/05/31 14:50:23]

These are only used on ChromeOS, so how about wrapping with

#if defined(OS_CHROMEOS)?

The implementations of Get*CloudProvider() should then also test for
OS_CHROMEOS, and just return NULL on other platforms. Similar to the
implementation of GetEnterpriseDomain().

[sfeuz, 2011/06/03 08:30:35]

Obsolete.
But I tried to put everything else which is device-only behind the guards.

+
   scoped_ptr<ConfigurationPolicyProvider> managed_platform_provider_;
   scoped_ptr<ConfigurationPolicyProvider> recommended_platform_provider_;