Move user cloud policy to BrowserProcess.

chrome/browser/browser_process_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_process_impl.h"
 
 #include <map>
 #include <set>
 #include <vector>
 
@@ skipping 25 matching lines @@
 #include "chrome/browser/io_thread.h"
 #include "chrome/browser/metrics/metrics_service.h"
 #include "chrome/browser/metrics/thread_watcher.h"
 #include "chrome/browser/net/chrome_net_log.h"
 #include "chrome/browser/net/predictor_api.h"
 #include "chrome/browser/net/sdch_dictionary_fetcher.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/platform_util.h"
 #include "chrome/browser/plugin_data_remover.h"
 #include "chrome/browser/policy/browser_policy_connector.h"
+#include "chrome/browser/policy/cloud_policy_provider.h"
+#include "chrome/browser/policy/configuration_policy_pref_store.h"
+#include "chrome/browser/policy/user_policy_connector.h"
 #include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/printing/background_printing_manager.h"
 #include "chrome/browser/printing/print_job_manager.h"
 #include "chrome/browser/printing/print_preview_tab_controller.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/safe_browsing/client_side_detection_service.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "chrome/browser/shell_integration.h"
 #include "chrome/browser/sidebar/sidebar_manager.h"
@@ skipping 63 matching lines @@
       created_watchdog_thread_(false),
 #if defined(OS_CHROMEOS)
       created_web_socket_proxy_thread_(false),
 #endif
       created_profile_manager_(false),
       created_local_state_(false),
       created_icon_manager_(false),
       created_devtools_manager_(false),
       created_sidebar_manager_(false),
       created_browser_policy_connector_(false),
+      created_user_policy_connector_(false),
+      created_managed_cloud_policy_provider_(false),
+      created_recommended_cloud_policy_provider_(false),
       created_notification_ui_manager_(false),
       created_safe_browsing_detection_service_(false),
       module_ref_count_(0),
       did_start_(false),
       checked_for_new_frames_(false),
       using_new_frames_(false) {
   g_browser_process = this;
   clipboard_.reset(new ui::Clipboard);
   main_notification_service_.reset(new NotificationService);
 
@@ skipping 78 matching lines @@
 
     // Cancel pending requests and prevent new requests.
     resource_dispatcher_host()->Shutdown();
   }
 
   ExtensionTabIdMap::GetInstance()->Shutdown();
 
   // The policy providers managed by |browser_policy_connector_| need to shut
   // down while the IO and FILE threads are still alive.
   browser_policy_connector_.reset();
+  user_policy_connector_.reset();
+  managed_cloud_policy_provider_.reset();
+  recommended_cloud_policy_provider_.reset();
 
 #if defined(USE_X11)
   // The IO thread must outlive the BACKGROUND_X11 thread.
   background_x11_thread_.reset();
 #endif
 
   // Wait for removing plugin data to finish before shutting down the IO thread.
   WaitForPluginDataRemoverToFinish();
 
   // Destroying the GpuProcessHostUIShims on the UI thread posts a task to
@@ skipping 286 matching lines @@
 policy::BrowserPolicyConnector* BrowserProcessImpl::browser_policy_connector() {
   DCHECK(CalledOnValidThread());
   if (!created_browser_policy_connector_) {
     DCHECK(browser_policy_connector_.get() == NULL);
     created_browser_policy_connector_ = true;
     browser_policy_connector_.reset(policy::BrowserPolicyConnector::Create());
   }
   return browser_policy_connector_.get();
 }
 
+policy::UserPolicyConnector* BrowserProcessImpl::user_policy_connector() {
+  DCHECK(CalledOnValidThread());
+  if (!created_user_policy_connector_) {

[Joao da Silva, 2011/05/31 14:50:23]

Why have a boolean for this test, instead of testing the scoped_ptr?
Something like:

if (!user_policy_connector_.get()) {
  user_policy_connector_.reset(policy::UserPolicyConnector::Create());
}

[sfeuz, 2011/06/03 08:30:35]

Obsolete.
But still the same is done in browser_policy_connector. I actually dont know
exactly why...

+    DCHECK(user_policy_connector_.get() == NULL);
+    created_user_policy_connector_ = true;
+    user_policy_connector_.reset(policy::UserPolicyConnector::Create());
+  }
+  return user_policy_connector_.get();
+}
+
+policy::ConfigurationPolicyProvider*
+    BrowserProcessImpl::managed_cloud_policy_provider() {
+  DCHECK(CalledOnValidThread());
+  if (!created_managed_cloud_policy_provider_) {
+    DCHECK(!managed_cloud_policy_provider_.get());
+    created_managed_cloud_policy_provider_ = true;
+    // Combining user policy and device policy.
+    managed_cloud_policy_provider_.reset(
+        new policy::CombiningCloudPolicyProvider(
+             policy::ConfigurationPolicyPrefStore::
+                 GetChromePolicyDefinitionList()));
+    // User policy taking precedence.
+    policy::CloudPolicyProvider* user_policy =
+        user_policy_connector()->GetManagedCloudProvider();
+    if (user_policy)
+      managed_cloud_policy_provider_.get()->AddCloudPolicyProvider(user_policy);

[Joao da Silva, 2011/05/31 14:50:23]

No need for .get(), just -> from the scoped_ptr.

[sfeuz, 2011/06/03 08:30:35]

Obsolete.

+
+    policy::CloudPolicyProvider* device_policy =
+        browser_policy_connector()->GetManagedCloudProvider();
+    if (device_policy) {
+      managed_cloud_policy_provider_.get()->

[Joao da Silva, 2011/05/31 14:50:23]

Same.

[sfeuz, 2011/06/03 08:30:35]

Obsolete.

+          AddCloudPolicyProvider(device_policy);
+    }
+  }
+  return managed_cloud_policy_provider_.get();
+}
+
+policy::ConfigurationPolicyProvider*
+    BrowserProcessImpl::recommended_cloud_policy_provider() {
+  DCHECK(CalledOnValidThread());
+  if (!created_recommended_cloud_policy_provider_) {
+    DCHECK(!recommended_cloud_policy_provider_.get());
+    created_recommended_cloud_policy_provider_ = true;
+    // Combining user policy and device policy.
+    recommended_cloud_policy_provider_.reset(
+        new policy::CombiningCloudPolicyProvider(
+            policy::ConfigurationPolicyPrefStore::
+                GetChromePolicyDefinitionList()));
+    // User policy taking precedence.
+    policy::CloudPolicyProvider* user_policy =
+        user_policy_connector()->GetRecommendedCloudProvider();
+    if (user_policy)
+      recommended_cloud_policy_provider_.get()->

[Joao da Silva, 2011/05/31 14:50:23]

Same.

[sfeuz, 2011/06/03 08:30:35]

Obsolete.

+          AddCloudPolicyProvider(user_policy);
+
+    policy::CloudPolicyProvider* device_policy =
+        browser_policy_connector()->GetRecommendedCloudProvider();
+    if (device_policy) {
+      recommended_cloud_policy_provider_.get()->

[Joao da Silva, 2011/05/31 14:50:23]

Same again :-)

[sfeuz, 2011/06/03 08:30:35]

Obsolete :-)

+          AddCloudPolicyProvider(device_policy);
+    }
+  }
+  return recommended_cloud_policy_provider_.get();
+}
+
 IconManager* BrowserProcessImpl::icon_manager() {
   DCHECK(CalledOnValidThread());
   if (!created_icon_manager_)
     CreateIconManager();
   return icon_manager_.get();
 }
 
 ThumbnailGenerator* BrowserProcessImpl::GetThumbnailGenerator() {
   return &thumbnail_generator_;
 }
@@ skipping 578 matching lines @@
 }
 
 void BrowserProcessImpl::OnAutoupdateTimer() {
   if (CanAutorestartForUpdate()) {
     DLOG(WARNING) << "Detected update.  Restarting browser.";
     RestartPersistentInstance();
   }
 }
 
 #endif  // (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS)