Move user cloud policy to BrowserProcess.

chrome/browser/browser_process_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // When each service is created, we set a flag indicating this. At this point,
 // the service initialization could fail or succeed. This allows us to remember
 // if we tried to create a service, and not try creating it over and over if
 // the creation failed.
 
 #ifndef CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_
@@ skipping 18 matching lines @@
 
 class ChromeNetLog;
 class CommandLine;
 class DevToolsHttpProtocolHandler;
 class DevToolsProtocolHandler;
 class FilePath;
 class NotificationService;
 class PluginDataRemover;
 class TabCloseableStateWatcher;
 
+namespace policy{
+class BrowserPolicyConnector;
+class ProfilePolicyConnector;
+class ConfigurationPolicyProvider;
+class CombiningCloudPolicyProvider;
+};
+
 // Real implementation of BrowserProcess that creates and returns the services.
 class BrowserProcessImpl : public BrowserProcess,
                            public base::NonThreadSafe,
                            public NotificationObserver {
  public:
   explicit BrowserProcessImpl(const CommandLine& command_line);
   virtual ~BrowserProcessImpl();
 
   virtual void EndSession();
 
@@ skipping 19 matching lines @@
   virtual SidebarManager* sidebar_manager();
   virtual ui::Clipboard* clipboard();
   virtual net::URLRequestContextGetter* system_request_context();
 #if defined(OS_CHROMEOS)
   virtual chromeos::ProxyConfigServiceImpl*
       chromeos_proxy_config_service_impl();
 #endif  // defined(OS_CHROMEOS)
   virtual ExtensionEventRouterForwarder* extension_event_router_forwarder();
   virtual NotificationUIManager* notification_ui_manager();
   virtual policy::BrowserPolicyConnector* browser_policy_connector();
+  virtual policy::ProfilePolicyConnector* user_policy_connector();
+  virtual policy::ConfigurationPolicyProvider* managed_cloud_policy_provider();
+  virtual policy::ConfigurationPolicyProvider*
+      recommended_cloud_policy_provider();
   virtual IconManager* icon_manager();
   virtual ThumbnailGenerator* GetThumbnailGenerator();
   virtual AutomationProviderList* InitAutomationProviderList();
   virtual void InitDevToolsHttpProtocolHandler(
       const std::string& ip,
       int port,
       const std::string& frontend_url);
   virtual void InitDevToolsLegacyProtocolHandler(int port);
   virtual unsigned int AddRefModule();
   virtual unsigned int ReleaseModule();
@@ skipping 127 matching lines @@
 
   bool created_devtools_manager_;
   scoped_refptr<DevToolsManager> devtools_manager_;
 
   bool created_sidebar_manager_;
   scoped_refptr<SidebarManager> sidebar_manager_;
 
   bool created_browser_policy_connector_;
   scoped_ptr<policy::BrowserPolicyConnector> browser_policy_connector_;
 
+  bool created_user_policy_connector_;
+  scoped_ptr<policy::ProfilePolicyConnector> user_policy_connector_;
+
+  bool created_managed_cloud_policy_provider_;
+  scoped_ptr<policy::CombiningCloudPolicyProvider>

[Mattias Nissler (ping if slow), 2011/05/26 10:20:20]

Any reason why we need the specific CombiningCloudPolicyProvider type here?
ConfigurationPolicyProvider should be good enough, no?

[sfeuz, 2011/05/31 07:32:31]

The way this is accessed from the outside is through the getter
managed_cloud_policy_provider() which returns it as a 
ConfigurationPolicyProvider.
I dont see a reason to also store it as a ConfigurationPolicyProvider.
Am I missing an obvious drawback of this method?

[Mattias Nissler (ping if slow), 2011/05/31 14:14:19]

Technically, there is not difference. My point is just that on this level we
shouldn't really need to know what exact CloudPolicyProvider implementation we
have, in particular if this all lives in BrowserProcessImpl (but that's the
other discussion point).

+      managed_cloud_policy_provider_;
+
+  bool created_recommended_cloud_policy_provider_;
+  scoped_ptr<policy::CombiningCloudPolicyProvider>
+      recommended_cloud_policy_provider_;
+
   scoped_refptr<printing::PrintPreviewTabController>
       print_preview_tab_controller_;
 
   scoped_ptr<printing::BackgroundPrintingManager> background_printing_manager_;
 
   scoped_ptr<ui::Clipboard> clipboard_;
 
   // Manager for desktop notification UI.
   bool created_notification_ui_manager_;
   scoped_ptr<NotificationUIManager> notification_ui_manager_;
@@ skipping 59 matching lines @@
 
 #if defined(OS_CHROMEOS)
   scoped_refptr<chromeos::ProxyConfigServiceImpl>
       chromeos_proxy_config_service_impl_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(BrowserProcessImpl);
 };
 
 #endif  // CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_