Issue 6979008: Prepare push to trunk. Now working on version 3.4.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6979008: Prepare push to trunk. Now working on version 3.4.0. (Closed)

Created:
9 years, 7 months ago by danno

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Prepare push to trunk. Now working on version 3.4.0. R=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=8052

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	ChangeLog	View		1 chunk	+17 lines, -0 lines	1 comment	Download
	M	src/version.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 7 months ago (2011-05-25 07:33:33 UTC) #2

LGTM

http://codereview.chromium.org/6979008/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/6979008/diff/1/ChangeLog#newcode3
ChangeLog:3: Fixed calls of strict mode function with an implicit receiver on
ia32.
This was on all platforms. My mistake I messed up the change log by keeping the
original review comment.

Expand Messages | Collapse Messages