Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: chrome/browser/importer/firefox2_importer.h

Issue 6979007: Many fixes to bookmark importing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Happy tests =) Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_IMPORTER_FIREFOX2_IMPORTER_H_ 5 #ifndef CHROME_BROWSER_IMPORTER_FIREFOX2_IMPORTER_H_
6 #define CHROME_BROWSER_IMPORTER_FIREFOX2_IMPORTER_H_ 6 #define CHROME_BROWSER_IMPORTER_FIREFOX2_IMPORTER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <set> 9 #include <set>
10 10
(...skipping 28 matching lines...) Expand all
39 static TemplateURL* CreateTemplateURL(const string16& title, 39 static TemplateURL* CreateTemplateURL(const string16& title,
40 const string16& keyword, 40 const string16& keyword,
41 const GURL& url); 41 const GURL& url);
42 42
43 // Imports the bookmarks from the specified file. |template_urls| and 43 // Imports the bookmarks from the specified file. |template_urls| and
44 // |favicons| may be null, in which case TemplateURLs and favicons are 44 // |favicons| may be null, in which case TemplateURLs and favicons are
45 // not parsed. Any bookmarks in |default_urls| are ignored. 45 // not parsed. Any bookmarks in |default_urls| are ignored.
46 static void ImportBookmarksFile( 46 static void ImportBookmarksFile(
47 const FilePath& file_path, 47 const FilePath& file_path,
48 const std::set<GURL>& default_urls, 48 const std::set<GURL>& default_urls,
49 bool import_to_bookmark_bar,
50 const string16& first_folder_name,
51 Importer* importer, 49 Importer* importer,
52 std::vector<ProfileWriter::BookmarkEntry>* bookmarks, 50 std::vector<ProfileWriter::BookmarkEntry>* bookmarks,
53 std::vector<TemplateURL*>* template_urls, 51 std::vector<TemplateURL*>* template_urls,
54 std::vector<history::ImportedFaviconUsage>* favicons); 52 std::vector<history::ImportedFaviconUsage>* favicons);
55 53
56 private: 54 private:
57 FRIEND_TEST_ALL_PREFIXES(FirefoxImporterTest, Firefox2BookmarkParse); 55 FRIEND_TEST_ALL_PREFIXES(FirefoxImporterTest, Firefox2BookmarkParse);
58 FRIEND_TEST_ALL_PREFIXES(FirefoxImporterTest, Firefox2CookesParse); 56 FRIEND_TEST_ALL_PREFIXES(FirefoxImporterTest, Firefox2CookesParse);
59 FRIEND_TEST_ALL_PREFIXES(FirefoxImporterTest, Firefox2BookmarkFileImport); 57 FRIEND_TEST_ALL_PREFIXES(FirefoxImporterTest, Firefox2BookmarkFileImport);
60 58
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 138
141 FilePath source_path_; 139 FilePath source_path_;
142 FilePath app_path_; 140 FilePath app_path_;
143 // If true, we only parse the bookmarks.html file specified as source_path_. 141 // If true, we only parse the bookmarks.html file specified as source_path_.
144 bool parsing_bookmarks_html_file_; 142 bool parsing_bookmarks_html_file_;
145 143
146 DISALLOW_COPY_AND_ASSIGN(Firefox2Importer); 144 DISALLOW_COPY_AND_ASSIGN(Firefox2Importer);
147 }; 145 };
148 146
149 #endif // CHROME_BROWSER_IMPORTER_FIREFOX2_IMPORTER_H_ 147 #endif // CHROME_BROWSER_IMPORTER_FIREFOX2_IMPORTER_H_
OLDNEW
« no previous file with comments | « chrome/browser/importer/external_process_importer_host.cc ('k') | chrome/browser/importer/firefox2_importer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698