Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Issue 6979004: Valgrind/Heapchecker: Suppress a leak in the download code. (Closed)

Created:
9 years, 7 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, pam+watch_chromium.org, Peter Kasting
Visibility:
Public.

Description

Valgrind/Heapchecker: Suppress a leak in the download code. BUG=83836 TEST=Valgrind/Heapchecker unit tests go green. TBR=timurrrr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86565

Patch Set 1 #

Patch Set 2 : add missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M tools/heapcheck/suppressions.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
timurrrrr: TBR pkasting: FYI, just remove these with your fix CL.
9 years, 7 months ago (2011-05-25 03:28:01 UTC) #1
Lei Zhang
err, see patch set 2.
9 years, 7 months ago (2011-05-25 03:30:12 UTC) #2
Timur Iskhodzhanov
9 years, 7 months ago (2011-05-26 20:35:59 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698