views/controls/button/checkbox.cc - Issue 6976048: views: Add OnEnabledChanged() method to View class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/controls/button/checkbox.cc

Issue 6976048: views: Add OnEnabledChanged() method to View class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: is_visible_ changes Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: views/controls/button/checkbox.cc

diff --git a/views/controls/button/checkbox.cc b/views/controls/button/checkbox.cc

index 71116cdd811f1c02bab97a029ef209b10136b350..0f3c47a0b6d6932182044c49b2e6943663631981 100644

--- a/views/controls/button/checkbox.cc

+++ b/views/controls/button/checkbox.cc

@@ -90,10 +90,10 @@ int Checkbox::GetHeightForWidth(int w) {

return label_->GetHeightForWidth(std::max(prefsize.height(), w - width));

}

-void Checkbox::SetEnabled(bool enabled) {

- NativeButtonBase::SetEnabled(enabled);

+void Checkbox::OnEnabledChanged() {

+ NativeButtonBase::OnEnabledChanged();

if (label_)

- label_->SetEnabled(enabled);

+ label_->SetEnabled(View::IsEnabled());

Ben Goodger (Google) 2011/05/27 17:43:02 In these cases you should be able to just call IsE

tfarina 2011/05/27 18:05:07 Done.

}

void Checkbox::Layout() {