Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: src/ast.cc

Issue 6976022: Do not allow inlining functions with direct arguments access. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 526 matching lines...) Expand 10 before | Expand all | Expand 10 after
537 if (!expression()->IsInlineable()) return false; 537 if (!expression()->IsInlineable()) return false;
538 const int count = arguments()->length(); 538 const int count = arguments()->length();
539 for (int i = 0; i < count; ++i) { 539 for (int i = 0; i < count; ++i) {
540 if (!arguments()->at(i)->IsInlineable()) return false; 540 if (!arguments()->at(i)->IsInlineable()) return false;
541 } 541 }
542 return true; 542 return true;
543 } 543 }
544 544
545 545
546 bool CallRuntime::IsInlineable() const { 546 bool CallRuntime::IsInlineable() const {
547 // Don't try to inline JS runtime calls because we don't (currently) even
548 // optimize them.
549 if (is_jsruntime()) return false;
550 // Don't inline the %_ArgumentsLength or %_Arguments because their
551 // implementation will not work. There is no stack frame to get them
552 // from.
553 if (function()->intrinsic_type == Runtime::INLINE &&
554 (name()->IsEqualTo(CStrVector("_ArgumentsLength")) ||
555 name()->IsEqualTo(CStrVector("_Arguments")))) {
556 return false;
557 }
547 const int count = arguments()->length(); 558 const int count = arguments()->length();
548 for (int i = 0; i < count; ++i) { 559 for (int i = 0; i < count; ++i) {
549 if (!arguments()->at(i)->IsInlineable()) return false; 560 if (!arguments()->at(i)->IsInlineable()) return false;
550 } 561 }
551 return true; 562 return true;
552 } 563 }
553 564
554 565
555 bool UnaryOperation::IsInlineable() const { 566 bool UnaryOperation::IsInlineable() const {
556 return expression()->IsInlineable(); 567 return expression()->IsInlineable();
(...skipping 580 matching lines...) Expand 10 before | Expand all | Expand 10 after
1137 int pos) 1148 int pos)
1138 : label_(label), 1149 : label_(label),
1139 statements_(statements), 1150 statements_(statements),
1140 position_(pos), 1151 position_(pos),
1141 compare_type_(NONE), 1152 compare_type_(NONE),
1142 compare_id_(AstNode::GetNextId()), 1153 compare_id_(AstNode::GetNextId()),
1143 entry_id_(AstNode::GetNextId()) { 1154 entry_id_(AstNode::GetNextId()) {
1144 } 1155 }
1145 1156
1146 } } // namespace v8::internal 1157 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698