Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 6976002: Support clipboardRead and clipboardWrite permission for hosted apps. (Closed)

Created:
9 years, 7 months ago by dcheng
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Support clipboardRead and clipboardWrite permission for hosted apps. BUG=82024 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86244

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : Do not check in. #

Patch Set 6 : . #

Total comments: 1

Patch Set 7 : . #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -25 lines) Patch
M chrome/browser/extensions/extension_clipboard_apitest.cc View 1 2 3 4 5 6 7 1 chunk +105 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/clipboard/extension/manifest.json View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/extensions/api_test/clipboard/extension/test.html View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/api_test/clipboard/extension/test.js View 1 2 3 4 5 6 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/clipboard/extension_no_permission/manifest.json View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/clipboard/extension_no_permission/test.html View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/api_test/clipboard/extension_no_permission/test.js View 1 2 3 4 5 6 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/clipboard/hosted_app/main.html View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/clipboard/hosted_app/manifest.json View 1 2 3 4 5 6 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/clipboard/hosted_app_no_permission/main.html View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/clipboard/hosted_app_no_permission/manifest.json View 1 2 3 4 5 6 1 chunk +13 lines, -0 lines 0 comments Download
D chrome/test/data/extensions/api_test/clipboard/manifest.json View 1 2 3 4 5 6 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/test/data/extensions/api_test/clipboard/test.html View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/clipboard/test.js View 1 2 3 4 5 6 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dcheng
9 years, 7 months ago (2011-05-09 18:24:07 UTC) #1
Erik does not do reviews
Please file a bug for this issue with some more explanation of the purpose and ...
9 years, 7 months ago (2011-05-09 18:30:12 UTC) #2
dcheng
I've create a bug with (hopefully) a good explanation of the use case.
9 years, 7 months ago (2011-05-09 18:44:19 UTC) #3
dcheng
On 2011/05/09 18:44:19, dcheng wrote: > I've create a bug with (hopefully) a good explanation ...
9 years, 7 months ago (2011-05-16 22:01:57 UTC) #4
dcheng
Please take another look if you can. Thanks!
9 years, 7 months ago (2011-05-19 22:51:54 UTC) #5
Erik does not do reviews
As discussed in IM, it seems like we should have tests for when one is ...
9 years, 7 months ago (2011-05-20 21:49:01 UTC) #6
dcheng
I've updated the tests.
9 years, 7 months ago (2011-05-21 00:04:54 UTC) #7
Erik does not do reviews
9 years, 7 months ago (2011-05-22 17:38:51 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld 408576698