Issue 6976001: Turn on the History Quick Provider by Default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6976001: Turn on the History Quick Provider by Default (Closed)

Created:
9 years, 7 months ago by mrossetti

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Turn on the History Quick Provider by default. BUG=None TEST=Type one or more portions of a recently typed URL and verify that it appears in the suggestions list. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85086

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -29 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/history_contents_provider.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/history_contents_provider.cc	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/history/in_memory_history_backend.cc	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_view_browsertest.cc	View	1	4 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

mrossetti

I'd like to punt on the 'delete default' test failure since it is not directly ...

9 years, 7 months ago (2011-05-12 00:01:08 UTC) #1

LGTM