Issue 6975058: Clear the installer stage info after patching setup.exe. We're seeing update checks for installs...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6975058: Clear the installer stage info after patching setup.exe. We're seeing update checks for installs... (Closed)

Created:
9 years, 6 months ago by grt (UTC plus 2)

Modified:
9 years, 6 months ago

Reviewers:
commit-bot: I haz the power, robertshield

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Clear the installer stage info after patching setup.exe. We're seeing update checks for installs where the machine was left in the ensemble_patching stage. I blieve that in most of these cases, setup.exe was patched without a crash. It's better if we clear the stage so that these cases aren't confused with true crashes while patching. BUG=none TEST=stage info should be cleared at the conclusion of --update-setup-exe processing. R=robertshield@chromium.org

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/installer/setup/setup_main.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Try job failure for 6975058-1 on win for step compile: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=34885

9 years, 6 months ago (2011-06-01 23:36:46 UTC) #3

Change committed as 87569

Expand Messages | Collapse Messages