PPAPI: Fix interface functions that take PP_CompletionCallbacks, but don't

ppapi/cpp/dev/video_decoder_dev.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/cpp/dev/video_decoder_dev.h"
 
 #include "ppapi/c/dev/ppb_video_decoder_dev.h"
 #include "ppapi/c/dev/ppp_video_decoder_dev.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/cpp/common.h"
 #include "ppapi/cpp/instance.h"
 #include "ppapi/cpp/module.h"
 #include "ppapi/cpp/module_impl.h"
 
 using std::vector;
 
 namespace pp {
 
 namespace {
 
 template <> const char* interface_name<PPB_VideoDecoder_Dev>() {
   return PPB_VIDEODECODER_DEV_INTERFACE;
 }
 
 }  // namespace
 
-VideoDecoder::VideoDecoder(const Instance* /* instance */,
-                           const std::vector<uint32_t>& /* config */,
-                           CompletionCallback /* callback */,
-                           Client* client)
+VideoDecoder::VideoDecoder(const Instance* /* instance */, Client* client)
     : client_(client) {
   if (!has_interface<PPB_VideoDecoder_Dev>())
     return;
   // TODO(vmr): Implement.
 }
 
 VideoDecoder::~VideoDecoder() {}
 
+int32_t VideoDecoder::Init(const std::vector<uint32_t>& /* config */,
+                   CompletionCallback /* callback */) {

[darin (slow to review), 2011/06/03 17:54:58]

nit: indentation

int32_t VideoDecoder::Init(a,
                           b) {

[polina, 2011/06/03 19:35:04]

Done.

+  return PP_ERROR_FAILED;
+  // TODO(vmr): Implement.
+}
+
 vector<uint32_t> VideoDecoder::GetConfigs(
     Instance* /* instance */,
     const vector<uint32_t>& /* prototype_config */) {
   // TODO(vmr): Implement.
   vector<uint32_t> matching_configs;
   if (!has_interface<PPB_VideoDecoder_Dev>())
     return matching_configs;
   return matching_configs;
 }
 
 void VideoDecoder::AssignGLESBuffers(uint32_t /* no_of_buffers */,
                                      const PP_GLESBuffer_Dev& /* buffers */) {
   // TODO(vmr): Implement.
 }
 
 void VideoDecoder::AssignSysmemBuffers(
     uint32_t /* no_of_buffers */,
     const PP_SysmemBuffer_Dev& /* buffers */) {
   // TODO(vmr): Implement.
 }
 
-bool VideoDecoder::Decode(
+int32_t VideoDecoder::Decode(
     const PP_VideoBitstreamBuffer_Dev& /* bitstream_buffer */,
     CompletionCallback /* callback */) {
   // TODO(vmr): Implement.
-  if (!has_interface<PPB_VideoDecoder_Dev>() || !pp_resource())
-    return false;
-  return false;
+  if (!has_interface<PPB_VideoDecoder_Dev>())
+    return PP_ERROR_NOINTERFACE;
+  if (!pp_resource())
+    return PP_ERROR_BADRESOURCE;
+  return PP_ERROR_FAILED;
 }
 
 void VideoDecoder::ReusePictureBuffer(int32_t /* picture_buffer_id */) {
   // TODO(vmr): Implement.
 }
 
-bool VideoDecoder::Flush(CompletionCallback /* callback */) {
+int32_t VideoDecoder::Flush(CompletionCallback /* callback */) {
   // TODO(vmr): Implement.
   if (!has_interface<PPB_VideoDecoder_Dev>())
-    return false;
-  return true;
+    return PP_ERROR_NOINTERFACE;
+  return PP_ERROR_FAILED;
 }
 
-bool VideoDecoder::Abort(CompletionCallback /* callback */) {
+int32_t VideoDecoder::Abort(CompletionCallback /* callback */) {
   // TODO(vmr): Implement.
   if (!has_interface<PPB_VideoDecoder_Dev>())
-    return false;
-  return true;
+    return PP_ERROR_NOINTERFACE;
+  return PP_ERROR_FAILED;
 }
 
 }  // namespace pp