Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 6975038: Linux: Install the sqlite debugging package for developers. (Closed)

Created:
9 years, 7 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
wtc, Timur Iskhodzhanov
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: Install the sqlite debugging package for developers. BUG=82894 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85798

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/install-build-deps.sh View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
9 years, 7 months ago (2011-05-18 01:03:42 UTC) #1
Timur Iskhodzhanov
Deferring the review to wtc@ http://codereview.chromium.org/6975038/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): http://codereview.chromium.org/6975038/diff/1/build/install-build-deps.sh#newcode178 build/install-build-deps.sh:178: # Include libsqlite3-0-dbg since ...
9 years, 7 months ago (2011-05-18 09:12:36 UTC) #2
Lei Zhang
http://codereview.chromium.org/6975038/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): http://codereview.chromium.org/6975038/diff/1/build/install-build-deps.sh#newcode178 build/install-build-deps.sh:178: # Include libsqlite3-0-dbg since libsoftokn3.so uses it. http://crbug.com/82894 On ...
9 years, 7 months ago (2011-05-18 09:27:46 UTC) #3
wtc
LGTM. http://codereview.chromium.org/6975038/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): http://codereview.chromium.org/6975038/diff/1/build/install-build-deps.sh#newcode186 build/install-build-deps.sh:186: libxrender1-dbg libxtst6-dbg zlib1g-dbg" NSS also depends on zlib1g. ...
9 years, 7 months ago (2011-05-18 18:56:07 UTC) #4
wtc
http://codereview.chromium.org/6975038/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): http://codereview.chromium.org/6975038/diff/1/build/install-build-deps.sh#newcode178 build/install-build-deps.sh:178: # Include libsqlite3-0-dbg since libsoftokn3.so uses it. http://crbug.com/82894 On ...
9 years, 7 months ago (2011-05-18 18:58:26 UTC) #5
Lei Zhang
9 years, 7 months ago (2011-05-18 20:01:13 UTC) #6
http://codereview.chromium.org/6975038/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

http://codereview.chromium.org/6975038/diff/1/build/install-build-deps.sh#new...
build/install-build-deps.sh:178: # Include libsqlite3-0-dbg since libsoftokn3.so
uses it. http://crbug.com/82894
On 2011/05/18 18:58:26, wtc wrote:
> On 2011/05/18 09:27:47, Lei Zhang wrote:
> >
> > Most of the other dbg packages correspond to a library above. Whereas the
> > libsqlite3 dbg package seems to be here for no good reason.
> 
> But that's not true.  The lib_list above also has libsqlite3-0,
> on line 172.  So this comment doesn't seem necessary.
> 

Whoops, don't know how I missed that. Removed.

Powered by Google App Engine
This is Rietveld 408576698