Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: content/browser/renderer_host/resource_dispatcher_host.cc

Issue 6975027: Add metrics for DHCP WPAD feature. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add tracking of unhandled DHCP API errors. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/net_errors.h » ('j') | net/base/net_errors.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/resource_dispatcher_host.cc
diff --git a/content/browser/renderer_host/resource_dispatcher_host.cc b/content/browser/renderer_host/resource_dispatcher_host.cc
index b5b5a897bc03487dc08aaf26b00651a55026faa1..43dacb2d7ceeff95a848e54cd46ba71b63e6bd28 100644
--- a/content/browser/renderer_host/resource_dispatcher_host.cc
+++ b/content/browser/renderer_host/resource_dispatcher_host.cc
@@ -211,17 +211,6 @@ void PopulateResourceResponse(net::URLRequest* request,
&response->response_head.appcache_manifest_url);
}
-// Returns a list of all the possible error codes from the network module.
-// Note that the error codes are all positive (since histograms expect positive
-// sample values).
-std::vector<int> GetAllNetErrorCodes() {
- std::vector<int> all_error_codes;
-#define NET_ERROR(label, value) all_error_codes.push_back(-(value));
-#include "net/base/net_error_list.h"
-#undef NET_ERROR
- return all_error_codes;
-}
-
void RemoveDownloadFileFromChildSecurityPolicy(int child_id,
const FilePath& path) {
ChildProcessSecurityPolicy::GetInstance()->RevokeAllPermissionsForFile(
@@ -1612,7 +1601,7 @@ void ResourceDispatcherHost::OnResponseCompleted(net::URLRequest* request) {
request->status().os_error() != net::ERR_ABORTED) {
UMA_HISTOGRAM_CUSTOM_ENUMERATION("Net.ErrorCodesForMainFrame",
-request->status().os_error(),
- GetAllNetErrorCodes());
+ net::GetAllErrorCodesForUma());
}
std::string security_info;
« no previous file with comments | « no previous file | net/base/net_errors.h » ('j') | net/base/net_errors.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698