Issue 6975020: Per-isolate embedder-specific data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6975020: Per-isolate embedder-specific data (Closed)

Created:
9 years, 7 months ago by Dmitry Lomov (no reviews)

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko, Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Per-isolate embedder-specific data BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7942

Patch Set 2 : Added missing file #

Total comments: 2

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -1 line)			Patch
M	include/v8.h	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/api.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/isolate.h	View		2 chunks	+8 lines, -0 lines	1 comment	Download
M	src/isolate.cc	View	1	1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

Addding per-isolate embedder-specific data.

9 years, 7 months ago (2011-05-17 17:51:50 UTC) #1

Mads Ager (chromium)

LGTM http://codereview.chromium.org/6975020/diff/2001/src/isolate.h File src/isolate.h (right): http://codereview.chromium.org/6975020/diff/2001/src/isolate.h#newcode997 src/isolate.h:997: void SetData(void* data) { I would make these ...

9 years, 7 months ago (2011-05-18 05:28:28 UTC) #2

Vitaly Repeshko

9 years, 7 months ago (2011-05-18 06:17:13 UTC) #3

LGTM

http://codereview.chromium.org/6975020/diff/2001/src/isolate.cc
File src/isolate.cc (right):

http://codereview.chromium.org/6975020/diff/2001/src/isolate.cc#newcode1399
src/isolate.cc:1399: embedder_data_(0) {
0 -> NULL

Expand Messages | Collapse Messages

Issue 6975020: Per-isolate embedder-specific data (Closed)

Description

Patch Set 1 #

Patch Set 2 : Added missing file #

Messages