Index: Source/WebCore/ChangeLog |
=================================================================== |
--- Source/WebCore/ChangeLog (revision 86683) |
+++ Source/WebCore/ChangeLog (working copy) |
@@ -1,3 +1,5381 @@ |
+2011-04-28 Steve Lacey <sjl@chromium.org> |
+ |
+ Reviewed by Eric Carlson. |
+ |
+ Change chromium media controls to use absolute positioning until bug 59644 is fixed. |
+ https://bugs.webkit.org/show_bug.cgi?id=59732 |
+ |
+ * css/mediaControlsChromium.css: |
+ (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): |
+ (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline): |
+ |
+2011-04-28 Luke Macpherson <macpherson@chromium.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Implement CSS border width and related properties in CSSStyleApplyProperty. |
+ https://bugs.webkit.org/show_bug.cgi?id=59414 |
+ |
+ No new tests as no functionality added. |
+ |
+ * css/CSSStyleApplyProperty.cpp: |
+ Separated ApplyPropertyDefault into parent and child so that other classes could inherit |
+ the applyInheritValue and applyInitialValue methods only. |
+ This was necessary to avoid casting from CSSPrimitiveValue to inappropriate types in ApplyPropertyDefault::applyValue(). |
+ |
+ Added ApplyPropertyWidth class for handling width based CSS properties. |
+ * css/CSSStyleSelector.cpp: |
+ Removed no-longer-required code for handling width based CSS properties. |
+ * css/CSSStyleSelector.h: |
+ Added a getter for m_rootElementStyle. |
+ |
+2011-04-28 Kent Tamura <tkent@chromium.org> |
+ |
+ Run sort-Xcode-project-file. |
+ |
+ * WebCore.xcodeproj/project.pbxproj: |
+ |
+2011-04-28 Martin Robinson <mrobinson@igalia.com> |
+ |
+ Reviewed by Dirk Schulze. |
+ |
+ [Cairo] Text underline is not shadowed when text-shadow is enabled |
+ https://bugs.webkit.org/show_bug.cgi?id=48074 |
+ |
+ Use ContextShadow to enable shadows for text underlines. Also remove quite a bit |
+ of duplicate code in GraphicsContext used for stroking lines. This code looks like it was |
+ originally copied from the CG GraphicsContext. |
+ |
+ * platform/graphics/GraphicsContext.h: Make adjustLineToPixelBoundaries so that we |
+ can call it from a static helper function. |
+ * platform/graphics/cairo/GraphicsContextCairo.cpp: |
+ (WebCore::calculateStrokePatternOffset): Abstracted this code into a helper. |
+ (WebCore::drawLineOnCairoContext): Abstracted this code into a helper. We need to |
+ call it multiple times when shadowing text underlines. |
+ (WebCore::GraphicsContext::drawLine): Use drawLineOnCairoContext. |
+ (WebCore::GraphicsContext::strokeArc): Use calculateStrokePatternOffset. |
+ (WebCore::GraphicsContext::drawLineForText): Use drawLineOnCairoContext. |
+ |
+2011-04-28 Sam Weinig <sam@webkit.org> |
+ |
+ Rubber-stamped by Mark Rowe. |
+ |
+ Cleanup WebCore.xcodeproj a bit. |
+ |
+ * WebCore.xcodeproj/project.pbxproj: |
+ Added CompilerVersion.xcconfig and moved some JS bindings files into the |
+ correct sub groups. |
+ |
+2011-04-28 David Levin <levin@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Remove IMAGE_RESIZER related code. |
+ https://bugs.webkit.org/show_bug.cgi?id=59735 |
+ |
+ * CMakeLists.txt: |
+ * Configurations/FeatureDefines.xcconfig: |
+ * GNUmakefile.am: |
+ * GNUmakefile.list.am: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * features.pri: |
+ * html/AsyncImageResizer.cpp: Removed. |
+ * html/AsyncImageResizer.h: Removed. |
+ * html/ImageResizerThread.cpp: Removed. |
+ * html/ImageResizerThread.h: Removed. |
+ |
+2011-04-28 Ilya Tikhonovsky <loislo@chromium.org> |
+ |
+ Unreviewed trivial one-line fix inspired by wrong patch for https://bugs.webkit.org/show_bug.cgi?id=59630. |
+ |
+ * inspector/front-end/Settings.js: |
+ (WebInspector.Settings): |
+ |
+2011-04-28 Beth Dakin <bdakin@apple.com> |
+ |
+ Rubber-stamped by Sam Weinig. |
+ |
+ Rolling out revision 85258! I want to fix that bug a different way. |
+ * platform/mac/ScrollbarThemeMac.mm: |
+ (WebCore::ScrollbarThemeMac::paint): |
+ |
+2011-04-28 Chang Shu <cshu@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ isContentEditable is not working properly with document.designMode |
+ https://bugs.webkit.org/show_bug.cgi?id=53031 |
+ |
+ The specification (http://dev.w3.org/html5/spec/Overview.html#attr-contenteditable) |
+ indicates that the element.isContentEditable relies on document.designMode if its |
+ and its ancestors' contenteditable attributes are set to inherit. |
+ |
+ 1. Sync document render style after document.designMode is changed. |
+ 2. Removed the code that does unnecessary and incorrect handling for contenteditable |
+ attribute with "inherit" value. |
+ 3. Ryosuke Niwa also helped to fix the code in ApplyStyleCommand that causes an assertion. |
+ |
+ Tests: fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html |
+ fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html |
+ fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html |
+ fast/dom/HTMLElement/iscontenteditable-designmodeon.html |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::styleForDocument): |
+ * dom/Document.cpp: |
+ (WebCore::Document::setDesignMode): |
+ * dom/Node.cpp: |
+ (WebCore::Node::rendererIsEditable): |
+ * editing/ApplyStyleCommand.cpp: |
+ (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): |
+ * html/HTMLElement.cpp: |
+ (WebCore::HTMLElement::setContentEditable): |
+ |
+2011-04-28 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r85101. |
+ http://trac.webkit.org/changeset/85101 |
+ https://bugs.webkit.org/show_bug.cgi?id=59757 |
+ |
+ it'd be better to rollout the patch and do another one with |
+ another property name. Current one will bring us to a problem |
+ at first run after upgrade because it's type was changed from |
+ int to string. (Requested by loislo on #webkit). |
+ |
+ * inspector/front-end/ScriptsPanel.js: |
+ (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled): |
+ (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback): |
+ (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions): |
+ |
+2011-04-28 Mike Reed <reed@google.com> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ fix shadw behavior for both CSS and Canvas -- skia only |
+ https://bugs.webkit.org/show_bug.cgi?id=59700 |
+ |
+ Test: |
+ canvas/philip/tests/2d.shadow.alpha.3.html |
+ canvas/philip/tests/2d.shadow.alpha.4.html |
+ canvas/philip/tests/2d.shadow.alpha.5.html |
+ fast/canvas/canvas-fillPath-alpha-shadow.html |
+ fast/canvas/canvas-strokePath-alpha-shadow.html |
+ fast/canvas/canvas-strokeRect-alpha-shadow.html |
+ fast/css/text-input-with-webkit-border-radius.html |
+ fast/repaint/shadow-multiple-horizontal.html |
+ fast/repaint/shadow-multiple-strict-horizontal.html |
+ fast/repaint/shadow-multiple-strict-vertical.html |
+ fast/repaint/shadow-multiple-vertical.html |
+ fast/canvas/canvas-getImageData.html |
+ |
+ * platform/graphics/chromium/FontChromiumWin.cpp: |
+ (WebCore::Font::drawGlyphs): |
+ * platform/graphics/skia/GraphicsContextSkia.cpp: |
+ (WebCore::GraphicsContext::setPlatformShadow): |
+ |
+2011-04-28 David Kilzer <ddkilzer@apple.com> |
+ |
+ <http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper |
+ |
+ Reviewed by Chris Fleizach. |
+ |
+ Previously, AXObjectCache::attachWrapper over-retained each |
+ AccessibilityObjectWrapper it created, which is why |
+ AXObjectCache::detachWrapper() contained an extra -release. |
+ |
+ * accessibility/mac/AXObjectCacheMac.mm: |
+ (WebCore::AXObjectCache::detachWrapper): Removed extra -release. |
+ (WebCore::AXObjectCache::attachWrapper): Because setWrapper() |
+ assigns to a RetainPtr<> instance variable, it doesn't need a +1 |
+ retained object passed in. Fix the leak by using a RetainPtr<> |
+ for the AccessibilityObjectWrapper. |
+ |
+2011-04-28 Nat Duca <nduca@chromium.org> |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ [chromium] Compute compositor fps value and history using the frameBegin timestamp |
+ https://bugs.webkit.org/show_bug.cgi?id=59668 |
+ |
+ This change switches the compositor FPS meter to use the timestamp |
+ of the beginning of the frame rather than the time we call |
+ swapBuffers. When scheduling is correctly tied to vsync, we can |
+ have highly variable times when we finish vsync and still have |
+ stable frame rates. |
+ |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::updateAndDrawLayers): |
+ * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: |
+ (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay): |
+ (WebCore::CCHeadsUpDisplay::drawFPSCounter): |
+ (WebCore::CCHeadsUpDisplay::onFrameBegin): |
+ (WebCore::CCHeadsUpDisplay::onPresent): |
+ * platform/graphics/chromium/cc/CCHeadsUpDisplay.h: |
+ |
+2011-04-28 Beth Dakin <bdakin@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=59759 |
+ Overflow:scroll regions with overlay scrollbars show full thumb instead of just a |
+ track when there is nothing to scroll to |
+ <rdar://problem/9282066> |
+ |
+ Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is |
+ nothing to scroll to. Just dividing them to get a knob proportion yields 1, which |
+ is not right. Set the proportion to 0 in this case instead. |
+ * platform/mac/ScrollbarThemeMac.mm: |
+ (WebCore::ScrollbarThemeMac::paint): |
+ |
+2011-04-28 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ <rdar://problem/9291132> Add support for -epub-prefixed properties |
+ |
+ Test: fast/css/epub-properties.html |
+ |
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp: |
+ (WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones. |
+ * css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine, |
+ -webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation, |
+ text-transform, text-transform, word-break, and -webkit-writing-mode. |
+ |
+2011-04-28 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Remove WML |
+ https://bugs.webkit.org/show_bug.cgi?id=59678 |
+ |
+ This patch removes WML from WebCore. After removing WML, there's a |
+ bunch of twisted code that could be untwisted, but this patch contains |
+ only the purely mechanical part of removing the feature. |
+ |
+ There's been a lot of discussion on webkit-dev about whether we should |
+ remove WML. In addition to those threads, we've had an informal poll |
+ of the reviewers as well as an in-person discussion at the WebKit |
+ contributor's meeting. Removing any feature is likely to make some |
+ folks unhappy, but, on balance, removing WML appears to be the right |
+ thing for the project to do at this time. |
+ |
+ * CMakeLists.txt: |
+ * CodeGenerators.pri: |
+ * Configurations/FeatureDefines.xcconfig: |
+ * DerivedSources.cpp: |
+ * DerivedSources.make: |
+ * GNUmakefile.am: |
+ * GNUmakefile.list.am: |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::linkAttribute): |
+ (WebCore::CSSStyleSelector::styleForElement): |
+ (WebCore::CSSStyleSelector::adjustRenderStyle): |
+ * css/wml.css: Removed. |
+ * dom/DOMImplementation.cpp: |
+ (WebCore::DOMImplementation::createDocument): |
+ * dom/Document.cpp: |
+ (WebCore::Document::Document): |
+ (WebCore::Document::createElement): |
+ * dom/Document.h: |
+ (WebCore::Document::isMediaDocument): |
+ * dom/Document.idl: |
+ * dom/InputElement.h: |
+ * dom/Node.cpp: |
+ (WebCore::Node::toInputElement): |
+ * dom/Node.h: |
+ * dom/OptionElement.cpp: |
+ (WebCore::toOptionElement): |
+ (WebCore::isOptionElement): |
+ * dom/OptionElement.h: |
+ * dom/OptionGroupElement.cpp: |
+ (WebCore::toOptionGroupElement): |
+ (WebCore::isOptionGroupElement): |
+ * dom/SelectElement.cpp: |
+ (WebCore::toSelectElement): |
+ * dom/SelectElement.h: |
+ * dom/Text.cpp: |
+ (WebCore::Text::attach): |
+ * dom/XMLDocumentParser.cpp: |
+ (WebCore::XMLDocumentParser::insertErrorMessageBlock): |
+ * dom/XMLDocumentParser.h: |
+ * dom/XMLDocumentParserLibxml2.cpp: |
+ (WebCore::XMLDocumentParser::internalSubset): |
+ (WebCore::getEntityHandler): |
+ * dom/XMLDocumentParserQt.cpp: |
+ (WebCore::XMLDocumentParser::parse): |
+ (WebCore::XMLDocumentParser::parseDtd): |
+ * editing/htmlediting.cpp: |
+ (WebCore::canHaveChildrenForEditing): |
+ * features.pri: |
+ * history/BackForwardList.h: |
+ * history/BackForwardListImpl.cpp: |
+ * history/BackForwardListImpl.h: |
+ * history/PageCache.cpp: |
+ (WebCore::PageCache::canCachePageContainingThisFrame): |
+ * html/HTMLAnchorElement.h: |
+ * inspector/ConsoleMessage.cpp: |
+ (WebCore::messageSourceValue): |
+ * inspector/front-end/ConsoleView.js: |
+ (WebInspector.ConsoleMessage.prototype.toString): |
+ * loader/FrameLoader.cpp: |
+ (WebCore::isBackForwardLoadType): |
+ (WebCore::FrameLoader::transitionToCommitted): |
+ (WebCore::FrameLoader::shouldReload): |
+ (WebCore::FrameLoader::loadDifferentDocumentItem): |
+ (WebCore::FrameLoader::loadItem): |
+ * loader/FrameLoaderTypes.h: |
+ * loader/HistoryController.cpp: |
+ (WebCore::HistoryController::restoreDocumentState): |
+ * manual-tests/wml: Removed. |
+ * manual-tests/wml/StartTests.wml: Removed. |
+ * manual-tests/wml/a-br-element.wml: Removed. |
+ * manual-tests/wml/a-element.wml: Removed. |
+ * manual-tests/wml/a-img-element.wml: Removed. |
+ * manual-tests/wml/access-target.wml: Removed. |
+ * manual-tests/wml/anchor-br-element.wml: Removed. |
+ * manual-tests/wml/anchor-element.wml: Removed. |
+ * manual-tests/wml/anchor-img-element.wml: Removed. |
+ * manual-tests/wml/card-newcontext-attr.wml: Removed. |
+ * manual-tests/wml/card-onenterbackward.wml: Removed. |
+ * manual-tests/wml/card-onenterforward.wml: Removed. |
+ * manual-tests/wml/card-ontimer.wml: Removed. |
+ * manual-tests/wml/deck-access-control.wml: Removed. |
+ * manual-tests/wml/input-format.wml: Removed. |
+ * manual-tests/wml/onevent-go.wml: Removed. |
+ * manual-tests/wml/onevent-noop.wml: Removed. |
+ * manual-tests/wml/onevent-prev.wml: Removed. |
+ * manual-tests/wml/onevent-refresh.wml: Removed. |
+ * manual-tests/wml/onevent-shadow.wml: Removed. |
+ * manual-tests/wml/resources: Removed. |
+ * manual-tests/wml/resources/smiley.png: Removed. |
+ * manual-tests/wml/select-element.wml: Removed. |
+ * manual-tests/wml/select-onpick-event-crash.wml: Removed. |
+ * manual-tests/wml/select-onpick-event.wml: Removed. |
+ * manual-tests/wml/setvar-element.wml: Removed. |
+ * manual-tests/wml/targetdeck.wml: Removed. |
+ * manual-tests/wml/task-go-in-anchor.wml: Removed. |
+ * manual-tests/wml/task-prev-in-anchor.wml: Removed. |
+ * manual-tests/wml/task-refresh-in-anchor.wml: Removed. |
+ * manual-tests/wml/template-go.wml: Removed. |
+ * manual-tests/wml/template-ontimer.wml: Removed. |
+ * manual-tests/wml/timer.wml: Removed. |
+ * manual-tests/wml/variable-substitution.wml: Removed. |
+ * page/Console.cpp: |
+ (WebCore::printMessageSourceAndLevelPrefix): |
+ * page/Console.h: |
+ * page/Frame.cpp: |
+ (WebCore::Frame::Frame): |
+ * page/Page.cpp: |
+ * page/Page.h: |
+ * platform/MIMETypeRegistry.cpp: |
+ (WebCore::initializeSupportedNonImageMimeTypes): |
+ * platform/network/FormDataBuilder.h: |
+ * platform/network/mac/ResourceHandleMac.mm: |
+ (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): |
+ * platform/wince/MIMETypeRegistryWinCE.cpp: |
+ (WebCore::initMIMETypeEntensionMap): |
+ * rendering/HitTestResult.cpp: |
+ (WebCore::HitTestResult::altDisplayString): |
+ (WebCore::HitTestResult::absoluteImageURL): |
+ (WebCore::HitTestResult::absoluteLinkURL): |
+ (WebCore::HitTestResult::isLiveLink): |
+ * rendering/RenderBox.cpp: |
+ * rendering/RenderButton.cpp: |
+ (WebCore::RenderButton::updateFromElement): |
+ * rendering/RenderFieldset.cpp: |
+ (WebCore::RenderFieldset::findLegend): |
+ * rendering/RenderImage.cpp: |
+ (WebCore::RenderImage::updateAltText): |
+ * rendering/RenderObject.cpp: |
+ (WebCore::RenderObject::isLegend): |
+ (WebCore::RenderObject::offsetParent): |
+ * wml: Removed. |
+ * wml/WMLAElement.cpp: Removed. |
+ * wml/WMLAElement.h: Removed. |
+ * wml/WMLAccessElement.cpp: Removed. |
+ * wml/WMLAccessElement.h: Removed. |
+ * wml/WMLAnchorElement.cpp: Removed. |
+ * wml/WMLAnchorElement.h: Removed. |
+ * wml/WMLAttributeNames.in: Removed. |
+ * wml/WMLBRElement.cpp: Removed. |
+ * wml/WMLBRElement.h: Removed. |
+ * wml/WMLCardElement.cpp: Removed. |
+ * wml/WMLCardElement.h: Removed. |
+ * wml/WMLDoElement.cpp: Removed. |
+ * wml/WMLDoElement.h: Removed. |
+ * wml/WMLDocument.cpp: Removed. |
+ * wml/WMLDocument.h: Removed. |
+ * wml/WMLElement.cpp: Removed. |
+ * wml/WMLElement.h: Removed. |
+ * wml/WMLErrorHandling.cpp: Removed. |
+ * wml/WMLErrorHandling.h: Removed. |
+ * wml/WMLEventHandlingElement.cpp: Removed. |
+ * wml/WMLEventHandlingElement.h: Removed. |
+ * wml/WMLFieldSetElement.cpp: Removed. |
+ * wml/WMLFieldSetElement.h: Removed. |
+ * wml/WMLFormControlElement.cpp: Removed. |
+ * wml/WMLFormControlElement.h: Removed. |
+ * wml/WMLGoElement.cpp: Removed. |
+ * wml/WMLGoElement.h: Removed. |
+ * wml/WMLImageElement.cpp: Removed. |
+ * wml/WMLImageElement.h: Removed. |
+ * wml/WMLImageLoader.cpp: Removed. |
+ * wml/WMLImageLoader.h: Removed. |
+ * wml/WMLInputElement.cpp: Removed. |
+ * wml/WMLInputElement.h: Removed. |
+ * wml/WMLInsertedLegendElement.cpp: Removed. |
+ * wml/WMLInsertedLegendElement.h: Removed. |
+ * wml/WMLIntrinsicEvent.cpp: Removed. |
+ * wml/WMLIntrinsicEvent.h: Removed. |
+ * wml/WMLIntrinsicEventHandler.cpp: Removed. |
+ * wml/WMLIntrinsicEventHandler.h: Removed. |
+ * wml/WMLMetaElement.cpp: Removed. |
+ * wml/WMLMetaElement.h: Removed. |
+ * wml/WMLNoopElement.cpp: Removed. |
+ * wml/WMLNoopElement.h: Removed. |
+ * wml/WMLOnEventElement.cpp: Removed. |
+ * wml/WMLOnEventElement.h: Removed. |
+ * wml/WMLOptGroupElement.cpp: Removed. |
+ * wml/WMLOptGroupElement.h: Removed. |
+ * wml/WMLOptionElement.cpp: Removed. |
+ * wml/WMLOptionElement.h: Removed. |
+ * wml/WMLPElement.cpp: Removed. |
+ * wml/WMLPElement.h: Removed. |
+ * wml/WMLPageState.cpp: Removed. |
+ * wml/WMLPageState.h: Removed. |
+ * wml/WMLPostfieldElement.cpp: Removed. |
+ * wml/WMLPostfieldElement.h: Removed. |
+ * wml/WMLPrevElement.cpp: Removed. |
+ * wml/WMLPrevElement.h: Removed. |
+ * wml/WMLRefreshElement.cpp: Removed. |
+ * wml/WMLRefreshElement.h: Removed. |
+ * wml/WMLSelectElement.cpp: Removed. |
+ * wml/WMLSelectElement.h: Removed. |
+ * wml/WMLSetvarElement.cpp: Removed. |
+ * wml/WMLSetvarElement.h: Removed. |
+ * wml/WMLTableElement.cpp: Removed. |
+ * wml/WMLTableElement.h: Removed. |
+ * wml/WMLTagNames.in: Removed. |
+ * wml/WMLTaskElement.cpp: Removed. |
+ * wml/WMLTaskElement.h: Removed. |
+ * wml/WMLTemplateElement.cpp: Removed. |
+ * wml/WMLTemplateElement.h: Removed. |
+ * wml/WMLTimerElement.cpp: Removed. |
+ * wml/WMLTimerElement.h: Removed. |
+ * wml/WMLVariables.cpp: Removed. |
+ * wml/WMLVariables.h: Removed. |
+ |
+2011-04-28 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r85233 and r85235. |
+ http://trac.webkit.org/changeset/85233 |
+ http://trac.webkit.org/changeset/85235 |
+ https://bugs.webkit.org/show_bug.cgi?id=59754 |
+ |
+ Causes issues with jsc. (Requested by dave_levin on #webkit). |
+ |
+ * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed. |
+ * loader/icon/IconDatabase.cpp: |
+ (WebCore::IconDatabase::defaultIcon): |
+ (WebCore::IconDatabase::setIconDataForIconURL): |
+ (WebCore::IconDatabase::getOrCreateIconRecord): |
+ (WebCore::IconDatabase::readFromDatabase): |
+ |
+2011-04-28 Jay Civelli <jcivelli@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Introducing a new class that allows serialization of a page back |
+ to HTML/XML with all its sub-frames and also retrieves the page's |
+ resources. |
+ Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=58947 |
+ |
+ * Android.mk: |
+ * CMakeLists.txt: |
+ * GNUmakefile.list.am: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * dom/Document.cpp: |
+ (WebCore::Document::suggestedMIMEType): |
+ * dom/Document.h: |
+ * editing/MarkupAccumulator.cpp: |
+ (WebCore::MarkupAccumulator::appendCustomAttributes): |
+ (WebCore::MarkupAccumulator::appendElement): |
+ * editing/MarkupAccumulator.h: |
+ * html/parser/HTMLMetaCharsetParser.cpp: |
+ (WebCore::HTMLMetaCharsetParser::processMeta): |
+ (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes): |
+ * html/parser/HTMLMetaCharsetParser.h: |
+ * page/PageSerializer.cpp: Added. |
+ * page/PageSerializer.h: Added. |
+ |
+2011-04-28 Mark Pilgrim <pilgrim@chromium.org> |
+ |
+ Reviewed by Tony Chang. |
+ |
+ IndexedDB createIndex should fail if name arg is null |
+ https://bugs.webkit.org/show_bug.cgi?id=58365 |
+ |
+ Test: storage/indexeddb/mozilla/create-index-null-name.html |
+ |
+ * storage/IDBObjectStore.idl: |
+ * storage/IDBObjectStoreBackendImpl.cpp: |
+ (WebCore::IDBObjectStoreBackendImpl::createIndex): |
+ |
+2011-04-28 Mark Pilgrim <pilgrim@chromium.org> |
+ |
+ Reviewed by Tony Chang. |
+ |
+ IndexedDB put() should fail if second (key) parameter is null |
+ https://bugs.webkit.org/show_bug.cgi?id=58613 |
+ |
+ If key arg is not specified, prpKey ends up as a null pointer in ::put(). |
+ However, if the key arg is specified but is null, prpKey ends up as a |
+ valid IDBKey which has a null key type. As it happens, we need to be able |
+ to detect the difference between these cases (the key arg is optional but |
+ if specified must not be null). |
+ |
+ Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html |
+ |
+ * storage/IDBObjectStoreBackendImpl.cpp: |
+ (WebCore::IDBObjectStoreBackendImpl::put): |
+ |
+2011-04-07 David Levin <levin@chromium.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Add asserts to RefCounted to make sure ref/deref happens on the right thread. |
+ https://bugs.webkit.org/show_bug.cgi?id=31639 |
+ |
+ No new functionality exposed so no new tests. (The change is basically adding |
+ more testing.) |
+ |
+ * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added. |
+ * loader/icon/IconDatabase.cpp: |
+ (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable. |
+ (WebCore::IconDatabase::getOrCreateIconRecord): Ditto. |
+ (WebCore::IconDatabase::setIconDataForIconURL): Ditto. |
+ (WebCore::IconDatabase::readFromDatabase): Ditto. |
+ |
+2011-04-28 Kenneth Russell <kbr@google.com> |
+ |
+ Unreviewed build fix for Web Audio with strict OwnPtr. |
+ |
+ * platform/audio/HRTFDatabaseLoader.cpp: |
+ (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader): |
+ |
+2011-04-28 Dominic Cooney <dominicc@chromium.org> |
+ |
+ Reviewed by Geoffrey Garen. |
+ |
+ Walk shadow hosts as well as parent nodes when finding opaque roots. |
+ https://bugs.webkit.org/show_bug.cgi?id=59571 |
+ |
+ Test: fast/dom/shadow/gc-shadow.html |
+ |
+ * bindings/js/JSDOMBinding.h: |
+ (WebCore::root): |
+ |
+2011-04-28 Martin Robinson <mrobinson@igalia.com> |
+ |
+ Reviewed by Xan Lopez. |
+ |
+ [GTK] Click counting logic should be shared between WebKit1 and WebKit2 |
+ https://bugs.webkit.org/show_bug.cgi?id=59715 |
+ |
+ Added a GtkClickCounter class which is just the logic from WebKit1 pushed down |
+ into WebCore so that WebKit1 and WebKit2 can share the code. |
+ |
+ No new tests. This is covered by fast/events/click-count.html. |
+ |
+ * GNUmakefile.list.am: Added new files. |
+ * platform/gtk/GtkClickCounter.cpp: Added. |
+ (WebCore::GtkClickCounter::GtkClickCounter): Added. |
+ (WebCore::GtkClickCounter::reset): Added. |
+ (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added. |
+ (WebCore::getEventTime): Added. |
+ (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added. |
+ * platform/gtk/GtkClickCounter.h: Added. |
+ |
+2011-04-28 Dan Bernstein <mitz@apple.com> |
+ |
+ Build fix. |
+ |
+ * css/CSSParser.cpp: |
+ (WebCore::cssPropertyID): |
+ |
+2011-04-28 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ Allow specifying CSS property aliases in CSSPropertyNames.in files |
+ https://bugs.webkit.org/show_bug.cgi?id=59712 |
+ |
+ * css/CSSParser.cpp: |
+ (WebCore::cssPropertyID): Removed code to handle some aliases |
+ * css/CSSPropertyNames.in: Added aliases no longer handled in code. |
+ * css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as |
+ defining an alias, and add an appropriate entry to the gperf file. |
+ |
+2011-04-28 Arno Renevier <arno@renevier.net> |
+ |
+ Reviewed by Gustavo Noronha Silva. |
+ |
+ [Soup] does not load css stylesheets without content-type |
+ https://bugs.webkit.org/show_bug.cgi?id=59697 |
+ |
+ When sniffing content type, do not replace http Content-Type header in |
+ soup message anymore, but keep sniffed content type in a separate |
+ variable. |
+ |
+ * platform/network/soup/ResourceHandleSoup.cpp: |
+ (WebCore::contentSniffedCallback): |
+ * platform/network/soup/ResourceResponse.h: |
+ (WebCore::ResourceResponse::sniffedContentType): |
+ (WebCore::ResourceResponse::setSniffedContentType): |
+ * platform/network/soup/ResourceResponseSoup.cpp: |
+ (WebCore::ResourceResponse::updateFromSoupMessage): |
+ |
+2011-04-28 Yael Aharon <yael.aharon@nokia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER |
+ https://bugs.webkit.org/show_bug.cgi?id=59704 |
+ |
+ No new tests, just code cleanup. |
+ |
+ * WebCore.pri: |
+ |
+2011-04-28 Pavel Podivilov <podivilov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: remove "Pretty print" source frame context menu item. |
+ https://bugs.webkit.org/show_bug.cgi?id=59709 |
+ |
+ * inspector/front-end/DebuggerPresentationModel.js: |
+ (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles): |
+ * inspector/front-end/ScriptsPanel.js: |
+ (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles): |
+ * inspector/front-end/SourceFrame.js: |
+ (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu): |
+ |
+2011-04-28 Satish Sampath <satish@chromium.org> |
+ |
+ Reviewed by Tony Gentilcore. |
+ |
+ Speech input button layout issues with padding and border. |
+ https://bugs.webkit.org/show_bug.cgi?id=59613 |
+ |
+ * rendering/RenderTextControlSingleLine.cpp: |
+ (WebCore::RenderTextControlSingleLine::layout): |
+ (WebCore::RenderTextControlSingleLine::nodeAtPoint): |
+ (WebCore::RenderTextControlSingleLine::forwardEvent): |
+ |
+2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com> |
+ |
+ Reviewed by Martin Robinson. |
+ |
+ [GTK] Check whether to use native scrollbars at run time |
+ https://bugs.webkit.org/show_bug.cgi?id=59694 |
+ |
+ It's currently decided at build time depending on whether webkit2 |
+ build is enabled or not. That makes imposible to build both |
+ webkit1 and webkit2 using the same libWebCore. |
+ |
+ * GNUmakefile.am: |
+ * platform/ScrollView.cpp: |
+ (WebCore::ScrollView::wheelEvent): |
+ * platform/gtk/ScrollViewGtk.cpp: |
+ (WebCore::ScrollView::createScrollbar): |
+ |
+2011-04-28 Pavel Feldman <pfeldman@google.com> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: add status bar button for pretty print. |
+ https://bugs.webkit.org/show_bug.cgi?id=59467 |
+ |
+ * WebCore.gypi: |
+ * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added. |
+ * inspector/front-end/ScriptsPanel.js: |
+ (WebInspector.ScriptsPanel): |
+ (WebInspector.ScriptsPanel.prototype.get statusBarItems): |
+ (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles): |
+ * inspector/front-end/WebKit.qrc: |
+ * inspector/front-end/inspector.css: |
+ (.scripts-toggle-pretty-print-status-bar-item .glyph): |
+ (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph): |
+ |
+2011-04-28 Pavel Feldman <pfeldman@google.com> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: add ResourceTreeModel tests. |
+ https://bugs.webkit.org/show_bug.cgi?id=59616 |
+ |
+ Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html |
+ http/tests/inspector/resource-tree/resource-tree-frame-navigate.html |
+ http/tests/inspector/resource-tree/resource-tree-reload.html |
+ |
+ * inspector/front-end/ResourceTreeModel.js: |
+ (WebInspector.ResourceTreeModel.prototype.frontendReused): |
+ (WebInspector.ResourceTreeModel.prototype._addFrame): |
+ (WebInspector.ResourceTreeModel.prototype._frameNavigated): |
+ (WebInspector.ResourceTreeModel.prototype._frameDetached): |
+ (WebInspector.ResourceTreeModel.prototype._onResourceUpdated): |
+ (WebInspector.ResourceTreeModel.prototype.forAllResources): |
+ (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): |
+ (WebInspector.ResourceTreeModel.prototype._callForFrameResources): |
+ (WebInspector.ResourceTreeModel.prototype._addFramesRecursively): |
+ * inspector/front-end/ResourcesPanel.js: |
+ (WebInspector.ResourcesPanel.prototype._populateResourceTree): |
+ (WebInspector.ResourcesPanel.prototype._frameAdded): |
+ (WebInspector.ResourcesPanel.prototype._frameDetached): |
+ (WebInspector.ResourcesPanel.prototype._frameNavigated): |
+ (WebInspector.FrameTreeElement): |
+ (WebInspector.FrameTreeElement.prototype.frameNavigated): |
+ |
+2011-04-28 Mikhail Naganov <mnaganov@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots. |
+ https://bugs.webkit.org/show_bug.cgi?id=59592 |
+ |
+ * inspector/front-end/DetailedHeapshotGridNodes.js: |
+ (WebInspector.HeapSnapshotGridNode.prototype._populate): |
+ (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved): |
+ (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize): |
+ (WebInspector.HeapSnapshotGridNode.prototype.populateChildren): |
+ * inspector/front-end/DetailedHeapshotView.js: |
+ (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand): |
+ (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute): |
+ (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound): |
+ (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute): |
+ (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid): |
+ (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete): |
+ (WebInspector.DetailedHeapshotView.prototype.changeView): |
+ * inspector/front-end/HeapSnapshot.js: |
+ (WebInspector.HeapSnapshotPathFinder.prototype.findNext): |
+ (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter): |
+ (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath): |
+ (WebInspector.HeapSnapshotPathFinder.prototype._pathToString): |
+ (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute): |
+ * inspector/front-end/heapProfiler.css: |
+ (div.retaining-paths-view td.path-column div:hover): |
+ |
+2011-04-28 Mikhail Naganov <mnaganov@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing. |
+ https://bugs.webkit.org/show_bug.cgi?id=59454 |
+ |
+ Test: inspector/profiler/heap-snapshot-loader.html |
+ |
+ * inspector/front-end/HeapSnapshot.js: |
+ (WebInspector.HeapSnapshotLoader): |
+ (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets): |
+ (WebInspector.HeapSnapshotLoader.prototype.finishLoading): |
+ (WebInspector.HeapSnapshotLoader.prototype._parseNodes): |
+ (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray): |
+ (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk): |
+ * inspector/front-end/HeapSnapshotProxy.js: |
+ (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage): |
+ |
+2011-04-28 ojab <ojab@ojab.ru> |
+ |
+ Reviewed by David Levin. |
+ |
+ Fix build with libpng-1.5.1 |
+ https://bugs.webkit.org/show_bug.cgi?id=59607 |
+ |
+ * platform/image-decoders/png/PNGImageDecoder.cpp: |
+ (WebCore::readColorProfile): |
+ |
+2011-04-28 Zoltan Herczeg <zherczeg@inf.u-szeged.hu> |
+ |
+ Reviewed by Nikolas Zimmermann. |
+ |
+ Optimizing gaussian blur filter to ARM-neon SIMD instruction set |
+ https://bugs.webkit.org/show_bug.cgi?id=59447 |
+ |
+ This patch contains two sub-routines, one for speeding up |
+ alpha channel only gaussian blur (by 2.5 times) and one |
+ for speeding up all channel blur (by 4 times). |
+ |
+ The common code is also redesigned to better fit for platform |
+ specific code. This means large chunks of code was moved to |
+ different files, and all platform specific files are added to |
+ all build systems. |
+ |
+ * CMakeLists.txt: |
+ * GNUmakefile.am: |
+ * GNUmakefile.list.am: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.vcproj/WebCoreCommon.vsprops: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * platform/graphics/filters/FEGaussianBlur.cpp: |
+ (WebCore::FEGaussianBlur::platformApplyGeneric): |
+ (WebCore::FEGaussianBlur::apply): |
+ * platform/graphics/filters/FEGaussianBlur.h: |
+ (WebCore::FEGaussianBlur::kernelPosition): |
+ (WebCore::FEGaussianBlur::platformApply): |
+ * platform/graphics/filters/FELighting.cpp: |
+ (WebCore::FELighting::platformApplyGeneric): |
+ (WebCore::FELighting::drawLighting): |
+ * platform/graphics/filters/FELighting.h: |
+ (WebCore::FELighting::platformApply): |
+ * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added. |
+ (WebCore::WTF_ALIGNED): |
+ (WebCore::feGaussianBlurConstantsForNeon): |
+ * platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added. |
+ (WebCore::FEGaussianBlur::platformApplyNeon): |
+ * platform/graphics/filters/arm/FELightingNEON.cpp: |
+ (WebCore::WTF_ALIGNED): |
+ (WebCore::FELighting::getPowerCoefficients): |
+ * platform/graphics/filters/arm/FELightingNEON.h: |
+ (WebCore::FELighting::platformApplyNeon): |
+ |
+2011-04-28 Alexander Pavlov <apavlov@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: provide a hotkey for script pause |
+ https://bugs.webkit.org/show_bug.cgi?id=59593 |
+ |
+ In fact, F8 works as a hotkey, but this fact was not reflected |
+ in the shortcut help popup. |
+ |
+ * English.lproj/localizedStrings.js: |
+ * inspector/front-end/ScriptsPanel.js: |
+ (WebInspector.ScriptsPanel.prototype._registerShortcuts): |
+ |
+2011-04-28 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ PluginStream should play nice with strict OwnPtr |
+ https://bugs.webkit.org/show_bug.cgi?id=59675 |
+ |
+ These failures appear when enabling strict OwnPtr on Qt. |
+ |
+ * plugins/PluginStream.cpp: |
+ (WebCore::PluginStream::PluginStream): |
+ (WebCore::PluginStream::didReceiveData): |
+ |
+2011-04-26 Alexander Pavlov <apavlov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text |
+ https://bugs.webkit.org/show_bug.cgi?id=59326 |
+ |
+ Concrete CachedResource successors for stylesheets and scripts |
+ can decode their content better than the generic approach we use. |
+ |
+ * inspector/InspectorPageAgent.cpp: |
+ (WebCore::decodeSharedBuffer): |
+ (WebCore::prepareCachedResourceBuffer): |
+ (WebCore::cachedResourceDecoded): |
+ (WebCore::InspectorPageAgent::resourceContent): |
+ (WebCore::InspectorPageAgent::resourceData): |
+ * inspector/InspectorStyleSheet.cpp: |
+ (WebCore::InspectorStyleSheet::originalStyleSheetText): |
+ |
+2011-04-28 Jon Lee <jonlee@apple.com> |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ REGRESSION: white overlay scrollbars on apple.com/startpage |
+ https://bugs.webkit.org/show_bug.cgi?id=59540 |
+ <rdar://problem/9338653> |
+ |
+ Now we look at the document background in addition to the <body> element, |
+ and blend those colors in with the base background of the frame view to |
+ arrive at our aggregate color. This provides a better result to determine |
+ overlay scrollbar style. |
+ |
+ * page/Frame.cpp: |
+ (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them. |
+ * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation |
+ |
+2011-04-27 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Maciej Stachowiak. |
+ |
+ Fix OwnPtr issues in IndexedDB |
+ https://bugs.webkit.org/show_bug.cgi?id=59656 |
+ |
+ This patch is an attempt to fix the clang build. Clang can't seem to |
+ cope with OwnPtrs to classes declared in an anonymous namespace because |
+ OwnPtr's copy constructor isn't defined (but would need to be defined |
+ in this translation unit). |
+ |
+ * platform/leveldb/LevelDBDatabase.cpp: |
+ |
+2011-04-27 Ryuan Choi <ryuan.choi@samsung.com> |
+ |
+ Reviewed by Antonio Gomes. |
+ |
+ [EFL] Change cursor to LAZY_NATIVE_CURSOR |
+ https://bugs.webkit.org/show_bug.cgi?id=59411 |
+ |
+ Enable LAZY_NATIVE_CURSOR on EFL build. |
+ |
+ No test added because functionality is unchanged. |
+ |
+ * CMakeListsEfl.txt: Add Cursor.cpp |
+ * platform/Cursor.h: |
+ (WebCore::Cursor::Cursor): |
+ * platform/efl/CursorEfl.cpp: |
+ (WebCore::Cursor::Cursor): |
+ (WebCore::Cursor::~Cursor): |
+ (WebCore::getCursorString): |
+ (WebCore::Cursor::ensurePlatformCursor): |
+ * platform/efl/WidgetEfl.cpp: |
+ (WebCore::Widget::setCursor): |
+ |
+2011-04-27 Adam Barth <abarth@webkit.org> |
+ |
+ Build fix from the future. Another trival strict OwnPtr fixes. This |
+ is the last futuristic build fix I can detect with my time traveling |
+ abilities. |
+ |
+ * platform/graphics/chromium/TransparencyWin.cpp: |
+ (WebCore::TransparencyWin::initializeNewContext): |
+ |
+2011-04-27 Dmitry Lomov <dslomov@google.com> |
+ |
+ Reviewed by David Levin. |
+ |
+ CrossThreadCopier should not have a default specialization for raw pointers |
+ https://bugs.webkit.org/show_bug.cgi?id=59234 |
+ Removed the ablity to pass raw pointers cross-thread |
+ Added and applied annotations for doing that |
+ |
+ * fileapi/FileReader.cpp: |
+ (WebCore::FileReader::readInternal): |
+ (WebCore::FileReader::abort): |
+ * fileapi/FileStreamProxy.cpp: |
+ (WebCore::FileStreamProxy::startOnFileThread): |
+ (WebCore::FileStreamProxy::stopOnFileThread): |
+ (WebCore::FileStreamProxy::getSize): |
+ (WebCore::FileStreamProxy::getSizeOnFileThread): |
+ (WebCore::FileStreamProxy::openForRead): |
+ (WebCore::FileStreamProxy::openForReadOnFileThread): |
+ (WebCore::FileStreamProxy::openForWrite): |
+ (WebCore::FileStreamProxy::openForWriteOnFileThread): |
+ (WebCore::FileStreamProxy::close): |
+ (WebCore::FileStreamProxy::read): |
+ (WebCore::FileStreamProxy::readOnFileThread): |
+ (WebCore::FileStreamProxy::write): |
+ (WebCore::FileStreamProxy::writeOnFileThread): |
+ (WebCore::FileStreamProxy::truncate): |
+ (WebCore::FileStreamProxy::truncateOnFileThread): |
+ * loader/WorkerThreadableLoader.cpp: |
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): |
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy): |
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): |
+ * page/GeolocationPositionCache.cpp: |
+ (WebCore::GeolocationPositionCache::triggerReadFromDatabase): |
+ (WebCore::GeolocationPositionCache::triggerWriteToDatabase): |
+ * platform/CrossThreadCopier.h: |
+ (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper): |
+ (WebCore::AllowCrossThreadAccessWrapper::value): |
+ (WebCore::AllowCrossThreadAccess): |
+ (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper): |
+ (WebCore::AllowExtendedLifetimeWrapper::value): |
+ (WebCore::AllowExtendedLifetime): |
+ * platform/graphics/chromium/cc/CCCompletionEvent.h: |
+ * storage/IDBObjectStoreBackendImpl.cpp: |
+ (WebCore::IDBObjectStoreBackendImpl::get): |
+ (WebCore::IDBObjectStoreBackendImpl::put): |
+ (WebCore::IDBObjectStoreBackendImpl::deleteFunction): |
+ (WebCore::IDBObjectStoreBackendImpl::clear): |
+ (WebCore::IDBObjectStoreBackendImpl::createIndex): |
+ (WebCore::IDBObjectStoreBackendImpl::deleteIndex): |
+ (WebCore::IDBObjectStoreBackendImpl::openCursor): |
+ * storage/SQLCallbackWrapper.h: |
+ (WebCore::SQLCallbackWrapper::clear): |
+ * websockets/WorkerThreadableWebSocketChannel.cpp: |
+ (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel): |
+ (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge): |
+ (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect): |
+ (WebCore::WorkerThreadableWebSocketChannel::Bridge::send): |
+ (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount): |
+ (WebCore::WorkerThreadableWebSocketChannel::Bridge::close): |
+ (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect): |
+ (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend): |
+ (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume): |
+ * workers/WorkerMessagingProxy.cpp: |
+ (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject): |
+ |
+2011-04-27 Adam Barth <abarth@webkit.org> |
+ |
+ Two build fixes from the future. (Trivial strict OwnPtr fixes.) |
+ |
+ * page/Frame.cpp: |
+ (WebCore::Frame::setTiledBackingStoreEnabled): |
+ * platform/audio/ReverbConvolver.cpp: |
+ (WebCore::ReverbConvolver::ReverbConvolver): |
+ |
+2011-04-27 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ Fix five strict PassOwnPtr violations in WebCore |
+ https://bugs.webkit.org/show_bug.cgi?id=59640 |
+ |
+ * css/MediaList.cpp: |
+ (WebCore::MediaList::deleteMedium): |
+ (WebCore::MediaList::setMediaText): |
+ (WebCore::MediaList::appendMedium): |
+ * css/MediaQuery.h: |
+ * dom/MessagePort.cpp: |
+ (WebCore::MessagePort::disentanglePorts): |
+ (WebCore::MessagePort::entanglePorts): |
+ * inspector/InspectorStyleSheet.cpp: |
+ (ParsedStyleSheet::setText): |
+ * rendering/RenderTheme.cpp: |
+ (WebCore::RenderTheme::adjustStyle): |
+ (WebCore::RenderTheme::adjustMeterStyle): |
+ * rendering/RenderThemeMac.mm: |
+ (WebCore::RenderThemeMac::adjustMenuListStyle): |
+ (WebCore::RenderThemeMac::adjustSliderTrackStyle): |
+ (WebCore::RenderThemeMac::adjustSliderThumbStyle): |
+ (WebCore::RenderThemeMac::adjustSearchFieldStyle): |
+ (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle): |
+ (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle): |
+ (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle): |
+ (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle): |
+ |
+2011-04-27 Chris Fleizach <cfleizach@apple.com> |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks |
+ https://bugs.webkit.org/show_bug.cgi?id=59648 |
+ |
+ Test: accessibility/aria-fallback-roles.html |
+ |
+ * accessibility/AccessibilityObject.cpp: |
+ (WebCore::AccessibilityObject::ariaRoleToWebCoreRole): |
+ |
+2011-04-27 Beth Dakin <bdakin@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=59671 |
+ Race condition with scrollbar animations and closing a page can cause a crash in |
+ WebCore::FrameView::setVisibleScrollerThumbRect + 15 |
+ -and corresponding- |
+ <rdar://problem/9329253> |
+ |
+ It is definitely possible for Page to be null here. So we should null-check it! |
+ And we should not ASSERT. |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::didCompleteRubberBand): |
+ (WebCore::FrameView::scrollbarStyleChanged): |
+ (WebCore::FrameView::setVisibleScrollerThumbRect): |
+ |
+2011-04-27 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ WinCE build fix after r85143. |
+ |
+ * platform/graphics/wince/FontWinCE.cpp: |
+ (WebCore::TextRunComponent::TextRunComponent): |
+ |
+2011-04-27 Mark Pilgrim <pilgrim@chromium.org> |
+ |
+ Reviewed by Tony Chang. |
+ |
+ IndexedDB object store delete should fail if key is null |
+ https://bugs.webkit.org/show_bug.cgi?id=58614 |
+ |
+ Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html |
+ |
+ * storage/IDBObjectStoreBackendImpl.cpp: |
+ (WebCore::IDBObjectStoreBackendImpl::deleteFunction): |
+ |
+2011-04-27 Eric Seidel <eric@webkit.org> |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ Should have an easy way to construct starting BidiStatus for a paragraph root |
+ https://bugs.webkit.org/show_bug.cgi?id=59226 |
+ |
+ Two places try to construct BidiStatuses for a paragraph root using copy/paste code. |
+ I've made this a constructor for BidiStatus instead. |
+ |
+ As part of this effort I added a direction() accessor for TextRun and got |
+ rid of the old m_rtl bool. This is part of the generic effort in the |
+ Bidi code to replace old bool usage with the superior TextDirection enum |
+ (this generally makes the code cleaner). |
+ |
+ As part of this replacement effort I found several places which were |
+ assuming LTR (by passing rtl=false) when they probably want to use |
+ the current text direction. I suspect that LTR vs. RTL may affect |
+ string width in the case of ligatures. It's unclear. |
+ |
+ This is almost entirely a mechanical change. |
+ |
+ * html/canvas/CanvasRenderingContext2D.cpp: |
+ (WebCore::CanvasRenderingContext2D::drawTextInternal): |
+ * platform/graphics/GraphicsContext.cpp: |
+ (WebCore::GraphicsContext::drawBidiText): |
+ * platform/graphics/TextRun.h: |
+ (WebCore::TextRun::TextRun): |
+ (WebCore::TextRun::direction): |
+ (WebCore::TextRun::rtl): |
+ (WebCore::TextRun::ltr): |
+ (WebCore::TextRun::setDirection): |
+ * platform/text/BidiResolver.h: |
+ (WebCore::BidiStatus::BidiStatus): |
+ * rendering/EllipsisBox.cpp: |
+ (WebCore::EllipsisBox::paint): |
+ (WebCore::EllipsisBox::selectionRect): |
+ (WebCore::EllipsisBox::paintSelection): |
+ * rendering/InlineTextBox.cpp: |
+ (WebCore::InlineTextBox::selectionRect): |
+ (WebCore::InlineTextBox::paint): |
+ (WebCore::InlineTextBox::paintSelection): |
+ (WebCore::InlineTextBox::paintCompositionBackground): |
+ (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): |
+ (WebCore::InlineTextBox::paintTextMatchMarker): |
+ (WebCore::InlineTextBox::computeRectForReplacementMarker): |
+ (WebCore::InlineTextBox::offsetForPosition): |
+ (WebCore::InlineTextBox::positionForOffset): |
+ * rendering/RenderBlockLineLayout.cpp: |
+ (WebCore::RenderBlock::determineStartPosition): |
+ * rendering/RenderFileUploadControl.cpp: |
+ (WebCore::RenderFileUploadControl::paintObject): |
+ (WebCore::RenderFileUploadControl::computePreferredLogicalWidths): |
+ * rendering/RenderListBox.cpp: |
+ (WebCore::RenderListBox::updateFromElement): |
+ (WebCore::RenderListBox::paintItemForeground): |
+ * rendering/RenderTextControl.cpp: |
+ (WebCore::RenderTextControl::getAvgCharWidth): |
+ (WebCore::RenderTextControl::paintPlaceholder): |
+ * rendering/svg/SVGInlineTextBox.cpp: |
+ (WebCore::SVGInlineTextBox::constructTextRun): |
+ * rendering/svg/SVGTextMetrics.cpp: |
+ (WebCore::constructTextRun): |
+ |
+2011-04-27 Robert Hogan <robert@webkit.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Allow shadowing of history object |
+ https://bugs.webkit.org/show_bug.cgi?id=55965 |
+ |
+ Tests: http/tests/history/cross-origin-replace-history-object-child.html |
+ http/tests/history/cross-origin-replace-history-object.html |
+ |
+ * page/DOMWindow.idl: |
+ |
+2011-04-27 James Robinson <jamesr@chromium.org> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ [chromium] Ensure compositing layers are up to date before entering doComposite |
+ https://bugs.webkit.org/show_bug.cgi?id=59159 |
+ |
+ Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during |
+ GraphicsLayerClient::paintContents() implementations). |
+ |
+ * platform/graphics/chromium/GraphicsLayerChromium.cpp: |
+ (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): |
+ * platform/graphics/chromium/LayerChromium.cpp: |
+ (WebCore::LayerChromium::LayerChromium): |
+ (WebCore::LayerChromium::~LayerChromium): |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::updateLayers): |
+ * platform/graphics/chromium/LayerRendererChromium.h: |
+ Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents |
+ |
+2011-04-27 James Robinson <jamesr@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Fix OwnPtr strict issues in chromium linux build |
+ https://bugs.webkit.org/show_bug.cgi?id=59664 |
+ |
+ * platform/graphics/chromium/ComplexTextControllerLinux.cpp: |
+ (WebCore::ComplexTextController::getNormalizedTextRun): |
+ * platform/graphics/skia/ImageBufferSkia.cpp: |
+ (WebCore::ImageBuffer::ImageBuffer): |
+ * platform/graphics/skia/PlatformContextSkia.cpp: |
+ (WebCore::PlatformContextSkia::PlatformContextSkia): |
+ |
+2011-04-27 Chris Rogers <crogers@google.com> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting() |
+ https://bugs.webkit.org/show_bug.cgi?id=59641 |
+ |
+ No new tests since audio API is not yet implemented. |
+ |
+ * platform/audio/AudioBus.cpp: |
+ (WebCore::AudioBus::createBySampleRateConverting): |
+ (WebCore::AudioBus::createByMixingToMono): |
+ |
+2011-04-27 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Motivated by Alexey Proskuryakov. |
+ |
+ * bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more |
+ informative, since it confused Alexey and me. |
+ |
+2011-04-27 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld |
+ https://bugs.webkit.org/show_bug.cgi?id=59646 |
+ |
+ Made the cssValueRoots map per-world, instead of a global. When we deallocate |
+ a world, we need to clear all entries in the map for that world, since |
+ the finalizers that would otherwise clear those entries don't run. The |
+ simplest way to do this is just to make the world own the map. |
+ |
+ * bindings/js/DOMWrapperWorld.h: |
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp: |
+ (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue): |
+ * bindings/js/JSCSSValueCustom.cpp: |
+ (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots): |
+ (WebCore::JSCSSValueOwner::finalize): |
+ * bindings/js/JSDOMBinding.h: |
+ |
+2011-04-27 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ Fix OwnPtr issues in IndexedDB |
+ https://bugs.webkit.org/show_bug.cgi?id=59656 |
+ |
+ I didn't do an exhaustive review of this code, but I fixed the problems |
+ caught by turning on strict OwnPtr and all their antecedents. This |
+ patch is entirely tighter bookkeeping. There shouldn't be any actual |
+ behavior change. |
+ |
+ * platform/leveldb/LevelDBDatabase.cpp: |
+ (WebCore::LevelDBDatabase::LevelDBDatabase): |
+ (WebCore::LevelDBDatabase::open): |
+ (WebCore::LevelDBDatabase::createIterator): |
+ * platform/leveldb/LevelDBDatabase.h: |
+ * platform/leveldb/LevelDBIterator.cpp: |
+ (WebCore::LevelDBIterator::LevelDBIterator): |
+ * platform/leveldb/LevelDBIterator.h: |
+ * storage/IDBLevelDBBackingStore.cpp: |
+ (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore): |
+ (WebCore::IDBLevelDBBackingStore::open): |
+ (WebCore::getNewDatabaseId): |
+ (WebCore::IDBLevelDBBackingStore::getObjectStores): |
+ (WebCore::getNewObjectStoreId): |
+ (WebCore::deleteRange): |
+ (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber): |
+ (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord): |
+ (WebCore::IDBLevelDBBackingStore::getIndexes): |
+ (WebCore::getNewIndexId): |
+ (WebCore::findGreatestKeyLessThan): |
+ (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex): |
+ (WebCore::IDBLevelDBBackingStore::keyExistsInIndex): |
+ (WebCore::findLastIndexKeyEqualTo): |
+ * storage/IDBLevelDBBackingStore.h: |
+ |
+2011-04-19 MORITA Hajime <morrita@google.com> |
+ |
+ Reviewed by Tony Chang. |
+ |
+ [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class. |
+ https://bugs.webkit.org/show_bug.cgi?id=58113 |
+ |
+ * Introduced RenderedDocumentMarker, a subclass of DocumentMarker. |
+ * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker |
+ * Now MarkerMapVectorPair is no longer used. |
+ |
+ No new tests, No behavior change. |
+ |
+ * GNUmakefile.list.am: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * dom/DocumentMarker.h: |
+ * dom/DocumentMarkerController.cpp: |
+ (WebCore::DocumentMarkerController::addMarker): |
+ (WebCore::DocumentMarkerController::copyMarkers): |
+ (WebCore::DocumentMarkerController::removeMarkers): |
+ (WebCore::DocumentMarkerController::markerContainingPoint): |
+ (WebCore::DocumentMarkerController::markersForNode): |
+ (WebCore::DocumentMarkerController::renderedRectsForMarkers): |
+ (WebCore::DocumentMarkerController::removeMarkersFromList): |
+ (WebCore::DocumentMarkerController::repaintMarkers): |
+ (WebCore::DocumentMarkerController::setRenderedRectForMarker): |
+ (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect): |
+ (WebCore::DocumentMarkerController::shiftMarkers): |
+ (WebCore::DocumentMarkerController::setMarkersActive): |
+ (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange): |
+ (WebCore::DocumentMarkerController::showMarkers): |
+ * dom/DocumentMarkerController.h: |
+ * dom/RenderedDocumentMarker.h: Added. |
+ (WebCore::RenderedDocumentMarker::RenderedDocumentMarker): |
+ (WebCore::RenderedDocumentMarker::isRendered): |
+ (WebCore::RenderedDocumentMarker::contains): |
+ (WebCore::RenderedDocumentMarker::setRenderedRect): |
+ (WebCore::RenderedDocumentMarker::renderedRect): |
+ (WebCore::RenderedDocumentMarker::invalidate): |
+ (WebCore::RenderedDocumentMarker::invalidMarkerRect): |
+ |
+2011-04-27 James Robinson <jamesr@chromium.org> |
+ |
+ Unreviewed, rolling out r85112. |
+ http://trac.webkit.org/changeset/85112 |
+ https://bugs.webkit.org/show_bug.cgi?id=59159 |
+ |
+ Broke mac compile |
+ |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::updateCompositingLayers): |
+ * page/FrameView.h: |
+ * platform/graphics/chromium/GraphicsLayerChromium.cpp: |
+ (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): |
+ * platform/graphics/chromium/LayerChromium.cpp: |
+ (WebCore::LayerChromium::LayerChromium): |
+ (WebCore::LayerChromium::~LayerChromium): |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::updateLayers): |
+ * platform/graphics/chromium/LayerRendererChromium.h: |
+ |
+2011-04-27 Mark Rowe <mrowe@apple.com> |
+ |
+ Build fix. |
+ |
+ * WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2. |
+ |
+2011-04-27 Pratik Solanki <psolanki@apple.com> |
+ |
+ Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK). |
+ |
+ * platform/network/ResourceHandleClient.h: |
+ |
+2011-04-27 James Robinson <jamesr@chromium.org> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ [chromium] Ensure compositing layers are up to date before entering doComposite |
+ https://bugs.webkit.org/show_bug.cgi?id=59159 |
+ |
+ Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during |
+ GraphicsLayerClient::paintContents() implementations). |
+ |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::updateCompositingLayers): |
+ Add an optional CompositingUpdateType parameter. |
+ * page/FrameView.h: |
+ * platform/graphics/chromium/GraphicsLayerChromium.cpp: |
+ (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): |
+ * platform/graphics/chromium/LayerChromium.cpp: |
+ (WebCore::LayerChromium::LayerChromium): |
+ (WebCore::LayerChromium::~LayerChromium): |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::updateLayers): |
+ * platform/graphics/chromium/LayerRendererChromium.h: |
+ Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents |
+ * rendering/RenderLayer.cpp: |
+ (WebCore::RenderLayer::dirtyZOrderLists): |
+ (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded): |
+ * rendering/RenderLayerCompositor.cpp: |
+ (WebCore::RenderLayerCompositor::updateCompositingLayers): |
+ * rendering/RenderLayerCompositor.h: |
+ Fix a typo in CompositingUpdateType Pait->Paint |
+ |
+2011-04-27 Pratik Solanki <psolanki@apple.com> |
+ |
+ Reviewed by Antti Koivisto. |
+ |
+ Part of WebCore should use CFNetwork-based loader on Mac |
+ https://bugs.webkit.org/show_bug.cgi?id=51836 |
+ |
+ Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around |
+ willCacheResponse/shouldCacheResponse. |
+ |
+ * loader/EmptyClients.h: |
+ * loader/FrameLoaderClient.h: |
+ * loader/ResourceLoader.h: |
+ * loader/cf/ResourceLoaderCFNet.cpp: |
+ * loader/mac/ResourceLoaderMac.mm: |
+ (WebCore::ResourceLoader::willCacheResponse): |
+ * platform/network/ResourceHandleClient.h: |
+ (WebCore::ResourceHandleClient::willCacheResponse): |
+ (WebCore::ResourceHandleClient::shouldCacheResponse): |
+ * platform/network/cf/ResourceHandleCFNet.cpp: |
+ (WebCore::willCacheResponse): |
+ |
+2011-04-27 Ilya Tikhonovsky <loislo@chromium.org> |
+ |
+ Reviewed by Brian Weinstein. |
+ |
+ Web Inspector: Stop on Exception state does not persist. |
+ |
+ A wrong property name was used when we persist PauseOnExceptionState property to Local Storage. |
+ https://bugs.webkit.org/show_bug.cgi?id=59630 |
+ |
+ * inspector/front-end/ScriptsPanel.js: |
+ (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled): |
+ (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback): |
+ (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions): |
+ |
+2011-04-27 Adrienne Walker <enne@google.com> |
+ |
+ [chromium] Unreviewed, rollout r85075 (scissor rect changes) |
+ https://bugs.webkit.org/show_bug.cgi?id=59020 |
+ |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): |
+ |
+2011-04-27 Darin Adler <darin@apple.com> |
+ |
+ Reviewed by David Levin. |
+ |
+ Fix strict OwnPtr issues seen in about 30 more files |
+ https://bugs.webkit.org/show_bug.cgi?id=59615 |
+ |
+ * bindings/js/JSCallbackData.h: |
+ (WebCore::DeleteCallbackDataTask::create): Use adoptPtr. |
+ * bindings/js/JSMessageEventCustom.cpp: |
+ (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr. |
+ * css/CSSParser.cpp: |
+ (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr, |
+ adoptPtr, and release. |
+ * dom/MessageEvent.cpp: |
+ (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr, |
+ and release. |
+ * dom/MessagePortChannel.cpp: |
+ (WebCore::MessagePortChannel::EventData::create): Use adoptPtr. |
+ * dom/ScriptExecutionContext.cpp: |
+ (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr. |
+ * dom/XMLDocumentParserLibxml2.cpp: |
+ (WebCore::XMLDocumentParser::doEnd): Use adoptPtr. |
+ * dom/default/PlatformMessagePortChannel.cpp: |
+ (WebCore::MessagePortChannel::create): Use adoptPtr. |
+ * html/HTMLFormControlElement.cpp: |
+ (WebCore::HTMLFormControlElement::detach): Use nullptr. |
+ * inspector/InspectorAgent.cpp: |
+ (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr. |
+ * inspector/InspectorConsoleAgent.cpp: |
+ (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr. |
+ (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr. |
+ (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr. |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::connectFrontend): Use adoptPtr. |
+ * inspector/InspectorDOMAgent.cpp: |
+ (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr. |
+ * inspector/InspectorResourceAgent.cpp: |
+ (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr. |
+ * page/FrameActionScheduler.cpp: |
+ (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr. |
+ * platform/graphics/ShadowBlur.cpp: |
+ (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr. |
+ * platform/graphics/ca/GraphicsLayerCA.cpp: |
+ (WebCore::GraphicsLayer::create): Use adoptPtr. |
+ (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr. |
+ (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr. |
+ * rendering/RenderBlock.cpp: |
+ (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr. |
+ (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr. |
+ (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr. |
+ (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr. |
+ * rendering/RenderLayerBacking.cpp: |
+ (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr. |
+ (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr. |
+ (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr. |
+ (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr. |
+ * rendering/RenderLayerCompositor.cpp: |
+ (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr. |
+ (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr. |
+ (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr. |
+ * rendering/style/StyleRareNonInheritedData.cpp: |
+ (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed |
+ explicit initializations of OwnPtr members to 0. Use adoptPtr. |
+ * workers/SharedWorkerContext.cpp: |
+ (WebCore::createConnectEvent): Use adoptPtr. |
+ * workers/Worker.cpp: |
+ (WebCore::Worker::notifyFinished): Use nullptr. |
+ |
+2011-04-27 Enrica Casucci <enrica@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected. |
+ https://bugs.webkit.org/show_bug.cgi?id=59251 |
+ <rdar://problem/9327044> |
+ |
+ When we are looking for wrapping elements that are presentational, we should |
+ include elements that have a non transparent background color only if they |
+ are not blocks. |
+ |
+ Test: editing/pasteboard/do-not-copy-body-color.html |
+ |
+ * editing/markup.cpp: |
+ (WebCore::isElementPresentational): |
+ |
+2011-04-20 Dimitri Glazkov <dglazkov@chromium.org> |
+ |
+ Reviewed by Antti Koivisto. |
+ |
+ Teach sub-selector chains about shadow descendants |
+ https://bugs.webkit.org/show_bug.cgi?id=58342 |
+ |
+ The primary change is to the logic of parsing specifiers: |
+ 1) The shadow descendant selectors (those specifiers that are unknown |
+ pseudo element selectors) are always kept at the top of the chain. |
+ 2) The sub-selectors after shadow descendant selectors are stashed right |
+ behind the sub-selector, but not at the end of the chain. |
+ 3) Other sub-selectors are appended at the end of the chain. |
+ |
+ * css/CSSGrammar.y: Changed specifier_list collection to use new |
+ CSSParser::updateSpecifier helper. |
+ * css/CSSParser.cpp: |
+ (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to |
+ look for the last ShadowDescendant relation in the chain of selectors, |
+ because the next selector after it is the one that should get the |
+ element name. |
+ (WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from |
+ CSSGrammar.y. The new logic adjusts the selector chain to allow |
+ shadow descendant selectors have sub-selectors (and have multiple shadow |
+ descendants in the chain). |
+ * css/CSSParser.h: Added decl. |
+ * css/CSSParserValues.cpp: |
+ (WebCore::CSSParserSelector::insertTagHistory): Added. |
+ (WebCore::CSSParserSelector::appendTagHistory): Aded. |
+ * css/CSSParserValues.h: Added decls. |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added |
+ shadow descendant selector match check, since now there could be many |
+ of them in the selector chain. |
+ |
+2011-04-20 Adrienne Walker <enne@google.com> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ [chromium] Fix incorrect scissor rect for layers that render into a rendersurface |
+ https://bugs.webkit.org/show_bug.cgi?id=59020 |
+ |
+ mapRect is the incorrect transform here. The parent scissor rect |
+ needs to be projected into layer space instead. |
+ |
+ Test: compositing/flat-with-transformed-child.html |
+ |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): |
+ |
+2011-04-27 Pratik Solanki <psolanki@apple.com> |
+ |
+ Reviewed by Antti Koivisto. |
+ |
+ Part of WebCore should use CFNetwork-based loader on Mac |
+ https://bugs.webkit.org/show_bug.cgi?id=51836 |
+ |
+ * Configurations/WebCore.xcconfig: Add location of CFNetwork.framework. |
+ * platform/mac/SoftLinking.h: |
+ * platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac. |
+ |
+2011-04-27 Nikolas Zimmermann <nzimmermann@rim.com> |
+ |
+ Reviewed by Antti Koivisto. |
+ |
+ Cleanup CSSStyleApplyProperty.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=59623 |
+ |
+ As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes. |
+ Use typedefs instead of repating the function pointer declarations in a few places. |
+ |
+ * css/CSSStyleApplyProperty.cpp: |
+ (WebCore::ApplyPropertyDefault::ApplyPropertyDefault): |
+ (WebCore::ApplyPropertyColor::ApplyPropertyColor): |
+ (WebCore::ApplyPropertyColor::applyInheritValue): |
+ (WebCore::ApplyPropertyColor::applyInitialValue): |
+ (WebCore::ApplyPropertyColor::applyValue): |
+ (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): |
+ |
+2011-04-27 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Anders Carlsson. |
+ |
+ <rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly |
+ https://bugs.webkit.org/show_bug.cgi?id=59622 |
+ |
+ Test: fast/borders/border-image-trumps-radius.html |
+ |
+ * rendering/RenderBox.cpp: |
+ (WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border |
+ image, then border radius is ignored, so no bleed avoidance is needed. |
+ * rendering/RenderObject.cpp: |
+ (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from... |
+ (WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here. |
+ * rendering/RenderObject.h: |
+ |
+2011-02-03 Martin Robinson <mrobinson@igalia.com> |
+ |
+ Reviewed by Xan Lopez. |
+ |
+ [GTK] editing/pasteboard/copy-standalone-image.html fails |
+ https://bugs.webkit.org/show_bug.cgi?id=53645 |
+ |
+ When writing an image to the clipboard, also write the URL and title |
+ into the markup and URL portion. This change also abstracts a helper |
+ imageToMarkup into markup.{cpp/h} from several different locations |
+ throughout the platform layer. |
+ |
+ * editing/markup.h: Added new function definition. |
+ * editing/markup.cpp: |
+ (WebCore::imageToMarkup): Add this function which turns an image URL |
+ and element into some markup representing that image, while preserving |
+ non-src attributes. |
+ * platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper |
+ to markup.cpp. |
+ * platform/gtk/PasteboardGtk.cpp: |
+ (WebCore::getURLForImageNode): Add this helper which gets the appropriate |
+ image URL for a variety of image tag types. |
+ (WebCore::Pasteboard::writeImage): Write the image URL and title to the |
+ markup and URL portions of the clipboard. This will ensure that images |
+ paste properly back into WebKit. |
+ * platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the |
+ one from markup.h |
+ |
+2011-04-27 Steve Block <steveblock@google.com> |
+ |
+ Reviewed by David Levin. |
+ |
+ Remove Android build system |
+ https://bugs.webkit.org/show_bug.cgi?id=48111 |
+ |
+ This is to avoid the maintenance burden until the Android port is |
+ fully upstreamed. |
+ |
+ No new tests, build change only. |
+ |
+ * Android.derived.jscbindings.mk: Removed. |
+ * Android.derived.mk: Removed. |
+ * Android.derived.v8bindings.mk: Removed. |
+ * Android.jscbindings.mk: Removed. |
+ * Android.mk: Removed. |
+ * Android.v8bindings.mk: Removed. |
+ |
+2011-04-27 Darin Adler <darin@apple.com> |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Somehow about:blank gets into the icon database |
+ https://bugs.webkit.org/show_bug.cgi?id=58067 |
+ rdar://problem/6751446 |
+ |
+ Implemented the policy Brady suggested, where only http and https URLs can |
+ be associated with and icon, guarding both on the way in to the database, |
+ and on the way out. |
+ |
+ * loader/icon/IconDatabase.cpp: |
+ (WebCore::pageCanHaveIcon): Added. |
+ (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon |
+ instead of just checking for an empty URL. |
+ (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto. |
+ (WebCore::IconDatabase::retainIconForPageURL): Ditto. |
+ (WebCore::IconDatabase::releaseIconForPageURL): Ditto. |
+ (WebCore::IconDatabase::setIconURLForPageURL): Ditto. |
+ (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto. |
+ (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into |
+ two separate assertions and added a third. |
+ (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon. |
+ |
+ * platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file. |
+ (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name, |
+ overloaded it to work on both UChar and char, and added an assertion to it. |
+ Also moved this to the top of the file and made the UChar version usable |
+ in the shared code used even by Google. |
+ (WebCore::KURL::invalidate): Updated for name change. |
+ (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of |
+ toASCIILower since it's faster. |
+ (WebCore::KURL::parse): Updated for name changes. |
+ (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower |
+ since it's faster. |
+ (WebCore::protocolIsInHTTPFamily): Added. |
+ |
+ * platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily |
+ to protocolIsInHTTPFamily and added a version that works on a string. |
+ Kept the old name as an inline function so we don't have to rename |
+ all the cal sites now. |
+ |
+ * platform/KURLGoogle.cpp: Renamed as above. |
+ (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename. |
+ (WebCore::KURLGooglePrivate::setUtf8): Ditto. |
+ (WebCore::KURLGooglePrivate::setAscii): Ditto. |
+ (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto. |
+ (WebCore::KURLGooglePrivate::copyTo): Ditto. |
+ (WebCore::KURL::KURL): Ditto. |
+ (WebCore::KURL::protocolIsInHTTPFamily): Ditto. |
+ (WebCore::KURL::invalidate): Ditto. |
+ * platform/KURLGooglePrivate.h: Ditto. |
+ |
+ * WebCore.exp.in: Updated for above changes. |
+ |
+2011-04-27 Yury Semikhatsky <yurys@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: browser crash on evaluation of 'throw undefined' |
+ https://bugs.webkit.org/show_bug.cgi?id=59611 |
+ |
+ Test: inspector/console/console-eval-throw-undefined.html |
+ |
+ * inspector/InjectedScriptSource.js: use try/catch to protect from |
+ exception during conversion of another exception to string. |
+ |
+2011-04-27 Pavel Feldman <pfeldman@google.com> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: clicking bookmarklet multiplies resources panel entries. |
+ https://bugs.webkit.org/show_bug.cgi?id=59590 |
+ |
+ * inspector/front-end/ResourceTreeModel.js: |
+ (WebInspector.ResourceTreeModel): |
+ (WebInspector.ResourceTreeModel.prototype._processCachedResources): |
+ (WebInspector.ResourceTreeModel.prototype._frameNavigated): |
+ * inspector/front-end/ResourcesPanel.js: |
+ (WebInspector.ResourcesPanel.prototype._populateResourceTree): |
+ (WebInspector.FrameTreeElement): |
+ (WebInspector.FrameTreeElement.prototype.appendResource): |
+ * inspector/front-end/inspector.js: |
+ (WebInspector.frontendReused): |
+ |
+2011-04-27 Pavel Feldman <pfeldman@google.com> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: opening bookmarklet disconnects DOM agent. |
+ https://bugs.webkit.org/show_bug.cgi?id=59588 |
+ |
+ * inspector/InspectorDOMAgent.cpp: |
+ (WebCore::InspectorDOMAgent::setDocument): |
+ |
+2011-04-27 Hans Wennborg <hans@chromium.org> |
+ |
+ Reviewed by Tony Gentilcore. |
+ |
+ IndexedDB: Fix compiler warnings about uninitialized variables |
+ https://bugs.webkit.org/show_bug.cgi?id=59599 |
+ |
+ Build fix. No new tests. |
+ |
+ * storage/IDBLevelDBBackingStore.cpp: |
+ (WebCore::getNewObjectStoreId): |
+ (WebCore::getNewIndexId): |
+ |
+2011-04-26 Hans Wennborg <hans@chromium.org> |
+ |
+ Reviewed by Tony Gentilcore. |
+ |
+ IndexedDB: Move LevelDB key coding routines to separate file |
+ https://bugs.webkit.org/show_bug.cgi?id=59452 |
+ |
+ Move all routines concerned with encoding, decoding and comparison of |
+ LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file: |
+ IDBLevelDBCoding.cpp. |
+ |
+ This makes IDBLevelDBBackingStore.cpp easier to work with, and will |
+ allow for unit testing of the coding routines. |
+ |
+ No new functionality, no new tests. |
+ |
+ * WebCore.gypi: |
+ * storage/IDBLevelDBBackingStore.cpp: |
+ (WebCore::getInt): |
+ (WebCore::putInt): |
+ (WebCore::getString): |
+ (WebCore::putString): |
+ (WebCore::compareKeys): |
+ (WebCore::compareIndexKeys): |
+ (WebCore::Comparator::compare): |
+ (WebCore::setUpMetadata): |
+ (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData): |
+ (WebCore::getNewDatabaseId): |
+ (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData): |
+ (WebCore::IDBLevelDBBackingStore::getObjectStores): |
+ (WebCore::getNewObjectStoreId): |
+ (WebCore::IDBLevelDBBackingStore::createObjectStore): |
+ (WebCore::IDBLevelDBBackingStore::deleteObjectStore): |
+ (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord): |
+ (WebCore::getNewVersionNumber): |
+ (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord): |
+ (WebCore::IDBLevelDBBackingStore::clearObjectStore): |
+ (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord): |
+ (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber): |
+ (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore): |
+ (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord): |
+ (WebCore::IDBLevelDBBackingStore::getIndexes): |
+ (WebCore::getNewIndexId): |
+ (WebCore::IDBLevelDBBackingStore::createIndex): |
+ (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord): |
+ (WebCore::versionExists): |
+ (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex): |
+ (WebCore::IDBLevelDBBackingStore::keyExistsInIndex): |
+ (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): |
+ (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): |
+ (WebCore::IDBLevelDBBackingStore::openIndexCursor): |
+ * storage/IDBLevelDBCoding.cpp: Added. |
+ (WebCore::IDBLevelDBCoding::encodeByte): |
+ (WebCore::IDBLevelDBCoding::maxIDBKey): |
+ (WebCore::IDBLevelDBCoding::minIDBKey): |
+ (WebCore::IDBLevelDBCoding::encodeInt): |
+ (WebCore::IDBLevelDBCoding::decodeInt): |
+ (WebCore::IDBLevelDBCoding::encodeVarInt): |
+ (WebCore::IDBLevelDBCoding::decodeVarInt): |
+ (WebCore::IDBLevelDBCoding::encodeString): |
+ (WebCore::IDBLevelDBCoding::decodeString): |
+ (WebCore::IDBLevelDBCoding::encodeStringWithLength): |
+ (WebCore::IDBLevelDBCoding::decodeStringWithLength): |
+ (WebCore::IDBLevelDBCoding::encodeDouble): |
+ (WebCore::IDBLevelDBCoding::decodeDouble): |
+ (WebCore::IDBLevelDBCoding::encodeIDBKey): |
+ (WebCore::IDBLevelDBCoding::decodeIDBKey): |
+ (WebCore::IDBLevelDBCoding::extractEncodedIDBKey): |
+ (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys): |
+ (WebCore::IDBLevelDBCoding::compare): |
+ (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix): |
+ (WebCore::IDBLevelDBCoding::KeyPrefix::decode): |
+ (WebCore::IDBLevelDBCoding::KeyPrefix::encode): |
+ (WebCore::IDBLevelDBCoding::KeyPrefix::compare): |
+ (WebCore::IDBLevelDBCoding::KeyPrefix::type): |
+ (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode): |
+ (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode): |
+ (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey): |
+ (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode): |
+ (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode): |
+ (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId): |
+ (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare): |
+ (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode): |
+ (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode): |
+ (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare): |
+ (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare): |
+ (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey): |
+ (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode): |
+ (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode): |
+ (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare): |
+ (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare): |
+ (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey): |
+ (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode): |
+ (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode): |
+ (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare): |
+ (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId): |
+ (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare): |
+ (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey): |
+ (WebCore::IDBLevelDBCoding::IndexNamesKey::decode): |
+ (WebCore::IDBLevelDBCoding::IndexNamesKey::encode): |
+ (WebCore::IDBLevelDBCoding::IndexNamesKey::compare): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey): |
+ (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode): |
+ (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode): |
+ (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare): |
+ (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey): |
+ (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey): |
+ (WebCore::IDBLevelDBCoding::IndexDataKey::decode): |
+ (WebCore::IDBLevelDBCoding::IndexDataKey::encode): |
+ (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey): |
+ (WebCore::IDBLevelDBCoding::IndexDataKey::compare): |
+ (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId): |
+ (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId): |
+ (WebCore::IDBLevelDBCoding::IndexDataKey::indexId): |
+ (WebCore::IDBLevelDBCoding::IndexDataKey::userKey): |
+ * storage/IDBLevelDBCoding.h: Added. |
+ (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin): |
+ (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName): |
+ (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType): |
+ (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName): |
+ (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName): |
+ |
+2011-04-27 Yury Semikhatsky <yurys@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: expose exception details when script is paused on exception |
+ https://bugs.webkit.org/show_bug.cgi?id=59591 |
+ |
+ When script is paused on an exception, the exception value is added as <exception> |
+ property in the local scope and the breakpoint details message says |
+ "Paused on excepion: '<exception to strin value>'." |
+ |
+ * English.lproj/localizedStrings.js: |
+ * inspector/front-end/ScopeChainSidebarPane.js: |
+ (WebInspector.ScopeChainSidebarPane.prototype.update): |
+ * inspector/front-end/ScriptsPanel.js: |
+ (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation): |
+ (WebInspector.ScriptsPanel.prototype._debuggerPaused): |
+ |
+2011-04-26 Yury Semikhatsky <yurys@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: [protocol] Paused event should expose exception value that caused it |
+ https://bugs.webkit.org/show_bug.cgi?id=58996 |
+ |
+ Debug.pause event now contains an optional reference to the exception |
+ object in case script execution is paused on a JavaScript exception. |
+ |
+ Also JavaScript call frames are passed directly into the injected script when |
+ we need to wrap them for passing to the front-end. This change breaks cyclic |
+ dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer |
+ |
+ * bindings/js/JSInjectedScriptHostCustom.cpp: |
+ * bindings/js/ScriptDebugServer.cpp: |
+ (WebCore::ScriptDebugServer::dispatchDidPause): |
+ * bindings/js/ScriptDebugServer.h: |
+ * bindings/v8/ScriptDebugServer.cpp: |
+ (WebCore::ScriptDebugServer::breakProgram): |
+ (WebCore::ScriptDebugServer::editScriptSource): |
+ (WebCore::ScriptDebugServer::breakProgramCallback): |
+ (WebCore::ScriptDebugServer::handleV8DebugEvent): |
+ * bindings/v8/ScriptDebugServer.h: |
+ * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: |
+ * inspector/InjectedScript.cpp: |
+ (WebCore::InjectedScript::evaluateOnCallFrame): |
+ (WebCore::InjectedScript::wrapCallFrames): |
+ * inspector/InjectedScript.h: |
+ * inspector/InjectedScriptHost.cpp: |
+ * inspector/InjectedScriptHost.h: |
+ (WebCore::InjectedScriptHost::init): |
+ * inspector/InjectedScriptHost.idl: |
+ * inspector/InjectedScriptSource.js: |
+ (.): |
+ * inspector/Inspector.json: |
+ * inspector/InspectorAgent.cpp: |
+ (WebCore::InspectorAgent::InspectorAgent): |
+ * inspector/InspectorDebuggerAgent.cpp: |
+ (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): |
+ (WebCore::InspectorDebuggerAgent::currentCallFrames): |
+ (WebCore::InspectorDebuggerAgent::wrapCallFrames): |
+ (WebCore::InspectorDebuggerAgent::didPause): |
+ (WebCore::InspectorDebuggerAgent::didContinue): |
+ (WebCore::InspectorDebuggerAgent::clear): |
+ * inspector/InspectorDebuggerAgent.h: |
+ * inspector/ScriptDebugListener.h: |
+ * inspector/WorkerInspectorController.cpp: |
+ (WebCore::WorkerInspectorController::WorkerInspectorController): |
+ |
+2011-04-27 Pavel Feldman <pfeldman@google.com> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: implement incremental CSS editing in the structure view. |
+ https://bugs.webkit.org/show_bug.cgi?id=59455 |
+ |
+ * inspector/front-end/StylesSidebarPane.js: |
+ (WebInspector.StylePropertyTreeElement.prototype): |
+ |
+2011-04-27 Mihai Parparita <mihaip@chromium.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Frame.h shouldn't include Document.h |
+ https://bugs.webkit.org/show_bug.cgi?id=59560 |
+ |
+ Frame can use a forward-declared Document if we move |
+ Frame::displayStringModifiedByEncoding's implementation out of the |
+ header. |
+ Size #includes Size * #includes |
+ Before: page/Frame.h: 0.746 653 487.138 |
+ dom/Document.h: 0.220 1306 287.320 |
+ |
+ After: page/Frame.h: 0.646 653 421.838 |
+ dom/Document.h: 0.220 1189 261.580 |
+ |
+ * WebCore.exp.in: |
+ * bindings/ScriptControllerBase.cpp: |
+ * bindings/generic/BindingSecurityBase.cpp: |
+ * bindings/v8/V8Proxy.cpp: |
+ * bindings/v8/custom/V8XMLHttpRequestCustom.cpp: |
+ * dom/CharacterData.cpp: |
+ * dom/UserTypingGestureIndicator.cpp: |
+ * editing/chromium/SelectionControllerChromium.cpp: |
+ * inspector/InspectorDOMStorageResource.cpp: |
+ * inspector/InspectorInstrumentation.h: |
+ * loader/PingLoader.cpp: |
+ * loader/SubresourceLoader.cpp: |
+ * loader/appcache/DOMApplicationCache.cpp: |
+ * loader/cache/CachedResourceRequest.cpp: |
+ * page/Frame.cpp: |
+ (WebCore::Frame::displayStringModifiedByEncoding): |
+ * page/Frame.h: |
+ * page/Geolocation.cpp: |
+ * page/Location.cpp: |
+ * page/Navigator.cpp: |
+ * page/PageGroupLoadDeferrer.cpp: |
+ * page/PerformanceTiming.cpp: |
+ * xml/XSLTProcessorLibxslt.cpp: |
+ |
+2011-04-27 James Robinson <jamesr@chromium.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr |
+ https://bugs.webkit.org/show_bug.cgi?id=59377 |
+ |
+ This cleans up some strict OwnPtr<> violations around text and box shadow data. ShadowData's linked list data |
+ structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData. |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::applyProperty): |
+ * page/animation/AnimationBase.cpp: |
+ (WebCore::blendFunc): |
+ (WebCore::PropertyWrapperShadow::PropertyWrapperShadow): |
+ (WebCore::PropertyWrapperShadow::blend): |
+ * rendering/style/RenderStyle.cpp: |
+ (WebCore::RenderStyle::setTextShadow): |
+ (WebCore::RenderStyle::setBoxShadow): |
+ * rendering/style/RenderStyle.h: |
+ (WebCore::InheritedFlags::textShadow): |
+ * rendering/style/ShadowData.cpp: |
+ (WebCore::ShadowData::ShadowData): |
+ * rendering/style/ShadowData.h: |
+ (WebCore::ShadowData::ShadowData): |
+ (WebCore::ShadowData::next): |
+ (WebCore::ShadowData::setNext): |
+ * rendering/style/StyleRareInheritedData.cpp: |
+ (WebCore::StyleRareInheritedData::StyleRareInheritedData): |
+ (WebCore::StyleRareInheritedData::~StyleRareInheritedData): |
+ * rendering/style/StyleRareInheritedData.h: |
+ * rendering/style/StyleRareNonInheritedData.cpp: |
+ (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): |
+ |
+2011-04-26 David Levin <levin@chromium.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Fix some strict PassOwnPtr issues in WebCore. |
+ https://bugs.webkit.org/show_bug.cgi?id=59563 |
+ |
+ * css/SVGCSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::applySVGProperty): |
+ * html/canvas/WebGLRenderingContext.cpp: |
+ (WebCore::WebGLRenderingContext::create): |
+ (WebCore::WebGLRenderingContext::~WebGLRenderingContext): |
+ * platform/text/TextCodecLatin1.cpp: |
+ (WebCore::newStreamingTextDecoderWindowsLatin1): |
+ * platform/text/TextCodecUTF16.cpp: |
+ (WebCore::newStreamingTextDecoderUTF16LE): |
+ (WebCore::newStreamingTextDecoderUTF16BE): |
+ * platform/text/TextCodecUserDefined.cpp: |
+ (WebCore::newStreamingTextDecoderUserDefined): |
+ * platform/text/mac/TextCodecMac.cpp: |
+ (WebCore::newTextCodecMac): |
+ * workers/Worker.cpp: |
+ (WebCore::Worker::notifyFinished): |
+ |
+2011-04-26 Justin Novosad <junov@chromium.org> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ [Chromium] Expose skia gpu canvas rendering as a runtime flag |
+ https://bugs.webkit.org/show_bug.cgi?id=58683 |
+ Replace the SKIA_GPU compile flag by the pre-existing |
+ acceleratedDrawingEnabled flag. Most code changes are trivial: |
+ compile-time conditionals on SKIA_GPU were either replaced with |
+ a run-time check, or a compile time check on USE(SKIA) |
+ |
+ No new tests. Covered by existing tests. |
+ |
+ * html/canvas/CanvasRenderingContext2D.cpp: |
+ (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation): |
+ * page/Page.cpp: |
+ (WebCore::Page::sharedGraphicsContext3D): |
+ Added check for the acceleratedDrawing flag. |
+ * platform/graphics/chromium/DrawingBufferChromium.cpp: |
+ (WebCore::DrawingBuffer::DrawingBuffer): |
+ (WebCore::DrawingBuffer::publishToPlatformLayer): |
+ * platform/graphics/gpu/DrawingBuffer.h: |
+ * platform/graphics/gpu/SharedGraphicsContext3D.cpp: |
+ (WebCore::SharedGraphicsContext3D::create): |
+ On Skia builds, this methos now receives a bool arg to turn on |
+ GPU-accelerated skia rendering |
+ (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): |
+ (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D): |
+ (WebCore::SharedGraphicsContext3D::grContext): |
+ * platform/graphics/gpu/SharedGraphicsContext3D.h: |
+ * platform/graphics/skia/ImageSkia.cpp: |
+ (WebCore::computeResamplingMode): |
+ (WebCore::paintSkBitmap): |
+ (WebCore::Image::drawPattern): |
+ * platform/graphics/skia/PlatformContextSkia.cpp: |
+ (WebCore::PlatformContextSkia::PlatformContextSkia): |
+ (WebCore::PlatformContextSkia::~PlatformContextSkia): |
+ (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed): |
+ (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): |
+ (WebCore::PlatformContextSkia::prepareForSoftwareDraw): |
+ (WebCore::PlatformContextSkia::prepareForHardwareDraw): |
+ (WebCore::PlatformContextSkia::syncSoftwareCanvas): |
+ (WebCore::PlatformContextSkia::markDirtyRect): |
+ * platform/graphics/skia/PlatformContextSkia.h: |
+ (WebCore::PlatformContextSkia::accelerationMode): |
+ (WebCore::PlatformContextSkia::useGPU): |
+ (WebCore::PlatformContextSkia::useSkiaGPU): |
+ |
+2011-04-26 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Not reviewed: restore inspector test disabled in r84913. |
+ |
+ Test: http/tests/inspector-enabled/dom-storage-open.html |
+ |
+ * inspector/InspectorDOMStorageAgent.cpp: |
+ (WebCore::InspectorDOMStorageAgent::clearFrontend): |
+ |
+2011-04-26 Kenichi Ishibashi <bashi@chromium.org> |
+ |
+ Reviewed by Tony Chang. |
+ |
+ [Chromium] Vertical positions are off for some Arabic glyphs on Linux |
+ https://bugs.webkit.org/show_bug.cgi?id=59182 |
+ |
+ Use vertical offsets of the shaping results. |
+ |
+ Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html |
+ |
+ * platform/graphics/chromium/ComplexTextControllerLinux.cpp: |
+ (WebCore::ComplexTextController::ComplexTextController): |
+ Added initialization of m_startingY. |
+ (WebCore::ComplexTextController::nextScriptRun): |
+ Followed the change in handling positions. |
+ (WebCore::ComplexTextController::deleteGlyphArrays): Ditto. |
+ (WebCore::ComplexTextController::createGlyphArrays): Ditto. |
+ (WebCore::ComplexTextController::resetGlyphArrays): Ditto. |
+ (WebCore::ComplexTextController::setGlyphPositions): |
+ Changed to use vertical offsets as same as horizontal offsets. |
+ * platform/graphics/chromium/ComplexTextControllerLinux.h: |
+ Removed m_xPositions and Added m_positions and m_startingY. |
+ (WebCore::ComplexTextController::positions): Added. |
+ * platform/graphics/chromium/FontLinux.cpp: |
+ Followed the change in ComplexTextController. |
+ (WebCore::Font::drawComplexText): Ditto. |
+ (WebCore::Font::floatWidthForComplexText): Ditto. |
+ (WebCore::glyphIndexForXPositionInScriptRun): Ditto. |
+ (WebCore::Font::offsetForPositionForComplexText): Ditto. |
+ (WebCore::Font::selectionRectForComplexText): Ditto. |
+ |
+2011-04-26 Levi Weintraub <leviw@chromium.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Root element should establish a new block formatting context |
+ https://bugs.webkit.org/show_bug.cgi?id=54573 |
+ |
+ Always expanding the root renderer to include overhanging floats. |
+ |
+ Test: fast/block/float/float-overhangs-root.html |
+ |
+ * rendering/RenderBlock.cpp: |
+ (WebCore::RenderBlock::expandsToEncloseOverhangingFloats): |
+ |
+2011-04-26 Dawit Alemayehu <adawit@kde.org> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [Qt] Improper rendering of <button> tag when it contains a <br> |
+ https://bugs.webkit.org/show_bug.cgi?id=50521 |
+ |
+ Test: platform/qt/fast/forms/button-line-break.html |
+ |
+ * platform/qt/RenderThemeQt.cpp: |
+ (WebCore::RenderThemeQt::computeSizeBasedOnStyle): |
+ (WebCore::RenderThemeQt::setButtonPadding): |
+ |
+2011-04-26 James Robinson <jamesr@chromium.org> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ [chromium] Only reset tiles if the LayerRendererChromium is actually changing |
+ https://bugs.webkit.org/show_bug.cgi?id=59572 |
+ |
+ http://trac.webkit.org/changeset/84981/ caused us to reset the tiles |
+ when LayerRendererChromium was set. We set this pointer every frame |
+ and should only reset the tiles if the new LayerRendererChromium is |
+ different from the old one (indicating a context loss), not just reset |
+ on every frame. |
+ |
+ * platform/graphics/chromium/LayerTilerChromium.cpp: |
+ (WebCore::LayerTilerChromium::setLayerRenderer): |
+ * platform/graphics/chromium/LayerTilerChromium.h: |
+ |
+2011-04-26 Dinesh K Garg <dineshg@codeaurora.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ beginElement broken by setAttribute |
+ https://bugs.webkit.org/show_bug.cgi?id=26019 |
+ |
+ Test: svg/animations/animate-beginElementAt.svg |
+ |
+ * svg/SVGAnimationElement.cpp: |
+ (WebCore::SVGAnimationElement::attributeChanged): |
+ Reset the animation state here as the rest of the code reads it and would still |
+ think we are animating when we are not. |
+ |
+ * svg/animation/SVGSMILElement.h: |
+ (WebCore::SVGSMILElement::setInactive): Helper function to reset the state. |
+ |
+2011-04-26 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r84989. |
+ http://trac.webkit.org/changeset/84989 |
+ https://bugs.webkit.org/show_bug.cgi?id=59566 |
+ |
+ REGRESSION (r84989): Lots of vertical text tests failing on |
+ windows (Requested by weinig on #webkit). |
+ |
+ * platform/graphics/FontPlatformData.h: |
+ * platform/graphics/win/FontCacheWin.cpp: |
+ (WebCore::FontCache::getFontDataForCharacters): |
+ (WebCore::FontCache::createFontPlatformData): |
+ * platform/graphics/win/FontCustomPlatformData.cpp: |
+ (WebCore::FontCustomPlatformData::fontPlatformData): |
+ * platform/graphics/win/FontPlatformDataCGWin.cpp: |
+ (WebCore::FontPlatformData::FontPlatformData): |
+ * platform/graphics/win/FontPlatformDataWin.cpp: |
+ (WebCore::FontPlatformData::FontPlatformData): |
+ |
+2011-04-26 Sam Weinig <sam@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Try again: |
+ Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects |
+ https://bugs.webkit.org/show_bug.cgi?id=59310 |
+ |
+ * bindings/js/JSDOMBinding.h: |
+ (WebCore::DOMConstructorObject::DOMConstructorObject): |
+ * bindings/js/JSDOMWrapper.h: |
+ (WebCore::JSDOMWrapper::globalObject): |
+ (WebCore::JSDOMWrapper::scriptExecutionContext): |
+ (WebCore::JSDOMWrapper::createStructure): |
+ (WebCore::JSDOMWrapper::JSDOMWrapper): |
+ * bindings/scripts/CodeGeneratorJS.pm: |
+ |
+2011-04-26 Sam Weinig <sam@webkit.org> |
+ |
+ Reviewed by David Hyatt. |
+ |
+ Remove Datagrid from the tree |
+ https://bugs.webkit.org/show_bug.cgi?id=59543 |
+ |
+ * Android.derived.jscbindings.mk: |
+ * Android.derived.v8bindings.mk: |
+ * Android.jscbindings.mk: |
+ * Android.v8bindings.mk: |
+ * CMakeLists.txt: |
+ * CodeGenerators.pri: |
+ * Configurations/FeatureDefines.xcconfig: |
+ * DerivedSources.cpp: |
+ * DerivedSources.make: |
+ * GNUmakefile.am: |
+ * GNUmakefile.list.am: |
+ * UseJSC.cmake: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/js/JSBindingsAllInOne.cpp: |
+ * bindings/js/JSDataGridColumnListCustom.cpp: Removed. |
+ * bindings/js/JSDataGridDataSource.cpp: Removed. |
+ * bindings/js/JSDataGridDataSource.h: Removed. |
+ * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed. |
+ * bindings/v8/V8DataGridDataSource.cpp: Removed. |
+ * bindings/v8/V8DataGridDataSource.h: Removed. |
+ * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed. |
+ * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed. |
+ * css/CSSStyleSelector.cpp: |
+ * css/CSSStyleSelector.h: |
+ * css/html.css: |
+ (input, textarea, keygen, select, button, isindex): |
+ (select:disabled, keygen:disabled, optgroup:disabled, option:disabled): |
+ * editing/htmlediting.cpp: |
+ (WebCore::canHaveChildrenForEditing): |
+ * features.pri: |
+ * html/DOMDataGridDataSource.cpp: Removed. |
+ * html/DOMDataGridDataSource.h: Removed. |
+ * html/DataGridColumn.cpp: Removed. |
+ * html/DataGridColumn.h: Removed. |
+ * html/DataGridColumn.idl: Removed. |
+ * html/DataGridColumnList.cpp: Removed. |
+ * html/DataGridColumnList.h: Removed. |
+ * html/DataGridColumnList.idl: Removed. |
+ * html/DataGridDataSource.h: Removed. |
+ * html/HTMLDataGridCellElement.cpp: Removed. |
+ * html/HTMLDataGridCellElement.h: Removed. |
+ * html/HTMLDataGridCellElement.idl: Removed. |
+ * html/HTMLDataGridColElement.cpp: Removed. |
+ * html/HTMLDataGridColElement.h: Removed. |
+ * html/HTMLDataGridColElement.idl: Removed. |
+ * html/HTMLDataGridElement.cpp: Removed. |
+ * html/HTMLDataGridElement.h: Removed. |
+ * html/HTMLDataGridElement.idl: Removed. |
+ * html/HTMLDataGridRowElement.cpp: Removed. |
+ * html/HTMLDataGridRowElement.h: Removed. |
+ * html/HTMLDataGridRowElement.idl: Removed. |
+ * html/HTMLElement.cpp: |
+ (WebCore::HTMLElement::ieForbidsInsertHTML): |
+ * html/HTMLElementsAllInOne.cpp: |
+ * html/HTMLTagNames.in: |
+ * page/DOMWindow.idl: |
+ * rendering/RenderBox.cpp: |
+ (WebCore::RenderBox::sizesToIntrinsicLogicalWidth): |
+ * rendering/RenderDataGrid.cpp: Removed. |
+ * rendering/RenderDataGrid.h: Removed. |
+ * rendering/RenderingAllInOne.cpp: |
+ |
+2011-04-26 Chun-Lung Huang <alvincl.huang@gmail.com> |
+ |
+ Reviewed by Adele Peterson. |
+ |
+ On WebKit (Windows), glyphs in vertical text tests are rotated 90 |
+ degrees clockwise. https://bugs.webkit.org/show_bug.cgi?id=48459 |
+ |
+ This platform dependent patch makes WebKit (Windows) show the |
+ vertical writing text correctly. Job was done by adding a prefix '@' |
+ in front of the font family name (Windows Only). No new tests added. |
+ Some layout tests images: |
+ http://www.flickr.com/photos/burorly/sets/72157625585506341/ |
+ |
+ * platform/graphics/FontPlatformData.h: |
+ * platform/graphics/win/FontCacheWin.cpp: |
+ (WebCore::FontCache::getFontDataForCharacters): |
+ (WebCore::FontCache::createFontPlatformData): |
+ * platform/graphics/win/FontCustomPlatformData.cpp: |
+ (WebCore::FontCustomPlatformData::fontPlatformData): |
+ * platform/graphics/win/FontPlatformDataCGWin.cpp: |
+ (WebCore::FontPlatformData::FontPlatformData): |
+ * platform/graphics/win/FontPlatformDataWin.cpp: |
+ (WebCore::FontPlatformData::FontPlatformData): |
+ |
+2011-04-26 Jer Noble <jer.noble@apple.com> |
+ |
+ Reviewed by Brady Eidson. |
+ |
+ HTML5 video fullscreen transition causes an audio stutter |
+ https://bugs.webkit.org/show_bug.cgi?id=59544 |
+ |
+ AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer |
+ from its AVPlayer. Since you shouldn't necessarily have to destroy the |
+ layer to render it invisible, instead just set the layer as hidden. |
+ |
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: |
+ (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible(). |
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: |
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: |
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: |
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added. |
+ |
+2011-04-26 Christian Dywan <christian@lanedo.com> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Extra separator after Select All in context menu |
+ https://bugs.webkit.org/show_bug.cgi?id=54092 |
+ |
+ * page/ContextMenuController.cpp: Move separator to non-GTK+ |
+ port guards since it is for the spelling options menu |
+ which the GTK+ port doesn't use. |
+ |
+2011-04-26 James Robinson <jamesr@chromium.org> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ [chromium] Clear out LayerTilerChromium's tiles on lost context |
+ https://bugs.webkit.org/show_bug.cgi?id=59233 |
+ |
+ Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset. In this case the tiles are |
+ no longer valid since they exist in the previous LayerRendererChromium. |
+ |
+ Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests. |
+ |
+ * platform/graphics/chromium/LayerTilerChromium.h: |
+ (WebCore::LayerTilerChromium::setLayerRenderer): |
+ |
+2011-04-26 Martin Robinson <mrobinson@igalia.com> |
+ |
+ Reviewed by Dirk Schulze. |
+ |
+ [GTK] Flash in divs with overflow: auto is not positioned and clipped properly |
+ https://bugs.webkit.org/show_bug.cgi?id=57644 |
+ |
+ Manual test: plugins/windowed-in-iframe-2.html |
+ |
+ * manual-tests/plugins/windowed-in-iframe-2.html: Added. |
+ * platform/gtk/WidgetGtk.cpp: |
+ (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged. |
+ * plugins/PluginView.h: Added helper method to set the allocation and clip. |
+ * plugins/gtk/PluginViewGtk.cpp: |
+ (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting |
+ the allocation immediately. Bring this method into sync with the implementation in |
+ the Qt port. |
+ (WebCore::PluginView::updateWidgetAllocationAndClip): Added. |
+ (WebCore::PluginView::plugAddedCallback): Call the new helper method. |
+ |
+2011-04-26 Martin Robinson <mrobinson@igalia.com> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ [GTK] fast/block/float/overhanging-tall-block.html crashes in the bots |
+ https://bugs.webkit.org/show_bug.cgi?id=58818 |
+ |
+ Prevent allocating scratch buffers larger than the target GdkDrawable |
+ when creating a WidgetRenderingContext. This prevents incredibly large |
+ widgets from crashing the X Server. This change also allowed greatly |
+ simplifying the way that the painting offset is calculated. |
+ |
+ * platform/gtk/WidgetRenderingContext.cpp: |
+ (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap |
+ larger than the target GdkDrawable. |
+ (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the |
+ blit by looking at the location of the target rect itself, rather than delaying the |
+ calculation up to this point. |
+ (WebCore::WidgetRenderingContext::calculateClipRect): Added. |
+ (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper. |
+ (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto. |
+ (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto. |
+ (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto. |
+ (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto. |
+ (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto. |
+ (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto. |
+ (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto. |
+ (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto. |
+ * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add |
+ a member to store the IntSize mapping from the coordinates of the target to the coordinates |
+ of the scratch buffer. |
+ |
+2011-04-26 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Respect charset in handleDataURL |
+ https://bugs.webkit.org/show_bug.cgi?id=47746 |
+ |
+ Original patch by Kwang Yul Seo <skyul@company100.net> |
+ |
+ We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode() |
+ returns an empty string because encoding name is not specified. |
+ |
+ Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty. |
+ |
+ This change fixes over 130 layout tests when running GTK port with cURL network backend. |
+ |
+ * platform/network/DataURL.cpp: |
+ (WebCore::handleDataURL): |
+ |
+2011-04-26 Anders Carlsson <andersca@apple.com> |
+ |
+ Fix clang++ build. |
+ |
+ You can never have too many casts! |
+ |
+ * accessibility/mac/AccessibilityObjectWrapper.mm: |
+ (-[AccessibilityObjectWrapper position]): |
+ * editing/mac/SelectionControllerMac.mm: |
+ (WebCore::accessibilityConvertScreenRect): |
+ |
+2011-04-26 Chris Rogers <crogers@google.com> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ Fix web audio build on mac port |
+ https://bugs.webkit.org/show_bug.cgi?id=59355 |
+ |
+ No new tests since audio API is not yet implemented. |
+ |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/js/JSAudioContextCustom.cpp: |
+ (WebCore::JSAudioContext::visitChildren): |
+ * bindings/js/JSJavaScriptAudioNodeCustom.cpp: |
+ (WebCore::JSJavaScriptAudioNode::visitChildren): |
+ * webaudio/AudioContext.idl: |
+ |
+2011-04-26 Chris Rogers <crogers@google.com> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ Add FFTFrame implementation for FFmpeg |
+ https://bugs.webkit.org/show_bug.cgi?id=59408 |
+ |
+ No new tests since audio API is not yet implemented. |
+ |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.gypi: |
+ * platform/audio/FFTFrame.h: |
+ * platform/audio/FFTFrameStub.cpp: |
+ * platform/audio/ffmpeg: Added. |
+ * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added. |
+ (WebCore::FFTFrame::FFTFrame): |
+ (WebCore::FFTFrame::initialize): |
+ (WebCore::FFTFrame::cleanup): |
+ (WebCore::FFTFrame::~FFTFrame): |
+ (WebCore::FFTFrame::multiply): |
+ (WebCore::FFTFrame::doFFT): |
+ (WebCore::FFTFrame::doInverseFFT): |
+ (WebCore::FFTFrame::realData): |
+ (WebCore::FFTFrame::imagData): |
+ (WebCore::FFTFrame::getUpToDateComplexData): |
+ (WebCore::FFTFrame::contextForSize): |
+ * platform/audio/mac/FFTFrameMac.cpp: |
+ * webaudio/ConvolverNode.cpp: |
+ |
+2011-04-26 Jeff Miller <jeffm@apple.com> |
+ |
+ Add a newline at the end of SVGFEDropShadowElement.idl. |
+ |
+ * svg/SVGFEDropShadowElement.idl: |
+ |
+2011-04-26 Mihai Parparita <mihaip@chromium.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ InlineBox.h shouldn't include RenderBR.h |
+ https://bugs.webkit.org/show_bug.cgi?id=59480 |
+ |
+ Per bug 59348 RenderBR.h is a "top header" by include * size, because |
+ InlineBox.h includes it. There's no reason why it has to. |
+ |
+ * rendering/InlineBox.h: |
+ * rendering/InlineTextBox.cpp: |
+ * rendering/RenderBlock.h: |
+ |
+2011-04-26 Sam Weinig <sam@webkit.org> |
+ |
+ Nope, roll out r84950 and r84952. Working on a laptop is clearly not something |
+ I should do. |
+ |
+ * bindings/js/JSDOMBinding.h: |
+ (WebCore::JSDOMWrapperWithGlobalPointer::globalObject): |
+ (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext): |
+ (WebCore::JSDOMWrapperWithGlobalPointer::createStructure): |
+ (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer): |
+ (WebCore::DOMConstructorObject::DOMConstructorObject): |
+ * bindings/js/JSDOMWrapper.h: |
+ (WebCore::JSDOMWrapper::JSDOMWrapper): |
+ * bindings/scripts/CodeGeneratorJS.pm: |
+ |
+2011-04-26 Sam Weinig <sam@webkit.org> |
+ |
+ Fix build. |
+ |
+ * bindings/js/JSDOMWrapper.h: |
+ (WebCore::JSDOMWrapper::globalObject): |
+ |
+2011-04-26 Sam Weinig <sam@webkit.org> |
+ |
+ Roll r84945 back in with infinite recursion removed. |
+ |
+ * bindings/js/JSDOMBinding.h: |
+ (WebCore::DOMConstructorObject::DOMConstructorObject): |
+ * bindings/js/JSDOMWrapper.h: |
+ (WebCore::JSDOMWrapper::globalObject): |
+ (WebCore::JSDOMWrapper::scriptExecutionContext): |
+ (WebCore::JSDOMWrapper::createStructure): |
+ (WebCore::JSDOMWrapper::JSDOMWrapper): |
+ * bindings/scripts/CodeGeneratorJS.pm: |
+ |
+2011-04-26 Sam Weinig <sam@webkit.org> |
+ |
+ Rollout previous patch. It broke stuff. |
+ |
+ * bindings/js/JSDOMBinding.h: |
+ (WebCore::JSDOMWrapperWithGlobalPointer::globalObject): |
+ (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext): |
+ (WebCore::JSDOMWrapperWithGlobalPointer::createStructure): |
+ (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer): |
+ (WebCore::DOMConstructorObject::DOMConstructorObject): |
+ * bindings/js/JSDOMWrapper.h: |
+ (WebCore::JSDOMWrapper::JSDOMWrapper): |
+ * bindings/scripts/CodeGeneratorJS.pm: |
+ |
+2011-04-26 Sam Weinig <sam@webkit.org> |
+ |
+ Reviewed by Maciej Stachowiak. |
+ |
+ Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects |
+ https://bugs.webkit.org/show_bug.cgi?id=59310 |
+ |
+ * bindings/js/JSDOMBinding.h: |
+ (WebCore::DOMConstructorObject::DOMConstructorObject): |
+ * bindings/js/JSDOMWrapper.h: |
+ (WebCore::JSDOMWrapper::globalObject): |
+ (WebCore::JSDOMWrapper::scriptExecutionContext): |
+ (WebCore::JSDOMWrapper::createStructure): |
+ (WebCore::JSDOMWrapper::JSDOMWrapper): |
+ Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper. |
+ |
+ * bindings/scripts/CodeGeneratorJS.pm: |
+ Make JSDOMWrapper the base class. |
+ |
+2011-04-26 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Mark Rowe. |
+ |
+ Choose the compiler based on the Xcode version for Snow Leopard debug builds. |
+ |
+ * Configurations/Base.xcconfig: |
+ * Configurations/CompilerVersion.xcconfig: Added. |
+ |
+2011-04-26 Adrienne Walker <enne@google.com> |
+ |
+ Reviewed by Geoffrey Garen. |
+ |
+ Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer |
+ https://bugs.webkit.org/show_bug.cgi?id=59469 |
+ |
+ * platform/chromium/TraceEvent.h: |
+ (WebCore::internal::ScopeTracer::ScopeTracer): |
+ |
+2011-04-25 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Reviewed by Oliver Hunt. |
+ |
+ Nixed special finalizer handling for WebCore strings |
+ https://bugs.webkit.org/show_bug.cgi?id=59425 |
+ |
+ Not needed anymore, since weak handles have finalizers. |
+ |
+ * WebCore.exp.in: Exports! |
+ |
+ * bindings/js/DOMWrapperWorld.cpp: |
+ (WebCore::JSStringOwner::finalize): |
+ (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer, |
+ so we don't need special treatment anymore. |
+ |
+ * bindings/js/DOMWrapperWorld.h: |
+ (WebCore::JSStringOwner::JSStringOwner): |
+ (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T> |
+ instead of a WeakGCMap, so we can specify a custom finalizer. |
+ |
+ * bindings/js/JSDOMBinding.cpp: |
+ (WebCore::jsStringSlowCase): |
+ * bindings/js/JSDOMBinding.h: |
+ (WebCore::jsString): Updated for string map change. |
+ |
+2011-04-26 David Kilzer <ddkilzer@apple.com> |
+ |
+ <http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining |
+ |
+ Reviewed by Antti Koivisto. |
+ |
+ To enable HTTP pipelining post-SnowLeopard, use this command: |
+ |
+ defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES |
+ |
+ * platform/network/cf/ResourceRequestCFNet.cpp: |
+ (WebCore::readBooleanPreference): Re-added. Originally added in |
+ r76756 and removed in r84120. |
+ (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable |
+ HTTP pipelining if use default is set to true. Added macro |
+ guards to match those in ResourceRequestMac.mm. |
+ |
+2011-04-26 Antti Koivisto <antti@apple.com> |
+ |
+ Reviewed by Adele Peterson. |
+ |
+ Don't strip fragments from file: urls in memory cache |
+ https://bugs.webkit.org/show_bug.cgi?id=59463 |
+ <rdar://problem/9231130> |
+ |
+ Some clients expect file: resources to be unique based on fragment identifier. |
+ Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only |
+ |
+ Test: fast/loader/file-protocol-fragment.html |
+ |
+ * loader/cache/MemoryCache.cpp: |
+ (WebCore::MemoryCache::removeFragmentIdentifierIfNeeded): |
+ |
+2011-04-26 David Levin <levin@chromium.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Fix more strict OwnPtr in WebCore (round N). |
+ https://bugs.webkit.org/show_bug.cgi?id=59464 |
+ |
+ * dom/Document.cpp: |
+ (WebCore::Document::Document): |
+ (WebCore::Document::attach): |
+ * fileapi/FileReader.cpp: |
+ (WebCore::FileReader::terminate): |
+ * loader/DocumentThreadableLoader.cpp: |
+ (WebCore::DocumentThreadableLoader::preflightFailure): |
+ * workers/DefaultSharedWorkerRepository.cpp: |
+ (WebCore::SharedWorkerConnectTask::create): |
+ (WebCore::SharedWorkerScriptLoader::load): |
+ |
+2011-04-26 Ruben <chromium@hybridsource.org> |
+ |
+ Reviewed by Tony Chang. |
+ |
+ Change linux ifdefs for Chromium to Unix instead, allowing |
+ new Unix ports to be enabled by default |
+ https://bugs.webkit.org/show_bug.cgi?id=59297 |
+ |
+ No new tests, just changing preprocessor defines. |
+ |
+ * bindings/js/JSInspectorFrontendHostCustom.cpp: |
+ * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: |
+ * dom/SelectElement.cpp: |
+ * loader/cache/CachedFont.cpp: |
+ * page/EventHandler.cpp: |
+ * page/chromium/EventHandlerChromium.cpp: |
+ * platform/Scrollbar.cpp: |
+ * platform/chromium/PlatformBridge.h: |
+ * platform/graphics/chromium/FontPlatformData.h: |
+ * platform/graphics/skia/FontCustomPlatformData.cpp: |
+ * platform/graphics/skia/FontCustomPlatformData.h: |
+ |
+2011-04-26 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ [RTL] Arabic/AB - after typing a date, cursors doesn't go back |
+ https://bugs.webkit.org/show_bug.cgi?id=49111 |
+ |
+ Even when the offset corresponds to a position visually left of the box |
+ and there aren't any inline boxes on the left, the previous/next position |
+ may still correspond to some position in the same line. |
+ |
+ The bug was caused by our ignoring such cases. Fixed the bug by comparing |
+ previous/next position's inline box to the current box. If they match, |
+ then we stay on the same position because moving to the left visually at |
+ the left edge should not result in a position on the same line. |
+ |
+ Also fixed a bug that WebKit uses offsets that are not extrema when moved to |
+ the left edge or to the right edge, and a bug that WebKit could not move to |
+ the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C). |
+ |
+ Test cases are added to editing/selection/move-left-right.html |
+ |
+ * editing/VisiblePosition.cpp: |
+ (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): |
+ (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): |
+ |
+2011-04-26 Gabor Loki <loki@webkit.org> |
+ |
+ Reviewed by Csaba Osztrogonác. |
+ |
+ Speeding up SVG filters with multicore (SMP) support |
+ https://bugs.webkit.org/show_bug.cgi?id=43903 |
+ |
+ Some SVG filters execute a huge number of pixel manipulations, which |
+ cannot be sped up by graphics accelerators, since their algorithm is |
+ too complex. Using the power of Symmetric Multi Processing (SMP) we |
+ can split up a task to smaller (data independent) tasks, which can be |
+ executed independently. |
+ |
+ The ParallelJobs framework provides a simple way for distributed |
+ programming. The framework is based on WebKit's threading infrastructure, |
+ Open Multi-Processing's (OpenMP) API, and libdispatch API. |
+ |
+ * ForwardingHeaders/wtf/ParallelJobs.h: Added. |
+ * platform/graphics/filters/FETurbulence.cpp: |
+ (WebCore::FETurbulence::PaintingData::PaintingData): |
+ (WebCore::FETurbulence::noise2D): |
+ (WebCore::FETurbulence::calculateTurbulenceValueForPoint): |
+ (WebCore::FETurbulence::fillRegion): |
+ (WebCore::FETurbulence::fillRegionWorker): |
+ (WebCore::FETurbulence::apply): |
+ * platform/graphics/filters/FETurbulence.h: |
+ |
+2011-04-26 Pavel Feldman <pfeldman@google.com> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: close button is off in docked mode on a mac. |
+ https://bugs.webkit.org/show_bug.cgi?id=59453 |
+ |
+ * inspector/front-end/inspector.css: |
+ (.toolbar-item.close-left): |
+ |
+2011-04-26 Pavel Feldman <pfeldman@google.com> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: New Style is not working (UI glitch) |
+ https://bugs.webkit.org/show_bug.cgi?id=59451 |
+ |
+ * inspector/InspectorDOMStorageAgent.cpp: |
+ (WebCore::InspectorDOMStorageAgent::setFrontend): |
+ * inspector/front-end/AuditRules.js: |
+ (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles): |
+ (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived): |
+ (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived): |
+ (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived): |
+ (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived): |
+ * inspector/front-end/CSSStyleModel.js: |
+ (WebInspector.CSSStyleModel.prototype.setRuleSelector): |
+ (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback): |
+ (WebInspector.CSSStyleModel.prototype.addRule): |
+ (WebInspector.CSSStyleModel.prototype.addRule.callback): |
+ (WebInspector.CSSStyleModel.prototype._documentElementId): |
+ * inspector/front-end/DOMAgent.js: |
+ (WebInspector.DOMNode.prototype._addAttribute): |
+ (WebInspector.DOMNode.prototype.documentElement): |
+ * inspector/front-end/ResourceTreeModel.js: |
+ (WebInspector.PageDispatcher.prototype.frameDetached): |
+ * inspector/front-end/StylesSidebarPane.js: |
+ (WebInspector.StylesSidebarPane.prototype._createNewRule): |
+ |
+2011-04-26 Pavel Feldman <pfeldman@google.com> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: introduce DOMStorage::enable and disable. |
+ https://bugs.webkit.org/show_bug.cgi?id=59445 |
+ |
+ * inspector/Inspector.json: |
+ * inspector/InspectorAgent.cpp: |
+ (WebCore::InspectorAgent::InspectorAgent): |
+ (WebCore::InspectorAgent::restoreInspectorStateFromCookie): |
+ * inspector/InspectorDOMStorageAgent.cpp: |
+ (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): |
+ (WebCore::InspectorDOMStorageAgent::restore): |
+ (WebCore::InspectorDOMStorageAgent::enable): |
+ (WebCore::InspectorDOMStorageAgent::disable): |
+ * inspector/InspectorDOMStorageAgent.h: |
+ (WebCore::InspectorDOMStorageAgent::create): |
+ * inspector/front-end/DOMStorage.js: |
+ (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage): |
+ * inspector/front-end/ResourcesPanel.js: |
+ (WebInspector.ResourcesPanel.prototype._reset): |
+ * inspector/front-end/inspector.js: |
+ |
+2011-04-26 Pavel Feldman <pfeldman@google.com> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: extract Page agent dispatcher into the ResourceTreeModel. |
+ https://bugs.webkit.org/show_bug.cgi?id=59440 |
+ |
+ * inspector/Inspector.json: |
+ * inspector/InspectorAgent.cpp: |
+ (WebCore::InspectorAgent::restoreInspectorStateFromCookie): |
+ * inspector/InspectorPageAgent.cpp: |
+ (WebCore::InspectorPageAgent::setFrontend): |
+ (WebCore::InspectorPageAgent::frameNavigated): |
+ * inspector/InspectorPageAgent.h: |
+ * inspector/front-end/AuditsPanel.js: |
+ (WebInspector.AuditsPanel): |
+ (WebInspector.AuditsPanel.prototype._onLoadEventFired): |
+ (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired): |
+ * inspector/front-end/CSSStyleModel.js: |
+ (WebInspector.CSSStyleModelResourceBinding): |
+ (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged): |
+ * inspector/front-end/DOMBreakpointsSidebarPane.js: |
+ (WebInspector.DOMBreakpointsSidebarPane): |
+ (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged): |
+ * inspector/front-end/DOMStorage.js: |
+ (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage): |
+ * inspector/front-end/ExtensionServer.js: |
+ (WebInspector.ExtensionServer.prototype._inspectedURLChanged): |
+ (WebInspector.ExtensionServer.prototype.initExtensions): |
+ * inspector/front-end/NetworkPanel.js: |
+ (WebInspector.NetworkPanel): |
+ (WebInspector.NetworkPanel.prototype._onLoadEventFired): |
+ (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired): |
+ (WebInspector.NetworkPanel.prototype._frameNavigated): |
+ * inspector/front-end/ResourceTreeModel.js: |
+ (WebInspector.ResourceTreeModel): |
+ (WebInspector.ResourceTreeModel.prototype._processCachedResources): |
+ (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged): |
+ (WebInspector.ResourceTreeModel.prototype._frameNavigated): |
+ (WebInspector.ResourceTreeModel.prototype._frameDetached): |
+ (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): |
+ (WebInspector.PageDispatcher): |
+ (WebInspector.PageDispatcher.prototype.domContentEventFired): |
+ (WebInspector.PageDispatcher.prototype.loadEventFired): |
+ (WebInspector.PageDispatcher.prototype.frameNavigated): |
+ (WebInspector.PageDispatcher.prototype.frameDetached): |
+ * inspector/front-end/ResourcesPanel.js: |
+ (WebInspector.ResourcesPanel): |
+ (WebInspector.ResourcesPanel.prototype._onLoadEventFired): |
+ (WebInspector.ResourcesPanel.prototype._frameNavigated): |
+ * inspector/front-end/inspector.js: |
+ |
+2011-04-26 Csaba Osztrogonác <ossy@webkit.org> |
+ |
+ Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892, |
+ because it broke transitions/multiple-text-shadow-transition.html |
+ |
+ Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr |
+ https://bugs.webkit.org/show_bug.cgi?id=59377 |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::applyProperty): |
+ * page/animation/AnimationBase.cpp: |
+ (WebCore::PropertyWrapperShadow::PropertyWrapperShadow): |
+ (WebCore::PropertyWrapperShadow::blend): |
+ * rendering/style/RenderStyle.cpp: |
+ (WebCore::RenderStyle::setTextShadow): |
+ (WebCore::RenderStyle::setBoxShadow): |
+ * rendering/style/RenderStyle.h: |
+ (WebCore::InheritedFlags::textShadow): |
+ * rendering/style/StyleRareInheritedData.cpp: |
+ (WebCore::StyleRareInheritedData::StyleRareInheritedData): |
+ (WebCore::StyleRareInheritedData::~StyleRareInheritedData): |
+ * rendering/style/StyleRareInheritedData.h: |
+ * rendering/style/StyleRareNonInheritedData.cpp: |
+ (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): |
+ |
+2011-04-26 Mihai Parparita <mihaip@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Turn off make built-in implicit rules for derived sources makefile |
+ https://bugs.webkit.org/show_bug.cgi?id=59418 |
+ |
+ We don't use any of make's built-in implicit rules, turning them off |
+ speeds up parsing of the makefile. |
+ |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * gyp/generate-derived-sources.sh: |
+ |
+2011-04-26 Leo Yang <leo.yang@torchmobile.com.cn> |
+ |
+ Reviewed by Nikolas Zimmermann. |
+ |
+ ASSERT failure in SVGUseElement |
+ https://bugs.webkit.org/show_bug.cgi?id=59313 |
+ |
+ In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource) |
+ was wrong because the document may not be well-formed. |
+ |
+ This patch asserts the element is not pending on resource or the |
+ document is not well-formed. |
+ |
+ Test: svg/custom/use-crash-in-non-wellformed-document.svg |
+ |
+ * svg/SVGUseElement.cpp: |
+ (WebCore::isWellFormedDocument): |
+ (WebCore::SVGUseElement::insertedIntoDocument): |
+ |
+2011-04-26 Mikhail Naganov <mnaganov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids. |
+ https://bugs.webkit.org/show_bug.cgi?id=59438 |
+ |
+ * inspector/front-end/DetailedHeapshotView.js: |
+ (WebInspector.DetailedHeapshotView.prototype._changeView): |
+ |
+2011-04-26 David Levin <levin@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Fix a few OwnPtr strict errors in WebCore headers. |
+ https://bugs.webkit.org/show_bug.cgi?id=59431 |
+ |
+ * bindings/js/ScheduledAction.cpp: |
+ (WebCore::ScheduledAction::create): |
+ * css/MediaQueryMatcher.cpp: |
+ (WebCore::MediaQueryMatcher::prepareEvaluator): |
+ * dom/NodeRareData.h: |
+ (WebCore::NodeListsNodeData::create): |
+ * dom/ScriptRunner.h: |
+ (WebCore::ScriptRunner::create): |
+ * inspector/WorkerInspectorController.cpp: |
+ (WebCore::WorkerInspectorController::connectFrontend): |
+ * loader/icon/IconDatabase.h: |
+ (WebCore::IconDatabase::create): |
+ * platform/graphics/SimpleFontData.cpp: |
+ (WebCore::SimpleFontData::verticalRightOrientationFontData): |
+ (WebCore::SimpleFontData::uprightOrientationFontData): |
+ (WebCore::SimpleFontData::brokenIdeographFontData): |
+ * rendering/style/StyleRareInheritedData.cpp: |
+ (WebCore::StyleRareInheritedData::StyleRareInheritedData): |
+ * rendering/svg/SVGResources.h: |
+ (WebCore::SVGResources::ClipperFilterMaskerData::create): |
+ (WebCore::SVGResources::MarkerData::create): |
+ (WebCore::SVGResources::FillStrokeData::create): |
+ * storage/StorageSyncManager.cpp: |
+ (WebCore::StorageSyncManager::close): |
+ * workers/WorkerContext.cpp: |
+ (WebCore::CloseWorkerContextTask::create): |
+ * workers/WorkerMessagingProxy.cpp: |
+ (WebCore::MessageWorkerContextTask::create): |
+ (WebCore::MessageWorkerTask::create): |
+ (WebCore::WorkerExceptionTask::create): |
+ (WebCore::WorkerContextDestroyedTask::create): |
+ (WebCore::WorkerTerminateTask::create): |
+ (WebCore::WorkerThreadActivityReportTask::create): |
+ * workers/WorkerRunLoop.cpp: |
+ (WebCore::WorkerRunLoop::Task::create): |
+ * workers/WorkerThread.cpp: |
+ (WebCore::WorkerThreadStartupData::create): |
+ (WebCore::WorkerThreadShutdownFinishTask::create): |
+ (WebCore::WorkerThreadShutdownStartTask::create): |
+ |
+2011-04-26 Adam Klein <adamk@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Fix last strict OwnPtr violation under svg/... |
+ https://bugs.webkit.org/show_bug.cgi?id=59429 |
+ |
+ * svg/SVGDocumentExtensions.cpp: |
+ (WebCore::SVGDocumentExtensions::removePendingResource): |
+ |
+2011-04-26 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ Fix more strict OwnPtr violations in WebCore |
+ https://bugs.webkit.org/show_bug.cgi?id=59433 |
+ |
+ These manifest in the Chromium build. |
+ |
+ * bindings/v8/ScriptController.cpp: |
+ (WebCore::ScriptController::ScriptController): |
+ * bindings/v8/ScriptDebugServer.cpp: |
+ (WebCore::ScriptDebugServer::editScriptSource): |
+ * bindings/v8/V8DOMMap.cpp: |
+ (WebCore::DOMDataStoreHandle::DOMDataStoreHandle): |
+ * bindings/v8/V8Proxy.cpp: |
+ (WebCore::V8Proxy::precompileScript): |
+ * bindings/v8/WorkerScriptController.cpp: |
+ (WebCore::WorkerScriptController::WorkerScriptController): |
+ * page/Page.cpp: |
+ (WebCore::Page::Page): |
+ (WebCore::Page::speechInput): |
+ * platform/PlatformGestureRecognizer.cpp: |
+ (WebCore::PlatformGestureRecognizer::create): |
+ * platform/PlatformGestureRecognizer.h: |
+ * platform/graphics/chromium/DrawingBufferChromium.cpp: |
+ (WebCore::DrawingBuffer::DrawingBuffer): |
+ * platform/graphics/chromium/cc/CCLayerImpl.cpp: |
+ (WebCore::CCLayerImpl::CCLayerImpl): |
+ * platform/graphics/gpu/Texture.cpp: |
+ (WebCore::Texture::create): |
+ * platform/image-decoders/bmp/BMPImageDecoder.cpp: |
+ (WebCore::BMPImageDecoder::decodeHelper): |
+ * platform/image-decoders/gif/GIFImageDecoder.cpp: |
+ (WebCore::GIFImageDecoder::decode): |
+ * platform/image-decoders/ico/ICOImageDecoder.cpp: |
+ (WebCore::ICOImageDecoder::decodeAtIndex): |
+ * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: |
+ (WebCore::JPEGImageDecoder::decode): |
+ * platform/image-decoders/png/PNGImageDecoder.cpp: |
+ (WebCore::PNGImageDecoder::decode): |
+ * storage/chromium/DatabaseTrackerChromium.cpp: |
+ (WebCore::DatabaseTracker::addOpenDatabase): |
+ |
+2011-04-25 David Levin <levin@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Fix OwnPtr strict errors in CrossThreadTask.h |
+ https://bugs.webkit.org/show_bug.cgi?id=59427 |
+ |
+ * dom/CrossThreadTask.h: |
+ (WebCore::CrossThreadTask1::create): |
+ (WebCore::CrossThreadTask2::create): |
+ (WebCore::CrossThreadTask3::create): |
+ (WebCore::CrossThreadTask4::create): |
+ (WebCore::CrossThreadTask5::create): |
+ (WebCore::CrossThreadTask6::create): |
+ (WebCore::CrossThreadTask7::create): |
+ (WebCore::CrossThreadTask8::create): |
+ |
+2011-04-25 Mark Rowe <mrowe@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ <rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>' |
+ |
+ * css/CSSStyleApplyProperty.cpp: |
+ (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice. |
+ * css/CSSStyleApplyProperty.h: |
+ (WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak. |
+ |
+2011-04-25 Levi Weintraub <leviw@chromium.org> |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ REGRESSION: a character appears after tab span when typing immediately before the tab span |
+ https://bugs.webkit.org/show_bug.cgi?id=58132 |
+ |
+ Correcting the order of operations we use to avoid inserting into invalid positions in |
+ ReplaceSelectionCommand to avoid inserting into tab-spans. |
+ |
+ Test: editing/pasteboard/paste-before-tab-span.html |
+ |
+ * editing/ReplaceSelectionCommand.cpp: |
+ (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after |
+ positionAvoidingPrecedingNodes, since that function could once again put our position |
+ inside a tab span. |
+ |
+2011-04-25 David Levin <levin@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Fix OwnPtr strict error in ImageBuffer.h |
+ https://bugs.webkit.org/show_bug.cgi?id=59422 |
+ |
+ * platform/graphics/ImageBuffer.h: |
+ (WebCore::ImageBuffer::create): |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ Fix strict OwnPtr violations and whitelist known-tricky files |
+ https://bugs.webkit.org/show_bug.cgi?id=59421 |
+ |
+ With this patch, WebCore builds cleanly with strict OwnPtrs. |
+ |
+ * dom/MessagePort.cpp: |
+ (WebCore::MessagePort::MessagePort): |
+ * dom/XMLDocumentParserLibxml2.cpp: |
+ * page/ContextMenuController.cpp: |
+ (WebCore::ContextMenuController::ContextMenuController): |
+ (WebCore::ContextMenuController::clearContextMenu): |
+ * page/PluginHalter.cpp: |
+ * platform/graphics/MediaPlayer.cpp: |
+ * platform/network/ResourceRequestBase.cpp: |
+ (WebCore::ResourceRequestBase::adopt): |
+ (WebCore::ResourceRequestBase::copyData): |
+ * svg/SVGDocumentExtensions.cpp: |
+ |
+2011-04-25 David Levin <levin@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Fix OwnPtr strict errors in DatasetDOMStringMap.h. |
+ https://bugs.webkit.org/show_bug.cgi?id=59419 |
+ |
+ * dom/DatasetDOMStringMap.h: |
+ (WebCore::DatasetDOMStringMap::create): |
+ |
+2011-04-25 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ KeyboardEvent.cpp should work with strict OwnPtrs. |
+ https://bugs.webkit.org/show_bug.cgi?id=59403 |
+ |
+ * dom/KeyboardEvent.cpp: |
+ (WebCore::KeyboardEvent::KeyboardEvent): |
+ |
+2011-04-25 James Robinson <jamesr@chromium.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr |
+ https://bugs.webkit.org/show_bug.cgi?id=59377 |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::applyProperty): |
+ * page/animation/AnimationBase.cpp: |
+ (WebCore::PropertyWrapperShadow::PropertyWrapperShadow): |
+ (WebCore::PropertyWrapperShadow::blend): |
+ * rendering/style/RenderStyle.cpp: |
+ (WebCore::RenderStyle::setTextShadow): |
+ (WebCore::RenderStyle::setBoxShadow): |
+ * rendering/style/RenderStyle.h: |
+ (WebCore::InheritedFlags::textShadow): |
+ * rendering/style/StyleRareInheritedData.cpp: |
+ (WebCore::StyleRareInheritedData::StyleRareInheritedData): |
+ (WebCore::StyleRareInheritedData::~StyleRareInheritedData): |
+ * rendering/style/StyleRareInheritedData.h: |
+ * rendering/style/StyleRareNonInheritedData.cpp: |
+ (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): |
+ |
+2011-04-25 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r84864. |
+ http://trac.webkit.org/changeset/84864 |
+ https://bugs.webkit.org/show_bug.cgi?id=59413 |
+ |
+ Expect result of use-crash-in-non-wellformed-document.svg is |
+ platform dependent (Requested by leoyang on #webkit). |
+ |
+ * svg/SVGUseElement.cpp: |
+ (WebCore::SVGUseElement::insertedIntoDocument): |
+ |
+2011-04-25 Leo Yang <leo.yang@torchmobile.com.cn> |
+ |
+ Reviewed by Nikolas Zimmermann. |
+ |
+ ASSERT failure in SVGUseElement |
+ https://bugs.webkit.org/show_bug.cgi?id=59313 |
+ |
+ In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource) |
+ was wrong because the document may not be well-formed. |
+ |
+ This patch asserts the element is not pending on resource or the |
+ document is not well-formed. |
+ |
+ Test: svg/custom/use-crash-in-non-wellformed-document.svg |
+ |
+ * svg/SVGUseElement.cpp: |
+ (WebCore::isWellFormedDocument): |
+ (WebCore::SVGUseElement::insertedIntoDocument): |
+ |
+2011-04-25 Igor Oliveira <igor.oliveira@openbossa.org> |
+ |
+ Reviewed by Tony Chang. |
+ |
+ Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class |
+ https://bugs.webkit.org/show_bug.cgi?id=59028 |
+ |
+ The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms. |
+ Moving the code for base class we can reduce the efforts to support DataTransferItems |
+ element in different platforms. |
+ |
+ * Android.mk: |
+ * CMakeLists.txt: |
+ * GNUmakefile.list.am: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * dom/DataTransferItem.cpp: |
+ (WebCore::DataTransferItem::DataTransferItem): |
+ (WebCore::DataTransferItem::owner): |
+ (WebCore::DataTransferItem::kind): |
+ (WebCore::DataTransferItem::type): |
+ * dom/DataTransferItem.h: |
+ * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp. |
+ (WebCore::DataTransferItems::DataTransferItems): |
+ (WebCore::DataTransferItems::length): |
+ (WebCore::DataTransferItems::item): |
+ (WebCore::DataTransferItems::deleteItem): |
+ (WebCore::DataTransferItems::clear): |
+ (WebCore::DataTransferItems::add): |
+ * dom/DataTransferItems.h: |
+ * platform/chromium/DataTransferItemChromium.cpp: |
+ (WebCore::DataTransferItem::create): |
+ (WebCore::DataTransferItemChromium::DataTransferItemChromium): |
+ (WebCore::DataTransferItemChromium::getAsString): |
+ (WebCore::DataTransferItemChromium::getAsFile): |
+ * platform/chromium/DataTransferItemChromium.h: |
+ * platform/chromium/DataTransferItemsChromium.cpp: |
+ (WebCore::DataTransferItemsChromium::DataTransferItemsChromium): |
+ * platform/chromium/DataTransferItemsChromium.h: |
+ |
+2011-04-25 Chris Marrin <cmarrin@apple.com> |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ REGRESSION(75137): directly composited images are double-drawn sometimes |
+ https://bugs.webkit.org/show_bug.cgi?id=58632 |
+ |
+ Depending on the order of operations (layout, creating compositing |
+ layers and creating simple image layers) a layer can have both image |
+ content and have m_drawsContent=true. In this case 2 copies of the image |
+ are drawn in the layer. If the image has alpha, it looks wrong. |
+ |
+ I added an updateDrawsContent() call after setting the image contents |
+ to make sure it's correct. |
+ |
+ I couldn't create a test case that shows the problem because layerTreeAsText() |
+ doesn't emit enough info to show this level of detail. I've opened |
+ https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that. |
+ |
+ * rendering/RenderLayerBacking.cpp: |
+ (WebCore::RenderLayerBacking::updateImageContents): |
+ |
+2011-04-25 Kenneth Russell <kbr@google.com> |
+ |
+ Reviewed by David Levin. |
+ |
+ Fix OwnPtr strict errors in InlineFlowBox.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=59392 |
+ |
+ * rendering/InlineFlowBox.cpp: |
+ (WebCore::InlineFlowBox::setLayoutOverflow): |
+ (WebCore::InlineFlowBox::setVisualOverflow): |
+ |
+2011-04-25 Kenneth Russell <kbr@google.com> |
+ |
+ Reviewed by David Levin. |
+ |
+ Fix OwnPtr strict errors in TransformState.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=59380 |
+ |
+ * rendering/TransformState.cpp: |
+ (WebCore::TransformState::applyTransform): |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by James Robinson. |
+ |
+ DOMWindow.cpp should work with strict OwnPtrs |
+ https://bugs.webkit.org/show_bug.cgi?id=59356 |
+ |
+ * page/DOMWindow.cpp: |
+ (WebCore::PostMessageTimer::fired): |
+ (WebCore::DOMWindow::postMessageTimerFired): |
+ * page/DOMWindow.h: |
+ |
+2011-04-25 Adam Klein <adamk@chromium.org> |
+ |
+ Reviewed by James Robinson. |
+ |
+ Fix OwnPtr strict errors in some SVG classes. |
+ https://bugs.webkit.org/show_bug.cgi?id=59395 |
+ |
+ * rendering/style/SVGRenderStyleDefs.cpp: |
+ (WebCore::StyleShadowSVGData::StyleShadowSVGData): |
+ * svg/SVGSVGElement.cpp: |
+ (WebCore::SVGSVGElement::SVGSVGElement): |
+ * svg/SVGStyledTransformableElement.cpp: |
+ (WebCore::SVGStyledTransformableElement::supplementalTransform): |
+ * svg/SVGTextElement.cpp: |
+ (WebCore::SVGTextElement::supplementalTransform): |
+ * svg/graphics/SVGImage.cpp: |
+ (WebCore::SVGImage::dataChanged): |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Re-land changes to ValidationMessage. |
+ |
+ * html/ValidationMessage.cpp: |
+ (WebCore::ValidationMessage::setMessage): |
+ (WebCore::ValidationMessage::setMessageDOMAndStartTimer): |
+ (WebCore::ValidationMessage::requestToHideMessage): |
+ |
+2011-04-25 Ojan Vafai <ojan@chromium.org> |
+ |
+ Reviewed by James Robinson. |
+ |
+ fix OwnPtr strict error in FrameView.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=59402 |
+ |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::FrameView): |
+ (WebCore::FrameView::addWidgetToUpdate): |
+ |
+2011-04-25 Adam Klein <adamk@chromium.org> |
+ |
+ Unreviewed, rolling out r84844. |
+ http://trac.webkit.org/changeset/84844 |
+ https://bugs.webkit.org/show_bug.cgi?id=59395 |
+ |
+ Checked in too much. |
+ |
+ * rendering/style/SVGRenderStyleDefs.cpp: |
+ (WebCore::StyleShadowSVGData::StyleShadowSVGData): |
+ * svg/SVGDocumentExtensions.cpp: |
+ (WebCore::SVGDocumentExtensions::removePendingResource): |
+ * svg/SVGSVGElement.cpp: |
+ (WebCore::SVGSVGElement::SVGSVGElement): |
+ * svg/SVGStyledTransformableElement.cpp: |
+ (WebCore::SVGStyledTransformableElement::supplementalTransform): |
+ * svg/SVGTextElement.cpp: |
+ (WebCore::SVGTextElement::supplementalTransform): |
+ * svg/graphics/SVGImage.cpp: |
+ (WebCore::SVGImage::dataChanged): |
+ |
+2011-04-25 Adrienne Walker <enne@google.com> |
+ |
+ Reviewed by David Levin. |
+ |
+ Make ActiveDOMCallback play nice with OwnPtr strict mode |
+ https://bugs.webkit.org/show_bug.cgi?id=59398 |
+ |
+ * bindings/generic/ActiveDOMCallback.cpp: |
+ (WebCore::ActiveDOMCallback::ActiveDOMCallback): |
+ |
+2011-04-25 Adam Klein <adamk@chromium.org> |
+ |
+ Reviewed by James Robinson. |
+ |
+ Fix OwnPtr strict errors in some SVG classes. |
+ https://bugs.webkit.org/show_bug.cgi?id=59395 |
+ |
+ * rendering/style/SVGRenderStyleDefs.cpp: |
+ (WebCore::StyleShadowSVGData::StyleShadowSVGData): |
+ * svg/SVGSVGElement.cpp: |
+ (WebCore::SVGSVGElement::SVGSVGElement): |
+ * svg/SVGStyledTransformableElement.cpp: |
+ (WebCore::SVGStyledTransformableElement::supplementalTransform): |
+ * svg/SVGTextElement.cpp: |
+ (WebCore::SVGTextElement::supplementalTransform): |
+ * svg/graphics/SVGImage.cpp: |
+ (WebCore::SVGImage::dataChanged): |
+ |
+2011-04-25 James Robinson <jamesr@chromium.org> |
+ |
+ Unreviewed, rolling out r84835. |
+ http://trac.webkit.org/changeset/84835 |
+ https://bugs.webkit.org/show_bug.cgi?id=59394 |
+ |
+ Breaks compile because Deque<OwnPtr> doesn't work |
+ |
+ * dom/XMLDocumentParserLibxml2.cpp: |
+ (WebCore::PendingCallbacks::~PendingCallbacks): |
+ (WebCore::PendingCallbacks::appendStartElementNSCallback): |
+ (WebCore::PendingCallbacks::appendEndElementNSCallback): |
+ (WebCore::PendingCallbacks::appendCharactersCallback): |
+ (WebCore::PendingCallbacks::appendProcessingInstructionCallback): |
+ (WebCore::PendingCallbacks::appendCDATABlockCallback): |
+ (WebCore::PendingCallbacks::appendCommentCallback): |
+ (WebCore::PendingCallbacks::appendInternalSubsetCallback): |
+ (WebCore::PendingCallbacks::appendErrorCallback): |
+ (WebCore::XMLDocumentParser::XMLDocumentParser): |
+ * html/ValidationMessage.cpp: |
+ (WebCore::ValidationMessage::setMessage): |
+ (WebCore::ValidationMessage::setMessageDOMAndStartTimer): |
+ (WebCore::ValidationMessage::requestToHideMessage): |
+ |
+2011-04-25 James Robinson <jamesr@chromium.org> |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Fix OwnPtr strict mode violation in ImageBufferCG |
+ https://bugs.webkit.org/show_bug.cgi?id=59396 |
+ |
+ * platform/graphics/cg/ImageBufferCG.cpp: |
+ (WebCore::ImageBuffer::ImageBuffer): |
+ |
+2011-04-25 Huang Dongsung <luxtella@company100.net> |
+ |
+ Reviewed by Dirk Schulze. |
+ |
+ [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware(). |
+ https://bugs.webkit.org/show_bug.cgi?id=59308 |
+ |
+ An unused local variable is created and even allocates heap memory. |
+ |
+ * platform/graphics/skia/PlatformContextSkia.cpp: |
+ (WebCore::PlatformContextSkia::readbackHardwareToSoftware): |
+ |
+2011-04-25 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Qt build fix: Updated files not used by other ports for rename. |
+ |
+ * bindings/js/JSTouchCustom.cpp: |
+ (WebCore::toJSNewlyCreated): |
+ * bindings/js/JSTouchListCustom.cpp: |
+ (WebCore::toJSNewlyCreated): |
+ |
+2011-04-25 Adrienne Walker <enne@google.com> |
+ |
+ Reviewed by David Levin. |
+ |
+ WebCore/css/CSS* files should play nice with strict OwnPtrs |
+ https://bugs.webkit.org/show_bug.cgi?id=59382 |
+ |
+ * css/CSSFontFaceSource.cpp: |
+ (WebCore::CSSFontFaceSource::getFontData): |
+ * css/CSSParser.cpp: |
+ (WebCore::CSSParser::addProperty): |
+ (WebCore::CSSParser::parseValue): |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by James Robinson. |
+ |
+ ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs |
+ https://bugs.webkit.org/show_bug.cgi?id=59394 |
+ |
+ * dom/XMLDocumentParserLibxml2.cpp: |
+ (WebCore::PendingCallbacks::PendingCallbacks): |
+ (WebCore::PendingCallbacks::appendStartElementNSCallback): |
+ (WebCore::PendingCallbacks::appendEndElementNSCallback): |
+ (WebCore::PendingCallbacks::appendCharactersCallback): |
+ (WebCore::PendingCallbacks::appendProcessingInstructionCallback): |
+ (WebCore::PendingCallbacks::appendCDATABlockCallback): |
+ (WebCore::PendingCallbacks::appendCommentCallback): |
+ (WebCore::PendingCallbacks::appendInternalSubsetCallback): |
+ (WebCore::PendingCallbacks::appendErrorCallback): |
+ (WebCore::XMLDocumentParser::XMLDocumentParser): |
+ * html/ValidationMessage.cpp: |
+ (WebCore::ValidationMessage::setMessage): |
+ (WebCore::ValidationMessage::setMessageDOMAndStartTimer): |
+ (WebCore::ValidationMessage::requestToHideMessage): |
+ |
+2011-04-25 James Robinson <jamesr@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Fix OwnPtr strictness issues in WebCore/inspector/ |
+ https://bugs.webkit.org/show_bug.cgi?id=59387 |
+ |
+ * inspector/InspectorAgent.cpp: |
+ (WebCore::InspectorAgent::InspectorAgent): |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::InspectorController): |
+ * inspector/InspectorStyleSheet.cpp: |
+ (WebCore::InspectorStyleSheet::ensureSourceData): |
+ |
+2011-04-25 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ Removed XPathNamespace because it was unused |
+ https://bugs.webkit.org/show_bug.cgi?id=59381 |
+ |
+ This allows us to make Node::ownerDocument() non-virtual, though it has |
+ the unhappy side-effect of rebuilding the world. |
+ |
+ * CMakeLists.txt: |
+ * GNUmakefile.list.am: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: Bye bye dead code. |
+ |
+ * dom/Node.h: Hello fast code! |
+ |
+ * xml/XPathNamespace.cpp: Removed. |
+ * xml/XPathNamespace.h: Removed. |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ HistoryItemMac should play nice with OwnPtrs |
+ https://bugs.webkit.org/show_bug.cgi?id=59388 |
+ |
+ * history/mac/HistoryItemMac.mm: |
+ (WebCore::HistoryItem::setTransientProperty): |
+ |
+2011-04-25 David Levin <levin@chromium.org> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ Fix strict OwnPtrs in ContextMenuController.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=59375 |
+ |
+ * page/ContextMenuController.cpp: |
+ (WebCore::ContextMenuController::createContextMenu): |
+ (WebCore::separatorItem): |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ CheckedRadioButton should play nice with strict OwnPtr |
+ https://bugs.webkit.org/show_bug.cgi?id=59386 |
+ |
+ * dom/CheckedRadioButtons.cpp: |
+ (WebCore::CheckedRadioButtons::addButton): |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ Resource*.cpp should play nice with strict OwnPtrs |
+ https://bugs.webkit.org/show_bug.cgi?id=59383 |
+ |
+ * bridge/runtime_method.cpp: |
+ (JSC::RuntimeMethod::RuntimeMethod): |
+ * platform/network/ResourceHandle.cpp: |
+ (WebCore::ResourceHandle::ResourceHandle): |
+ * platform/network/ResourceResponseBase.cpp: |
+ (WebCore::ResourceResponseBase::adopt): |
+ (WebCore::ResourceResponseBase::copyData): |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs |
+ https://bugs.webkit.org/show_bug.cgi?id=59374 |
+ |
+ * bridge/objc/objc_runtime.mm: |
+ (JSC::Bindings::callObjCFallbackObject): |
+ * page/Page.cpp: |
+ (WebCore::Page::Page): |
+ (WebCore::Page::initGroup): |
+ * page/PageGroup.cpp: |
+ (WebCore::PageGroup::addUserScriptToWorld): |
+ (WebCore::PageGroup::addUserStyleSheetToWorld): |
+ * page/mac/PageMac.cpp: |
+ (WebCore::Page::addSchedulePair): |
+ |
+2011-04-25 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Build fix: This time for sure! |
+ |
+ * dom/make_names.pl: |
+ |
+2011-04-25 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Build fix: Let's edit the script instead of the autogenrated file. That |
+ way, our change will stand the test of time. |
+ |
+ * dom/make_names.pl: |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap |
+ https://bugs.webkit.org/show_bug.cgi?id=59368 |
+ |
+ * html/HTMLMediaElement.cpp: |
+ (WebCore::HTMLMediaElement::HTMLMediaElement): |
+ * platform/network/HTTPHeaderMap.cpp: |
+ (WebCore::HTTPHeaderMap::copyData): |
+ |
+2011-04-25 James Robinson <jamesr@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Fix strict OwnPtr violations in Render*.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=59361 |
+ |
+ * rendering/RenderBlock.cpp: |
+ (WebCore::RenderBlock::RenderBlock): |
+ (WebCore::RenderBlock::finishDelayUpdateScrollInfo): |
+ * rendering/RenderBox.cpp: |
+ (WebCore::RenderBox::addLayoutOverflow): |
+ (WebCore::RenderBox::addVisualOverflow): |
+ * rendering/RenderButton.cpp: |
+ (WebCore::RenderButton::styleDidChange): |
+ * rendering/RenderLayer.cpp: |
+ (WebCore::RenderLayer::updateTransform): |
+ (WebCore::RenderLayer::paintChildLayerIntoColumns): |
+ (WebCore::RenderLayer::hitTestChildLayerColumns): |
+ (WebCore::RenderLayer::ensureBacking): |
+ * rendering/RenderTable.cpp: |
+ (WebCore::RenderTable::styleDidChange): |
+ * rendering/RenderView.cpp: |
+ (WebCore::RenderView::compositor): |
+ * rendering/style/RenderStyle.cpp: |
+ (WebCore::RenderStyle::addCachedPseudoStyle): |
+ (WebCore::RenderStyle::accessCounterDirectives): |
+ (WebCore::RenderStyle::accessAnimations): |
+ (WebCore::RenderStyle::accessTransitions): |
+ * rendering/svg/RenderSVGResourceFilter.cpp: |
+ (WebCore::RenderSVGResourceFilter::applyResource): |
+ * rendering/svg/SVGResources.cpp: |
+ (WebCore::SVGResources::SVGResources): |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Attempt to fix the compile. |
+ |
+ * platform/graphics/MediaPlayer.cpp: |
+ (WebCore::MediaPlayer::loadWithNextMediaEngine): |
+ |
+2011-04-25 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Rubber-stamped by Beth Dakin. |
+ |
+ Merged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into |
+ CREATE_DOM_WRAPPER because there's no meaningful difference between |
+ them anymore. |
+ |
+ * bindings/js/JSCDATASectionCustom.cpp: |
+ (WebCore::toJSNewlyCreated): |
+ * bindings/js/JSCSSRuleCustom.cpp: |
+ (WebCore::toJS): |
+ * bindings/js/JSCSSValueCustom.cpp: |
+ (WebCore::toJS): |
+ * bindings/js/JSDOMBinding.h: |
+ * bindings/js/JSDocumentCustom.cpp: |
+ (WebCore::toJS): |
+ * bindings/js/JSElementCustom.cpp: |
+ (WebCore::toJSNewlyCreated): |
+ * bindings/js/JSEventCustom.cpp: |
+ (WebCore::toJS): |
+ * bindings/js/JSHTMLCollectionCustom.cpp: |
+ (WebCore::toJS): |
+ * bindings/js/JSImageDataCustom.cpp: |
+ (WebCore::toJS): |
+ * bindings/js/JSNodeCustom.cpp: |
+ (WebCore::createWrapperInline): |
+ * bindings/js/JSSVGPathSegCustom.cpp: |
+ (WebCore::toJS): |
+ * bindings/js/JSStyleSheetCustom.cpp: |
+ (WebCore::toJS): |
+ * bindings/js/JSTextCustom.cpp: |
+ (WebCore::toJSNewlyCreated): |
+ * bindings/js/JSWebKitCSSMatrixCustom.cpp: |
+ (WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix): |
+ * bindings/js/JSWebSocketCustom.cpp: |
+ (WebCore::JSWebSocketConstructor::constructJSWebSocket): |
+ * bindings/js/JSXMLHttpRequestCustom.cpp: |
+ (WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest): |
+ * bindings/js/JSXSLTProcessorCustom.cpp: |
+ (WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor): |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by James Robinson. |
+ |
+ HTMLDocumentParser should play nice with OwnPtrs |
+ https://bugs.webkit.org/show_bug.cgi?id=59363 |
+ |
+ * html/parser/HTMLDocumentParser.cpp: |
+ (WebCore::HTMLDocumentParser::pumpTokenizer): |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by James Robinson. |
+ |
+ Frame.cpp should work with strict OwnPtrs |
+ https://bugs.webkit.org/show_bug.cgi?id=59360 |
+ |
+ * page/Frame.cpp: |
+ (WebCore::createRegExpForLabels): |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ Fix strict OwnPtr in Element.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=59357 |
+ |
+ * dom/NodeRareData.h: |
+ (WebCore::NodeRareData::ensureEventTargetData): |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ Fix strict OwnPtr issues in Media*.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=59354 |
+ |
+ There's still a tricky case in MediaPlayer.cpp, but we'll worry about |
+ that later. |
+ |
+ * css/MediaQueryMatcher.cpp: |
+ (WebCore::MediaQueryMatcher::addListener): |
+ * dom/Document.cpp: |
+ * platform/graphics/MediaPlayer.cpp: |
+ (WebCore::createNullMediaPlayer): |
+ |
+2011-04-25 James Robinson <jamesr@chromium.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor |
+ https://bugs.webkit.org/show_bug.cgi?id=59353 |
+ |
+ * rendering/RenderLayerCompositor.cpp: |
+ (WebCore::RenderLayerCompositor::RenderLayerCompositor): |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by James Robinson. |
+ |
+ Worker*.cpp should work with strict OwnPtrs |
+ https://bugs.webkit.org/show_bug.cgi?id=59346 |
+ |
+ * inspector/WorkerInspectorController.cpp: |
+ (WebCore::WorkerInspectorController::WorkerInspectorController): |
+ * workers/WorkerContext.cpp: |
+ (WebCore::WorkerContext::WorkerContext): |
+ * workers/WorkerRunLoop.cpp: |
+ (WebCore::WorkerRunLoop::WorkerRunLoop): |
+ * workers/WorkerScriptLoader.cpp: |
+ (WebCore::WorkerScriptLoader::createResourceRequest): |
+ |
+2011-04-25 James Robinson <jamesr@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Remove bad use of OwnPtr::set() in IconDatabase.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=59344 |
+ |
+ Needed for strict OwnPtr compliance. |
+ |
+ * loader/icon/IconDatabase.cpp: |
+ (WebCore::readySQLiteStatement): |
+ |
+2011-04-25 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Maciej Stachowiak. |
+ |
+ ImageBuffer.h should work with strict OwnPtrs |
+ https://bugs.webkit.org/show_bug.cgi?id=59341 |
+ |
+ This patch is to prepare for the strict OwnPtr hack-a-thon. |
+ |
+ * platform/graphics/ImageBuffer.h: |
+ (WebCore::ImageBuffer::create): |
+ |
+2011-04-25 Steve Falkenburg <sfalken@apple.com> |
+ |
+ Reviewed by Brian Weinstein. |
+ |
+ WebCore build on Windows should include windows.h in its precompiled header to speed builds |
+ https://bugs.webkit.org/show_bug.cgi?id=59339 |
+ |
+ windows.h is included by several of the underlying wtf headers, including Atomics.h and |
+ ThreadingPrimitives.h anyway, so include it in the WebCorePrefix.h to speed up compilation. |
+ |
+ On my 8 core Mac Pro, this reduces a clean rebuild of debug WebCore from 8 minutes to 7 minutes |
+ (a 12% speedup). |
+ |
+ * WebCorePrefix.h: Include windows.h |
+ |
+2011-04-25 Martin Robinson <mrobinson@igalia.com> |
+ |
+ Reviewed by Xan Lopez. |
+ |
+ [GTK] Crash in WebCore::FrameView::notifyPageThatContentAreaWillPaint() |
+ https://bugs.webkit.org/show_bug.cgi?id=59311 |
+ |
+ * platform/gtk/MainFrameScrollbarGtk.cpp: |
+ (MainFrameScrollbarGtk::attachAdjustment): Before connecting an adjustment to a scrollbar |
+ disconnect any lingering signal handlers. This prevents an adjustment from controlling the |
+ active ScrollView and some zombie ScrollView. |
+ |
+2011-04-25 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Another shot at fixing the EFL build. |
+ |
+ * UseJSC.cmake: |
+ * bindings/js/JSDOMBinding.cpp: |
+ |
+2011-04-25 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Try to fix EFL build. |
+ |
+ * UseJSC.cmake: Added a missing file. |
+ |
+2011-04-25 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Reviewed by Oliver Hunt. |
+ |
+ Removed a use of markDOMObjectWrapper: ActiveDOMObjects, Workers, and MessagePorts |
+ https://bugs.webkit.org/show_bug.cgi?id=59333 |
+ |
+ * WebCore.xcodeproj/project.pbxproj: Added .idl files for easier editing. |
+ |
+ * bindings/js/JSDOMBinding.cpp: |
+ * bindings/js/JSDOMBinding.h: |
+ * bindings/js/JSDocumentCustom.cpp: |
+ * bindings/js/JSWorkerContextCustom.cpp: |
+ (WebCore::JSWorkerContext::visitChildren): Removed now-unused functions. |
+ |
+ * bindings/scripts/CodeGeneratorJS.pm: Added support for ActiveDOMObject |
+ lifetime management. |
+ |
+ * dom/Document.idl: No need for a custom mark function anymore, since |
+ ActiveDOMObjets now manage their own lifetimes. |
+ |
+ * dom/MessagePort.cpp: |
+ (WebCore::MessagePort::hasPendingActivity): Correctly report that we |
+ have pending activity when we're remotely entangled, instead of relying |
+ on our clients to know this about us and do the check for us. |
+ |
+ * dom/MessagePort.h: FIXME! |
+ |
+ * dom/MessagePort.idl: |
+ * fileapi/DOMFileSystem.idl: |
+ * fileapi/FileReader.idl: |
+ * fileapi/FileWriter.idl: |
+ * notifications/Notification.idl: |
+ * notifications/NotificationCenter.idl: |
+ * page/EventSource.idl: |
+ * storage/IDBDatabase.idl: |
+ * storage/IDBRequest.idl: |
+ * storage/IDBTransaction.idl: |
+ * webaudio/AudioContext.idl: |
+ * websockets/WebSocket.idl: |
+ * workers/AbstractWorker.idl: |
+ * workers/SharedWorker.idl: |
+ * workers/Worker.idl: Opt in to ActiveDOMObject lifetime management. |
+ |
+ * workers/WorkerContext.cpp: |
+ (WebCore::WorkerContext::hasPendingActivity): No need to make up for |
+ MessagePort::hasPendingActivity being wrong anymore, since it's now right. |
+ |
+ * xml/XMLHttpRequest.idl: Opt in to ActiveDOMObject lifetime management. |
+ |
+2011-04-25 Yury Semikhatsky <yurys@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: worker messages should be routed to corresponding worker front-end |
+ https://bugs.webkit.org/show_bug.cgi?id=59323 |
+ |
+ Added WorkerManager which is responsible for routing messages between |
+ Page inspector front-end and Worker inspector front-ends. |
+ |
+ * WebCore.gypi: |
+ * inspector/front-end/WebKit.qrc: |
+ * inspector/front-end/WorkerManager.js: Added. |
+ (WebInspector.WorkerManager): |
+ (WebInspector.WorkerManager.loaded.InspectorFrontendHost.sendMessageToBackend): |
+ (WebInspector.WorkerManager.loaded.InspectorFrontendHost.loaded): |
+ (WebInspector.WorkerManager.loaded): |
+ (WebInspector.WorkerFrontendStub): |
+ (WebInspector.WorkerFrontendStub.prototype._receiveMessage): |
+ (WebInspector.WorkerDispatcher): |
+ (WebInspector.WorkerDispatcher.prototype._receiveMessage): |
+ (WebInspector.WorkerDispatcher.prototype.workerCreated): |
+ (WebInspector.WorkerDispatcher.prototype.dispatchMessageFromWorker): |
+ * inspector/front-end/inspector.html: |
+ * inspector/front-end/inspector.js: |
+ (WebInspector.loaded): |
+ |
+2011-04-25 Annie Sullivan <sullivan@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: [Resources panel] Should be easy to copy data. |
+ https://bugs.webkit.org/show_bug.cgi?id=45662 |
+ |
+ Adds context menu items to copy resource location, resource request headers, and resource response headers. |
+ |
+ * inspector/front-end/NetworkPanel.js: |
+ (WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu. |
+ (WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard. |
+ (WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard. |
+ (WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard. |
+ * inspector/front-end/Resource.js: |
+ (WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders. |
+ (WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders. |
+ |
+2011-04-25 Alexander Pavlov <apavlov@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM |
+ https://bugs.webkit.org/show_bug.cgi?id=59322 |
+ |
+ Use TextResourceDecoder to determine external stylesheet charsets correctly. |
+ |
+ Test: inspector/styles/parse-utf8-bom.html |
+ |
+ * inspector/InspectorStyleSheet.cpp: |
+ (WebCore::InspectorStyleSheet::originalStyleSheetText): |
+ |
+2011-04-25 Pavel Feldman <pfeldman@google.com> |
+ |
+ Not reviewed: Inspector.json cleanup. |
+ |
+ * inspector/Inspector.json: |
+ |
+2011-04-25 Yury Semikhatsky <yurys@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: introduce InspectorWorkerAgent |
+ https://bugs.webkit.org/show_bug.cgi?id=59320 |
+ |
+ InspectorWorkerAgent is responsible for routing inspector messages |
+ between worker context inspector agents and corresponding worker |
+ inspector front-end. |
+ |
+ * CMakeLists.txt: |
+ * GNUmakefile.list.am: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * inspector/CodeGeneratorInspector.pm: |
+ * inspector/Inspector.json: |
+ * inspector/InspectorAgent.cpp: |
+ (WebCore::InspectorAgent::InspectorAgent): |
+ (WebCore::InspectorAgent::setFrontend): |
+ (WebCore::InspectorAgent::disconnectFrontend): |
+ * inspector/InspectorAgent.h: |
+ (WebCore::InspectorAgent::workerAgent): |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::connectFrontend): |
+ (WebCore::InspectorController::disconnectFrontend): |
+ * inspector/InspectorInstrumentation.cpp: |
+ (WebCore::InspectorInstrumentation::didStartWorkerContextImpl): |
+ * inspector/InspectorInstrumentation.h: |
+ (WebCore::InspectorInstrumentation::willStartWorkerContext): |
+ (WebCore::InspectorInstrumentation::didStartWorkerContext): |
+ * inspector/InspectorWorkerAgent.cpp: Added. |
+ (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel): |
+ (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): |
+ (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id): |
+ (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy): |
+ (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend): |
+ (WebCore::InspectorWorkerAgent::create): |
+ (WebCore::InspectorWorkerAgent::InspectorWorkerAgent): |
+ (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent): |
+ (WebCore::InspectorWorkerAgent::setFrontend): |
+ (WebCore::InspectorWorkerAgent::clearFrontend): |
+ (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector): |
+ (WebCore::InspectorWorkerAgent::didStartWorkerContext): |
+ * inspector/InspectorWorkerAgent.h: Added. |
+ * inspector/InstrumentingAgents.h: |
+ (WebCore::InstrumentingAgents::InstrumentingAgents): |
+ (WebCore::InstrumentingAgents::inspectorWorkerAgent): |
+ (WebCore::InstrumentingAgents::setInspectorWorkerAgent): |
+ * inspector/WorkerInspectorController.cpp: |
+ (WebCore::WorkerInspectorController::connectFrontend): |
+ * inspector/generate-inspector-idl: |
+ * workers/Worker.cpp: |
+ (WebCore::Worker::notifyFinished): |
+ * workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector |
+ messages sent from the inspected page worker agent to the worker context inspector agents. |
+ (WebCore::WorkerContextInspectorProxy::connectFrontend): |
+ (WebCore::WorkerContextInspectorProxy::disconnectFrontend): |
+ (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector): |
+ (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy): |
+ * workers/WorkerContextProxy.h: |
+ (WebCore::WorkerContextProxy::inspectorProxy): |
+ |
+2011-04-25 Pavel Feldman <pfeldman@google.com> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: move Frame and Resource Tree management into the Page agent. |
+ https://bugs.webkit.org/show_bug.cgi?id=59321 |
+ |
+ Network agent should only handle network-related activities. |
+ Frame structure should be managed by the Page agent instead. |
+ |
+ * inspector/Inspector.json: |
+ * inspector/InspectorAgent.cpp: |
+ (WebCore::InspectorAgent::InspectorAgent): |
+ * inspector/InspectorDOMAgent.cpp: |
+ (WebCore::InspectorDOMAgent::InspectorDOMAgent): |
+ (WebCore::InspectorDOMAgent::setFrontend): |
+ (WebCore::InspectorDOMAgent::restore): |
+ (WebCore::InspectorDOMAgent::highlightFrame): |
+ * inspector/InspectorDOMAgent.h: |
+ (WebCore::InspectorDOMAgent::create): |
+ * inspector/InspectorInstrumentation.cpp: |
+ (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl): |
+ (WebCore::InspectorInstrumentation::loadEventFiredImpl): |
+ (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl): |
+ (WebCore::InspectorInstrumentation::didCommitLoadImpl): |
+ * inspector/InspectorPageAgent.cpp: |
+ (WebCore::InspectorPageAgent::create): |
+ (WebCore::InspectorPageAgent::resourceContent): |
+ (WebCore::InspectorPageAgent::resourceContentBase64): |
+ (WebCore::InspectorPageAgent::resourceData): |
+ (WebCore::InspectorPageAgent::cachedResource): |
+ (WebCore::InspectorPageAgent::resourceTypeString): |
+ (WebCore::InspectorPageAgent::cachedResourceType): |
+ (WebCore::InspectorPageAgent::cachedResourceTypeString): |
+ (WebCore::InspectorPageAgent::InspectorPageAgent): |
+ (WebCore::InspectorPageAgent::setFrontend): |
+ (WebCore::InspectorPageAgent::reload): |
+ (WebCore::InspectorPageAgent::open): |
+ (WebCore::InspectorPageAgent::getCookies): |
+ (WebCore::InspectorPageAgent::deleteCookie): |
+ (WebCore::InspectorPageAgent::getResourceTree): |
+ (WebCore::InspectorPageAgent::getResourceContent): |
+ (WebCore::InspectorPageAgent::restore): |
+ (WebCore::InspectorPageAgent::domContentEventFired): |
+ (WebCore::InspectorPageAgent::loadEventFired): |
+ (WebCore::InspectorPageAgent::frameNavigated): |
+ (WebCore::InspectorPageAgent::frameDetached): |
+ (WebCore::InspectorPageAgent::didClearWindowObjectInWorld): |
+ (WebCore::InspectorPageAgent::mainFrame): |
+ (WebCore::pointerAsId): |
+ (WebCore::InspectorPageAgent::frameForId): |
+ (WebCore::InspectorPageAgent::frameId): |
+ (WebCore::InspectorPageAgent::loaderId): |
+ (WebCore::InspectorPageAgent::buildObjectForFrame): |
+ (WebCore::InspectorPageAgent::buildObjectForFrameTree): |
+ * inspector/InspectorPageAgent.h: |
+ * inspector/InspectorResourceAgent.cpp: |
+ (WebCore::buildObjectForCachedResource): |
+ (WebCore::InspectorResourceAgent::willSendRequest): |
+ (WebCore::InspectorResourceAgent::didReceiveResponse): |
+ (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): |
+ (WebCore::InspectorResourceAgent::setInitialScriptContent): |
+ (WebCore::InspectorResourceAgent::setInitialXHRContent): |
+ (WebCore::InspectorResourceAgent::InspectorResourceAgent): |
+ * inspector/InspectorResourceAgent.h: |
+ (WebCore::InspectorResourceAgent::create): |
+ * inspector/InspectorStyleSheet.cpp: |
+ (WebCore::InspectorStyleSheet::resourceStyleSheetText): |
+ * inspector/front-end/NetworkManager.js: |
+ (WebInspector.NetworkManager.prototype.requestContent): |
+ * inspector/front-end/NetworkPanel.js: |
+ (WebInspector.NetworkPanel): |
+ (WebInspector.NetworkPanel.prototype.frameNavigated): |
+ * inspector/front-end/ResourceTreeModel.js: |
+ (WebInspector.ResourceTreeModel): |
+ (WebInspector.ResourceTreeModel.prototype.frontendReused): |
+ (WebInspector.ResourceTreeModel.prototype.frameNavigated): |
+ (WebInspector.ResourceTreeModel.prototype.frameDetached): |
+ * inspector/front-end/inspector.js: |
+ (WebInspector.domContentEventFired): |
+ (WebInspector.loadEventFired): |
+ (WebInspector.frameNavigated): |
+ (WebInspector.frameDetached): |
+ |
+2011-04-25 Pavel Feldman <pfeldman@google.com> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: few protocol improvements. |
+ https://bugs.webkit.org/show_bug.cgi?id=59319 |
+ |
+ - Page domain is documented |
+ - setUserAgentOverride is moved to the Network agent |
+ - setSearchingForNode -> setInspectModeEnabled |
+ - highlightDOMNode -> highlightNode |
+ - reloadPage -> reload |
+ - openInNewWindow -> open with optional parameter |
+ |
+ * inspector/Inspector.json: |
+ * inspector/InspectorDOMAgent.cpp: |
+ (WebCore::InspectorDOMAgent::setInspectModeEnabled): |
+ (WebCore::InspectorDOMAgent::highlightNode): |
+ * inspector/InspectorDOMAgent.h: |
+ (WebCore::InspectorDOMAgent::hideNodeHighlight): |
+ * inspector/InspectorInstrumentation.cpp: |
+ (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl): |
+ * inspector/InspectorPageAgent.cpp: |
+ (WebCore::InspectorPageAgent::clearFrontend): |
+ (WebCore::InspectorPageAgent::reload): |
+ (WebCore::InspectorPageAgent::open): |
+ * inspector/InspectorPageAgent.h: |
+ * inspector/InspectorResourceAgent.cpp: |
+ (WebCore::InspectorResourceAgent::clearFrontend): |
+ (WebCore::InspectorResourceAgent::applyUserAgentOverride): |
+ (WebCore::InspectorResourceAgent::setUserAgentOverride): |
+ * inspector/InspectorResourceAgent.h: |
+ * inspector/front-end/AuditsPanel.js: |
+ (WebInspector.AuditsPanel.prototype._reloadResources): |
+ * inspector/front-end/ElementsPanel.js: |
+ (WebInspector.ElementsPanel.prototype.setSearchingForNode): |
+ * inspector/front-end/ExtensionServer.js: |
+ (WebInspector.ExtensionServer.prototype._onReload): |
+ * inspector/front-end/NetworkPanel.js: |
+ (WebInspector.NetworkDataGridNode.prototype._openInNewTab): |
+ * inspector/front-end/ResourcesPanel.js: |
+ (WebInspector.FrameResourceTreeElement.prototype.ondblclick): |
+ * inspector/front-end/inspector.js: |
+ (WebInspector.highlightDOMNode): |
+ (WebInspector.openResource): |
+ (WebInspector.documentKeyDown): |
+ |
+2011-04-25 Jon Lee <jonlee@apple.com> |
+ |
+ Reviewed by Maciej Stachowiak. |
+ |
+ Overlay scroller hard to see on pages with dark background (59183) |
+ https://bugs.webkit.org/show_bug.cgi?id=59183 |
+ <rdar://problem/8975367> |
+ |
+ Switch the scrollbar's overlay style depending on its frame's background color. |
+ This refactors the getDocumentBackgroundColor method needed for gestures. The style |
+ is determined and set on every paint() call to the Mac scrollbar theme. |
+ |
+ * WebCore.exp.in: adding method to allow changing style |
+ * page/Frame.cpp: |
+ (WebCore::Frame::getDocumentBackgroundColor): moving code from WebFrame for reuse by FrameView |
+ * page/Frame.h: |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color |
+ * page/FrameView.h: |
+ * platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles |
+ * platform/ScrollableArea.h: |
+ (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style |
+ * platform/mac/ScrollbarThemeMac.mm: |
+ (WebCore::ScrollbarThemeMac::paint): |
+ * platform/mac/WebCoreSystemInterface.h: |
+ * platform/mac/WebCoreSystemInterface.mm: |
+ |
+2011-04-25 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Maciej Stachowiak. |
+ |
+ <rdar://problem/9113516> REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation) |
+ https://bugs.webkit.org/show_bug.cgi?id=59315 |
+ |
+ * platform/Scrollbar.cpp: |
+ (WebCore::Scrollbar::Scrollbar): Initialize new member variables. |
+ (WebCore::Scrollbar::moveThumb): Added a boolean draggingDocument parameter. When true, the document |
+ is scrolled a distance equal to the change in the mouse position. |
+ (WebCore::Scrollbar::mouseMoved): Check with the theme whether the mouse move event should drag |
+ the document rather than the thumb, and pass the result to moveThumb. |
+ (WebCore::Scrollbar::mouseUp): Reset m_draggingDocument. |
+ * platform/Scrollbar.h: |
+ * platform/ScrollbarTheme.h: |
+ (WebCore::ScrollbarTheme::shouldDragDocumentInsteadOfThumb): Added. The base class implementation |
+ returns false. |
+ * platform/mac/ScrollbarThemeMac.h: |
+ * platform/mac/ScrollbarThemeMac.mm: |
+ (WebCore::ScrollbarThemeMac::shouldDragDocumentInsteadOfThumb): Overridden to return true if the |
+ Option key is down. |
+ |
+2011-04-24 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Removed a use of markDOMObjectWrapper: WebGL, XHR, workers; plus, more autogeneration |
+ https://bugs.webkit.org/show_bug.cgi?id=59307 |
+ |
+ * WebCore.xcodeproj/project.pbxproj: Added Blob.idl, so it's easier to edit. |
+ |
+ * bindings/js/JSCSSRuleCustom.cpp: |
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp: |
+ * bindings/js/JSCanvasRenderingContextCustom.cpp: |
+ * bindings/js/JSDOMApplicationCacheCustom.cpp: Autogenerate these instead |
+ of hand-coding them. |
+ |
+ * bindings/js/JSDOMBinding.h: |
+ (WebCore::root): Moved some GC helpers here from JSNodeCustom.h, because |
+ they're reasonably generic. |
+ |
+ * bindings/js/JSDOMImplementationCustom.cpp: |
+ * bindings/js/JSDOMStringMapCustom.cpp: |
+ * bindings/js/JSDOMTokenListCustom.cpp: |
+ * bindings/js/JSHTMLCollectionCustom.cpp: |
+ * bindings/js/JSMediaListCustom.cpp: Autogenerate these instead of |
+ hand-coding them. |
+ |
+ * bindings/js/JSMessageChannelCustom.cpp: |
+ (WebCore::JSMessageChannel::visitChildren): |
+ * bindings/js/JSMessagePortCustom.cpp: |
+ (WebCore::JSMessagePort::visitChildren): Use addOpaqueRoot instead of |
+ markDOMObjectWrapper. This is one of the few cases where a DOM object is |
+ considered a stand-alone root. It's not as efficient as the shared root |
+ case, but workers and message ports are very rare objects, so it's no |
+ big deal. |
+ |
+ * bindings/js/JSNamedNodeMapCustom.cpp: Autogenerate! |
+ |
+ * bindings/js/JSNodeCustom.h: Moved to JSDOMBinding.h. |
+ |
+ * bindings/js/JSSharedWorkerCustom.cpp: |
+ (WebCore::JSSharedWorker::visitChildren): Use addOpaqueRoot instead of |
+ markDOMObjectWrapper, as above. Once again, a stand-alone root. |
+ |
+ * bindings/js/JSStyleSheetCustom.cpp: |
+ * bindings/js/JSStyleSheetListCustom.cpp: Autogenerate! |
+ |
+ * bindings/js/JSWebGLRenderingContextCustom.cpp: |
+ (WebCore::JSWebGLRenderingContext::visitChildren): Use the opaque roots |
+ system for marking WebGL contexts and their associated satellite objects. |
+ |
+ * bindings/js/JSWorkerContextCustom.cpp: |
+ (WebCore::JSWorkerContext::visitChildren): |
+ * bindings/js/JSXMLHttpRequestCustom.cpp: Use addOpaqueRoot instead of |
+ markDOMObjectWrapper, as above. Once again, stand-alone roots. |
+ |
+ (WebCore::JSXMLHttpRequest::visitChildren): |
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp: No need to mark our owner |
+ XHR because it is not reachable from us. |
+ |
+ * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration support for a |
+ bunch of repetitive cases of isReachableFromOpaqueRoots callbacks. |
+ |
+ * css/CSSRule.idl: |
+ * css/CSSStyleDeclaration.idl: |
+ * css/MediaList.idl: |
+ * css/StyleMedia.idl: |
+ * css/StyleSheet.idl: |
+ * css/StyleSheetList.idl: |
+ * dom/DOMImplementation.idl: |
+ * dom/DOMStringMap.idl: |
+ * dom/MessagePort.idl: |
+ * dom/NamedNodeMap.idl: |
+ * fileapi/Blob.idl: |
+ * html/DOMTokenList.idl: Opt in to autogeneration. |
+ |
+ * html/HTMLCanvasElement.cpp: |
+ (WebCore::HTMLCanvasElement::getContext): Standardized on PassOwnPtr/OwnPtr |
+ usage, to reduce human error and make ownership rules more obvious. |
+ |
+ * html/HTMLCollection.idl: |
+ * html/canvas/ArrayBuffer.idl: Opt in to autogeneration. |
+ |
+ * html/canvas/CanvasRenderingContext.cpp: |
+ * html/canvas/CanvasRenderingContext.h: |
+ (WebCore::CanvasRenderingContext::ref): |
+ (WebCore::CanvasRenderingContext::deref): |
+ * html/canvas/CanvasRenderingContext2D.h: |
+ (WebCore::CanvasRenderingContext2D::create): |
+ (WebCore::CanvasRenderingContext2D::state): Standardized on PassOwnPtr/OwnPtr |
+ usage, to reduce human error and make ownership rules more obvious. |
+ |
+ Inlined some functions to match our standard idiom and to make the code |
+ in the header document itself. |
+ |
+ * html/canvas/CanvasRenderingContext.idl: Opt in to autogeneration. |
+ |
+ * html/canvas/OESStandardDerivatives.cpp: |
+ (WebCore::OESStandardDerivatives::OESStandardDerivatives): |
+ (WebCore::OESStandardDerivatives::create): |
+ * html/canvas/OESStandardDerivatives.h: |
+ * html/canvas/OESStandardDerivatives.idl: |
+ * html/canvas/OESTextureFloat.cpp: |
+ (WebCore::OESTextureFloat::OESTextureFloat): |
+ (WebCore::OESTextureFloat::create): |
+ * html/canvas/OESTextureFloat.h: |
+ * html/canvas/OESTextureFloat.idl: |
+ * html/canvas/OESVertexArrayObject.cpp: |
+ (WebCore::OESVertexArrayObject::OESVertexArrayObject): |
+ (WebCore::OESVertexArrayObject::create): |
+ * html/canvas/OESVertexArrayObject.h: |
+ * html/canvas/OESVertexArrayObject.idl: |
+ * html/canvas/WebGLExtension.cpp: |
+ (WebCore::WebGLExtension::WebGLExtension): |
+ * html/canvas/WebGLExtension.h: |
+ (WebCore::WebGLExtension::ref): |
+ (WebCore::WebGLExtension::deref): |
+ (WebCore::WebGLExtension::context): |
+ * html/canvas/WebGLRenderingContext.cpp: |
+ (WebCore::WebGLRenderingContext::~WebGLRenderingContext): |
+ (WebCore::WebGLRenderingContext::getExtension): |
+ * html/canvas/WebGLRenderingContext.h: |
+ * html/canvas/WebKitLoseContext.cpp: |
+ (WebCore::WebKitLoseContext::WebKitLoseContext): |
+ (WebCore::WebKitLoseContext::create): |
+ (WebCore::WebKitLoseContext::loseContext): |
+ * html/canvas/WebKitLoseContext.h: |
+ * html/canvas/WebKitLoseContext.idl: Updated the ownership model for WebGL |
+ canavs rendering contexts to match the model for 2D canvas rendering |
+ contexts. This makes garbage collection a lot more straightforward, but |
+ it also makes the behavior of these objects more reliable. (Previously, |
+ satellite objects would magically stop working when the last reference |
+ to their owner object was dropped. Now, satellite objects keep their owner |
+ alive through reference counting.) |
+ |
+ * loader/appcache/DOMApplicationCache.idl: |
+ * page/BarInfo.idl: |
+ * page/Console.idl: |
+ * page/DOMSelection.idl: |
+ * page/Geolocation.idl: |
+ * page/History.idl: |
+ * page/Location.idl: |
+ * page/Navigator.idl: |
+ * page/Screen.idl: |
+ * page/WorkerNavigator.idl: |
+ * plugins/DOMMimeTypeArray.h: |
+ (WebCore::DOMMimeTypeArray::frame): |
+ * plugins/DOMMimeTypeArray.idl: |
+ * plugins/DOMPluginArray.h: |
+ (WebCore::DOMPluginArray::frame): |
+ * plugins/DOMPluginArray.idl: |
+ * storage/Storage.idl: |
+ * workers/WorkerLocation.idl: Opt in to autogeneration. |
+ |
+ * xml/XMLHttpRequest.cpp: |
+ (WebCore::XMLHttpRequest::~XMLHttpRequest): |
+ * xml/XMLHttpRequest.h: |
+ * xml/XMLHttpRequestUpload.cpp: |
+ (WebCore::XMLHttpRequestUpload::scriptExecutionContext): |
+ * xml/XMLHttpRequestUpload.h: |
+ (WebCore::XMLHttpRequestUpload::create): |
+ (WebCore::XMLHttpRequestUpload::ref): |
+ (WebCore::XMLHttpRequestUpload::deref): |
+ (WebCore::XMLHttpRequestUpload::xmlHttpRequest): |
+ (WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload): |
+ * xml/XMLHttpRequestUpload.idl: Updated the ownership model for XHR and |
+ its associated upload object to match the model for canvas. This makes |
+ garbage collection a lot more straightforward, but it also makes the |
+ behavior of these objects more reliable. |
+ |
+2011-04-24 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r84759. |
+ http://trac.webkit.org/changeset/84759 |
+ https://bugs.webkit.org/show_bug.cgi?id=59306 |
+ |
+ Caused gc-shadow.html to start crashing in V8. (Requested by |
+ dglazkov|away on #webkit). |
+ |
+ * dom/Node.cpp: |
+ (WebCore::NodeRendererFactory::createRendererAndStyle): |
+ (WebCore::Node::styleForRenderer): |
+ |
+2011-04-24 Maciej Stachowiak <mjs@apple.com> |
+ |
+ Reviewed by George Staikos. |
+ |
+ Handling of URLs like http:/example.com/ is incorrect |
+ https://bugs.webkit.org/show_bug.cgi?id=59300 |
+ <rdar://problem/9231956> |
+ |
+ URLs like http:/example.com/ or http:example.com/ are now correctly |
+ canonicalized as http://example.com/ |
+ |
+ The code still doesn't quite match other browsers - at least some |
+ other browsers seem to base parsing behavior on whether they |
+ recongize a scheme from a fixed list, and ignore whether // is |
+ present in the URL or not. |
+ |
+ * platform/KURL.cpp: |
+ (WebCore::isNonFileHierarchicalScheme): New helper function. |
+ (WebCore::KURL::parse): For a particular list of whitelisted schemes, |
+ assume they are hierarchical and need an authority even if there is no // |
+ after the :/ |
+ |
+2011-04-24 Dan Bernstein <mitz@apple.com> |
+ |
+ LLVM Compiler build fix. |
+ |
+ * page/ContentSecurityPolicy.cpp: Removed an unused function. |
+ |
+2011-04-24 Dominic Cooney <dominicc@chromium.org> |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ Crash when adding a text node to a shadow root |
+ https://bugs.webkit.org/show_bug.cgi?id=59304 |
+ |
+ Text nodes need to consult their host element for style. |
+ |
+ Test: fast/dom/shadow/append-child-text.html |
+ |
+ * dom/Node.cpp: |
+ (WebCore::NodeRendererFactory::styleForRenderer): |
+ (WebCore::NodeRendererFactory::createRendererAndStyle): |
+ (WebCore::Node::styleForRenderer): forward to NodeRendererFactory |
+ |
+2011-04-24 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Update Content-Security-Policy syntax to match new version of spec |
+ https://bugs.webkit.org/show_bug.cgi?id=59291 |
+ |
+ Brandon removed disable-xss-protection in favor of unsafe-inline and |
+ allow-eval in favor of unsafe-eval. This change in syntax also means |
+ the options directive no longer exists. |
+ |
+ * page/ContentSecurityPolicy.cpp: |
+ (WebCore::CSPSourceList::allowInline): |
+ (WebCore::CSPSourceList::allowEval): |
+ (WebCore::CSPSourceList::CSPSourceList): |
+ (WebCore::CSPSourceList::parseSource): |
+ (WebCore::CSPSourceList::addSourceUnsafeInline): |
+ (WebCore::CSPSourceList::addSourceUnsafeEval): |
+ (WebCore::CSPDirective::allowInline): |
+ (WebCore::CSPDirective::allowEval): |
+ (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): |
+ (WebCore::ContentSecurityPolicy::allowInlineEventHandlers): |
+ (WebCore::ContentSecurityPolicy::allowInlineScript): |
+ (WebCore::ContentSecurityPolicy::allowEval): |
+ (WebCore::ContentSecurityPolicy::addDirective): |
+ * page/ContentSecurityPolicy.h: |
+ |
+2011-04-24 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Maciej Stachowiak. |
+ |
+ Manual test for <rdar://problem/9329741> Reproducible crash in WebChromeClient::invalidateContentsAndWindow() on simonscat.com |
+ https://bugs.webkit.org/show_bug.cgi?id=59299 |
+ |
+ * manual-tests/back-from-document-with-scrollbar.html: Added. |
+ |
+2011-04-24 Rik Cabanier <cabanier@adobe.com> |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ Tables are not rendered correctly |
+ https://bugs.webkit.org/show_bug.cgi?id=59138 |
+ |
+ Test: fast/table/auto-100-percent-width.html |
+ |
+ * rendering/AutoTableLayout.cpp: |
+ (WebCore::AutoTableLayout::computePreferredLogicalWidths): |
+ |
+2011-04-23 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Fix Windows build, which complains about unreachable code. |
+ |
+ * platform/ScrollableArea.cpp: |
+ (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar): |
+ (WebCore::ScrollableArea::hasLayerForVerticalScrollbar): |
+ (WebCore::ScrollableArea::hasLayerForScrollCorner): |
+ |
+2011-04-23 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Area under composited scrollbars not repainted in WebKit2 on scrolling |
+ https://bugs.webkit.org/show_bug.cgi?id=59294 |
+ <rdar://problem/9299062> |
+ |
+ When computing the rect that can be copied on scrolling, we normally |
+ exclude the areas occupied by overlay scrollbars to avoid smeared scrollbars; |
+ the assumption is that other code will repaint these areas. However, when |
+ scrollbars are in their own compositing layers, we can, and should |
+ copy the entire area. |
+ |
+ Not testable in DRT because it does not allow tests to use overlay scrollbars. |
+ |
+ * platform/ScrollView.h: |
+ * platform/ScrollView.cpp: |
+ (WebCore::ScrollView::rectToCopyOnScroll): |
+ New method, with code moved from scrollContents and fixed to look |
+ for scrollbars in layers. |
+ (WebCore::ScrollView::scrollContents): |
+ Call rectToCopyOnScroll(). |
+ |
+ * platform/ScrollableArea.h: |
+ * platform/ScrollableArea.cpp: |
+ (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar): |
+ (WebCore::ScrollableArea::hasLayerForVerticalScrollbar): |
+ (WebCore::ScrollableArea::hasLayerForScrollCorner): |
+ Methods we can call outside of the ACCELERATED_COMPOSITING #ifdef. |
+ |
+2011-04-23 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r84740. |
+ http://trac.webkit.org/changeset/84740 |
+ https://bugs.webkit.org/show_bug.cgi?id=59290 |
+ |
+ change breaks apple internal builds and is incorrect |
+ (Requested by smfr on #webkit). |
+ |
+ * WebCore.exp.in: |
+ * page/FrameView.cpp: |
+ * page/FrameView.h: |
+ * platform/ScrollTypes.h: |
+ * platform/ScrollableArea.h: |
+ * platform/mac/ScrollbarThemeMac.mm: |
+ (WebCore::ScrollbarThemeMac::paint): |
+ * platform/mac/WebCoreSystemInterface.h: |
+ * platform/mac/WebCoreSystemInterface.mm: |
+ |
+2011-04-23 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ <rdar://problem/8970549> WebFindOptionsAtWordStarts fails with Japanese words |
+ https://bugs.webkit.org/show_bug.cgi?id=59288 |
+ |
+ * platform/text/mac/TextBoundaries.mm: |
+ (WebCore::wordStringTokenizer): Added this helper function. |
+ (WebCore::findNextWordFromIndex): Changed to use a CFStringTokenizer with kCFStringTokenizerUnitWord, |
+ whose behavior is not locale-dependent. |
+ |
+2011-04-23 Dominic Cooney <dominicc@chromium.org> |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ [V8] Nodes in shadow DOM should not be GCed while their hosts are alive |
+ https://bugs.webkit.org/show_bug.cgi?id=59284 |
+ |
+ Test: fast/dom/shadow/gc-shadow.html |
+ |
+ * bindings/v8/V8GCController.cpp: |
+ (WebCore::calculateGroupId): group shadow nodes with their hosts |
+ |
+2011-04-23 MORITA Hajime <morrita@google.com> |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ [Refactoring] NodeRenderParentDetector should be NodeRenderFactory |
+ https://bugs.webkit.org/show_bug.cgi?id=59280 |
+ |
+ - Rename NodeRenderParentDetector to NodeRendererFactory |
+ - move createRendererAndStyle() and createRendererIfNeeded to |
+ NodeRendererFactory |
+ |
+ No new test, no behavioral change. |
+ |
+ * dom/Node.cpp: |
+ (WebCore::NodeRendererFactory::NodeRendererFactory): |
+ (WebCore::NodeRendererFactory::document): |
+ (WebCore::NodeRendererFactory::nextRenderer): |
+ (WebCore::NodeRendererFactory::findVisualParent): |
+ (WebCore::NodeRendererFactory::shouldCreateRenderer): |
+ (WebCore::NodeRendererFactory::createRendererAndStyle): |
+ (WebCore::NodeRendererFactory::createRendererIfNeeded): |
+ (WebCore::Node::parentNodeForRenderingAndStyle): |
+ (WebCore::Node::createRendererIfNeeded): |
+ * dom/Node.h: |
+ * html/HTMLDetailsElement.cpp: |
+ (WebCore::DetailsSummaryElement::detailsElement): Added const_cast due to the chage on parentNodeForRenderingAndStyle() |
+ |
+2011-04-23 MORITA Hajime <morrita@google.com> |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ REGRESSION: (non-Mac) <meter>'s bar part isn't rendered for with -webkit-writing-mode: vertical-lr from r82899 |
+ https://bugs.webkit.org/show_bug.cgi?id=59281 |
+ |
+ Styles for -webkit-meter-bar and -webkit-progress-bar missed width property, which caused unexpected layout results |
+ for vertical writing modes. This fix added a width property for each of them. |
+ |
+ Tests: fast/dom/HTMLMeterElement/meter-writing-mode.html |
+ fast/dom/HTMLProgressElement/progress-writing-mode.html |
+ |
+ * css/html.css: |
+ (meter::-webkit-meter-bar): |
+ (progress::-webkit-progress-bar): |
+ |
+2011-04-23 Kevin Ollivier <kevino@theolliviers.com> |
+ |
+ [wx] Unreviewed build fix. Added missing header. |
+ |
+ * platform/graphics/filters/FEDropShadow.h: |
+ |
+2011-04-23 Alexey Proskuryakov <ap@apple.com> |
+ |
+ Reviewed by Maciej Stachowiak. |
+ |
+ REGRESSION (r80812): window.print();window.close() doesn't work in WebKit2 |
+ https://bugs.webkit.org/show_bug.cgi?id=59241 |
+ <rdar://problem/9150861> |
+ |
+ Covered by manual-tests/print-after-window-close.html. |
+ |
+ Re-fixing <https://bugs.webkit.org/show_bug.cgi?id=51357> in a way that doesn't cause the |
+ regression. |
+ |
+ * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didCancel): We shouldn't be |
+ doing complicated work while the loader is half-canceled. |
+ |
+ * manual-tests/print-after-window-close.html: Extended to actually print a non-empty page, |
+ thus being more practical. |
+ |
+ * page/Chrome.cpp: (WebCore::Chrome::print): Added a FIXME about a need for PageGroupLoadDeferrer. |
+ It's too scary for me to try now. |
+ |
+ * page/DOMWindow.cpp: |
+ (WebCore::DOMWindow::DOMWindow): |
+ (WebCore::DOMWindow::finishedLoading): |
+ * page/DOMWindow.h: |
+ Reverted the previous fix for <https://bugs.webkit.org/show_bug.cgi?id=51357>. |
+ |
+2011-04-19 Vitaly Repeshko <vitalyr@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ [V8] Use implicit references for V8 listeners on DOM nodes. |
+ https://bugs.webkit.org/show_bug.cgi?id=58953 |
+ |
+ Instead of allocating an auxiliary V8 array referencing V8 |
+ listener objects associated with a DOM node and using an extra |
+ pointer in every DOM node wrapper, we can register implicit |
+ references between nodes and their listeners during GC. This also |
+ makes V8 bindings more aligned with JSC bindings. |
+ |
+ No new tests because this is a refactoring. |
+ |
+ * bindings/scripts/CodeGeneratorV8.pm: Stopped generating the |
+ listener cache internal field for DOM nodes. |
+ * bindings/v8/V8AbstractEventListener.h: Exposed the lister handle |
+ to the GC. |
+ (WebCore::V8AbstractEventListener::existingListenerObjectPeristentHandle): |
+ * bindings/v8/V8GCController.cpp: Started using implicit references. |
+ (WebCore::GrouperVisitor::visitDOMWrapper): |
+ * dom/EventTarget.h: Implemented an iterator over all listeners. |
+ (WebCore::EventListenerIterator): |
+ |
+2011-04-22 Jon Lee <jonlee@apple.com> |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ Overlay scroller hard to see on pages with dark background (59183) |
+ https://bugs.webkit.org/show_bug.cgi?id=59183 |
+ <rdar://problem/8975367> |
+ |
+ * WebCore.exp.in: adding method to allow changing style |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color |
+ * page/FrameView.h: |
+ * platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles |
+ * platform/ScrollableArea.cpp: |
+ (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style |
+ * platform/ScrollableArea.h: |
+ * platform/mac/ScrollbarThemeMac.mm: |
+ (WebCore::ScrollbarThemeMac::paint): |
+ * platform/mac/WebCoreSystemInterface.h: |
+ * platform/mac/WebCoreSystemInterface.mm: |
+ |
+2011-04-22 Chris Evans <cevans@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Upgrade CSS loads from mixed content warning (displayed) to mixed |
+ content error (ran) |
+ https://bugs.webkit.org/show_bug.cgi?id=59056 |
+ |
+ Test: http/tests/security/mixedContent/insecure-css-in-iframe.html |
+ Test: http/tests/security/mixedContent/insecure-css-in-main-frame.html |
+ |
+ * loader/cache/CachedResourceLoader.cpp: |
+ (WebCore::CachedResourceLoader::canRequest): CSS loads are running rather than displaying content. |
+ |
+2011-04-22 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Fixed an upside-down conditional in my last check-in. |
+ |
+ * bindings/js/JSDOMApplicationCacheCustom.cpp: |
+ (WebCore::isObservable): |
+ |
+2011-04-22 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Rolled back in r84725 and r84728 with appcache crash fixed. |
+ |
+ Reviewed by Oliver Hunt. |
+ |
+ Removed a use of markDOMObjectWrapper: DOMWindow |
+ https://bugs.webkit.org/show_bug.cgi?id=59260 |
+ |
+ * bindings/js/JSDOMWindowCustom.cpp: |
+ (WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since |
+ we use the opaque roots system now. |
+ |
+ * bindings/js/JSNavigatorCustom.cpp: Ditto. |
+ |
+ * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects |
+ whose opaque roots are frames. |
+ |
+ * css/StyleMedia.h: |
+ (WebCore::StyleMedia::frame): Added an accessor for the sake of GC. |
+ |
+ * css/StyleMedia.idl: |
+ * loader/appcache/DOMApplicationCache.idl: |
+ * page/BarInfo.idl: |
+ * page/Console.idl: |
+ * page/DOMSelection.idl: |
+ * page/Geolocation.idl: |
+ * page/History.idl: |
+ * page/Location.idl: |
+ * page/Navigator.idl: |
+ * page/Screen.idl: |
+ * storage/Storage.idl: Updated to use the opaque roots system. |
+ |
+2011-04-22 Nate Chapin <japhet@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Don't use XMLTreeViewer when script is disabled (it uses Javascript |
+ to build a prettified version of the xml document). |
+ https://bugs.webkit.org/show_bug.cgi?id=59113 |
+ |
+ * xml/XMLTreeViewer.cpp: |
+ (WebCore::XMLTreeViewer::transformDocumentToTreeView): |
+ |
+2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r84725 and r84728. |
+ http://trac.webkit.org/changeset/84725 |
+ http://trac.webkit.org/changeset/84728 |
+ https://bugs.webkit.org/show_bug.cgi?id=59270 |
+ |
+ It broke http/tests/appcache tests (Requested by Ossy on |
+ #webkit). |
+ |
+ * bindings/js/JSDOMWindowCustom.cpp: |
+ (WebCore::JSDOMWindow::visitChildren): |
+ * bindings/js/JSNavigatorCustom.cpp: |
+ (WebCore::JSNavigator::visitChildren): |
+ * bindings/scripts/CodeGeneratorJS.pm: |
+ * css/StyleMedia.h: |
+ * css/StyleMedia.idl: |
+ * loader/appcache/DOMApplicationCache.idl: |
+ * page/BarInfo.idl: |
+ * page/Console.idl: |
+ * page/DOMSelection.idl: |
+ * page/DOMWindow.h: |
+ (WebCore::DOMWindow::optionalScreen): |
+ (WebCore::DOMWindow::optionalSelection): |
+ (WebCore::DOMWindow::optionalHistory): |
+ (WebCore::DOMWindow::optionalCrypto): |
+ (WebCore::DOMWindow::optionalLocationbar): |
+ (WebCore::DOMWindow::optionalMenubar): |
+ (WebCore::DOMWindow::optionalPersonalbar): |
+ (WebCore::DOMWindow::optionalScrollbars): |
+ (WebCore::DOMWindow::optionalStatusbar): |
+ (WebCore::DOMWindow::optionalToolbar): |
+ (WebCore::DOMWindow::optionalConsole): |
+ (WebCore::DOMWindow::optionalNavigator): |
+ (WebCore::DOMWindow::optionalLocation): |
+ (WebCore::DOMWindow::optionalMedia): |
+ (WebCore::DOMWindow::optionalSessionStorage): |
+ (WebCore::DOMWindow::optionalLocalStorage): |
+ (WebCore::DOMWindow::optionalPerformance): |
+ * page/Geolocation.idl: |
+ * page/History.idl: |
+ * page/Location.idl: |
+ * page/Navigator.h: |
+ (WebCore::Navigator::optionalGeolocation): |
+ * page/Navigator.idl: |
+ * page/Screen.idl: |
+ * storage/Storage.idl: |
+ |
+2011-04-22 Dimitri Glazkov <dglazkov@chromium.org> |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ Change SVG-related shadow root checks to use isSVGShadowRoot. |
+ https://bugs.webkit.org/show_bug.cgi?id=59237 |
+ |
+ Covered by existing tests, no behavior change. |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Use isSVGShadowRoot. |
+ * svg/SVGUseElement.cpp: |
+ (WebCore::ShadowTreeUpdateBlocker::while): Ditto. |
+ * svg/animation/SVGSMILElement.cpp: |
+ (WebCore::SVGSMILElement::insertedIntoDocument): Ditto. |
+ |
+2011-04-22 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Mac build fix. |
+ |
+ * page/DOMWindow.h: |
+ (WebCore::DOMWindow::optionalApplicationCache): Restored this function, |
+ which is used after all. |
+ |
+2011-04-22 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Mac build fix. |
+ |
+ * page/DOMWindow.h: |
+ (WebCore::DOMWindow::optionalApplicationCache): Restored this function, |
+ which is used after all. |
+ |
+2011-04-22 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Reviewed by Oliver Hunt. |
+ |
+ Removed a use of markDOMObjectWrapper: DOMWindow |
+ https://bugs.webkit.org/show_bug.cgi?id=59260 |
+ |
+ * bindings/js/JSDOMWindowCustom.cpp: |
+ (WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since |
+ we use the opaque roots system now. |
+ |
+ * bindings/js/JSNavigatorCustom.cpp: Ditto. |
+ |
+ * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects |
+ whose opaque roots are frames. |
+ |
+ * css/StyleMedia.h: |
+ (WebCore::StyleMedia::frame): Added an accessor for the sake of GC. |
+ |
+ * css/StyleMedia.idl: |
+ * loader/appcache/DOMApplicationCache.idl: |
+ * page/BarInfo.idl: |
+ * page/Console.idl: |
+ * page/DOMSelection.idl: |
+ * page/Geolocation.idl: |
+ * page/History.idl: |
+ * page/Location.idl: |
+ * page/Navigator.idl: |
+ * page/Screen.idl: |
+ * storage/Storage.idl: Updated to use the opaque roots system. |
+ |
+2011-04-22 Xiaomei Ji <xji@chromium.org> |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ move caret by word in visual order returns wrong result when caret itself is at word boundary. |
+ https://bugs.webkit.org/show_bug.cgi?id=58504. |
+ |
+ positionBeforeNextWord should take care that the current position is after current word. |
+ positionAfterPreviousWord should take care that the current positin is before current word. |
+ |
+ * editing/visible_units.cpp: |
+ (WebCore::positionBeforeNextWord): |
+ (WebCore::positionAfterPreviousWord): |
+ |
+2011-04-19 Jer Noble <jer.noble@apple.com> |
+ |
+ Reviewed by Daniel Bates. |
+ |
+ Full Screen from within an <iframe> does not cause <iframe> to resize. |
+ https://bugs.webkit.org/show_bug.cgi?id=58638 |
+ |
+ Tests: fullscreen/full-screen-frameset.html |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Add the |
+ -webkit-full-screen pseudo class to frame elements which contain |
+ full screen elements. |
+ * css/fullscreen.css: |
+ (iframe:-webkit-full-screen): Add iframe-specific styling rules. |
+ * dom/Document.cpp: |
+ (WebCore::Document::setContainsFullScreenElementRecursively): Added. Walk up each |
+ successive document owner element, calling setContainsFullScreenElement() if |
+ owner is a frame element. |
+ (WebCore::Document::fullScreenIsAllowedForElement): Use the new Element::isFrameElementBase |
+ call instead of checking the element's tag name. |
+ (WebCore::Document::webkitWillEnterFullScreenForElement): Mark any containing |
+ iframes as containing a full screen element. |
+ (WebCore::Document::webkitWillExitFullScreenForElement): Ditto. |
+ * dom/Element.h: |
+ (WebCore::Element::isFrameElementBase): Added. |
+ * html/HTMLFrameElement.h: |
+ (WebCore::HTMLFrameElement::allowFullScreen): Disable full screen from within |
+ HTMLFrameElements. |
+ * html/HTMLFrameElementBase.cpp: |
+ (WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Added. |
+ * html/HTMLFrameElementBase.h: |
+ (WebCore::HTMLFrameElementBase::containsFullScreenElement): Added. |
+ (WebCore::HTMLFrameElementBase::isFrameElementBase): Added. |
+ |
+2011-04-22 Michael Saboff <msaboff@apple.com> |
+ |
+ Reviewed by Maciej Stachowiak. |
+ |
+ Creating copy of ContainerNode's when inserting or removing is inefficient |
+ https://bugs.webkit.org/show_bug.cgi?id=58695 |
+ |
+ Eliminated node copying in willRemove() and insertedIntoDocument(). |
+ |
+ No new tests as this is a more efficient implementation of |
+ existing code that is covered by existing tests. |
+ |
+ * dom/ContainerNode.cpp: |
+ (WebCore::ContainerNode::willRemove): Changed method to use |
+ RefPtr<> to protect against modification during removal. |
+ (WebCore::ContainerNode::insertedIntoDocument): Changed method to use |
+ RefPtr<> and two other deletion checks to protect against |
+ modification during insertion. |
+ |
+2011-04-22 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ We have an autogenerator, so use it |
+ https://bugs.webkit.org/show_bug.cgi?id=59247 |
+ |
+ * bindings/js/JSCSSRuleCustom.cpp: |
+ * bindings/js/JSCSSRuleListCustom.cpp: |
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp: |
+ * bindings/js/JSCSSValueCustom.cpp: |
+ * bindings/js/JSCanvasRenderingContextCustom.cpp: |
+ * bindings/js/JSDOMImplementationCustom.cpp: |
+ * bindings/js/JSDOMStringMapCustom.cpp: |
+ * bindings/js/JSHTMLCollectionCustom.cpp: |
+ * bindings/js/JSNamedNodeMapCustom.cpp: |
+ * bindings/js/JSNodeCustom.h: |
+ * bindings/js/JSNodeListCustom.cpp: |
+ * bindings/js/JSStyleSheetCustom.cpp: |
+ * bindings/js/JSStyleSheetListCustom.cpp: Removed repetitive hand-written code. |
+ |
+ * bindings/scripts/CodeGeneratorJS.pm: Augmented autogenerator to do the job. |
+ |
+ * css/CSSRule.idl: |
+ * css/CSSRuleList.idl: |
+ * css/CSSStyleDeclaration.idl: |
+ * css/CSSValue.idl: |
+ * css/MediaList.idl: |
+ * css/StyleSheet.idl: |
+ * css/StyleSheetList.idl: |
+ * dom/DOMImplementation.idl: |
+ * dom/DOMStringMap.idl: |
+ * dom/NamedNodeMap.idl: |
+ * dom/Node.idl: |
+ * dom/NodeList.idl: |
+ * html/DOMTokenList.idl: |
+ * html/HTMLCollection.idl: |
+ * html/canvas/CanvasRenderingContext.idl: Updated attributes to plug into |
+ the autogenerator. |
+ |
+2011-04-22 Beth Dakin <bdakin@apple.com> |
+ |
+ Reviewed by Maciej Stachowiak. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=59223 |
+ REGRESSION (r82185): iframe not displayed after navigation back to cached page |
+ |
+ Manual test added. |
+ * manual-tests/frame-layout-on-back.html: Added. |
+ * manual-tests/resources/empty-document-goes-back.html: Added. |
+ * manual-tests/resources/simple-iframe.html: Added. |
+ |
+2011-04-22 Yael Aharon <yael.aharon@nokia.com> |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ HTMLFormControlElement::labels should allow custom attributes. |
+ https://bugs.webkit.org/show_bug.cgi?id=59128 |
+ |
+ Cache the labels list when it is created and keep using it for future |
+ labels calls. |
+ |
+ Test: fast/forms/labels-custom-property.html |
+ |
+ * html/HTMLFormControlElement.cpp: |
+ (WebCore::HTMLFormControlElement::labels): |
+ |
+2011-04-22 Adrienne Walker <enne@google.com> |
+ |
+ Reviewed by James Robinson. |
+ |
+ [chromium] Remove minimum texture size for compositor tiling |
+ https://bugs.webkit.org/show_bug.cgi?id=59236 |
+ |
+ This was mistakenly committed in r83915 and causes bad filtering |
+ on very small textures. |
+ |
+ Tests: compositing/images/content-image-change.html |
+ |
+ * platform/graphics/chromium/LayerTilerChromium.cpp: |
+ (WebCore::LayerTilerChromium::setTileSize): |
+ |
+2011-04-22 Beth Dakin <bdakin@apple.com> |
+ |
+ Reviewed by Maciej Stachowiak. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=59223 |
+ REGRESSION (r82185): iframe not displayed after navigation back to cached page |
+ -and corresponding- |
+ <rdar://problem/9323763> |
+ |
+ Cache the scroll position in Document::setInPageCache() instead of |
+ FrameView::resetScrollbarsAndClearContentsSize(), and only clear the contents size |
+ for the mainFrame(). Still resetScrollbars() for other frames, which matches pre- |
+ r82185 code. |
+ * dom/Document.cpp: |
+ (WebCore::Document::setInPageCache): |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::resetScrollbarsAndClearContentsSize): |
+ |
+2011-04-22 Joseph Pecoraro <joepeck@webkit.org> |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ Let the RenderTheme decide if an input type should have a spinner |
+ https://bugs.webkit.org/show_bug.cgi?id=59246 |
+ |
+ Whether an input should have a spinner or not should |
+ be a UI decision made by the RenderTheme. Remove |
+ WebCore's default hasSpinButton values and defer |
+ to the RenderTheme. |
+ |
+ No change in functionality, covered by existing tests. |
+ |
+ * html/HTMLInputElement.cpp: |
+ (WebCore::HTMLInputElement::isRangeControl): expose isRangeControl |
+ for possible RenderTheme queries. |
+ * html/HTMLInputElement.h: |
+ |
+ * rendering/RenderTextControlSingleLine.cpp: |
+ (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): |
+ (WebCore::RenderTextControlSingleLine::createInnerTextStyle): |
+ For both of these ask the render theme if the input should |
+ have a spinner. |
+ |
+ * rendering/RenderTheme.cpp: |
+ (WebCore::RenderTheme::shouldHaveSpinButtonForInputElement): |
+ Steppable inputs (number, date, and range) but not range |
+ should have spinners. This does not change existing behavior. |
+ * rendering/RenderTheme.h: |
+ |
+ * dom/InputElement.h: |
+ * html/BaseDateAndTimeInputType.cpp: remove hasSpinButton. |
+ * html/BaseDateAndTimeInputType.h: remove hasSpinButton. |
+ * html/InputType.cpp: remove hasSpinButton. |
+ * html/InputType.h: remove hasSpinButton. |
+ * html/NumberInputType.cpp: remove hasSpinButton. |
+ * html/NumberInputType.h: remove hasSpinButton. |
+ |
+2011-04-22 Joseph Pecoraro <joepeck@webkit.org> |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ Don't rely on hasSpinButton to check if an input type can be stepped |
+ https://bugs.webkit.org/show_bug.cgi?id=59224 |
+ |
+ Add isSteppable to know for certain if an input type can |
+ be stepped or not. Previously we were checking if the input |
+ has a spin control or is the range input type. These are UI |
+ details, but the step functionality does not require there |
+ to be a UI. |
+ |
+ No change in behavior, covered by existing tests. |
+ |
+ * html/BaseDateAndTimeInputType.cpp: |
+ (WebCore::BaseDateAndTimeInputType::isSteppable): |
+ * html/BaseDateAndTimeInputType.h: |
+ * html/HTMLInputElement.cpp: |
+ (WebCore::HTMLInputElement::isSteppable): |
+ (WebCore::HTMLInputElement::stepUpFromRenderer): remove the |
+ check for a spinner and range control and instead ASSERT |
+ that the type is steppable. |
+ * html/HTMLInputElement.h: |
+ * html/InputType.cpp: |
+ (WebCore::InputType::isSteppable): |
+ * html/InputType.h: |
+ * html/NumberInputType.cpp: |
+ (WebCore::NumberInputType::isSteppable): |
+ * html/NumberInputType.h: |
+ * html/RangeInputType.cpp: |
+ (WebCore::RangeInputType::isSteppable): |
+ * html/RangeInputType.h: |
+ |
+2011-04-22 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ CSP frame-src is missing |
+ https://bugs.webkit.org/show_bug.cgi?id=58643 |
+ |
+ In this patch, I've audited all the callers to |
+ SecurityOrigin::canDisplay to make sure they all the appropriate |
+ Content-Security-Policy method as well. I'm not sure how to test all |
+ these cases, but making this changes fixed the frame-src test. |
+ |
+ * loader/SubframeLoader.cpp: |
+ (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): |
+ (WebCore::SubframeLoader::createJavaAppletWidget): |
+ (WebCore::SubframeLoader::loadSubframe): |
+ (WebCore::SubframeLoader::loadPlugin): |
+ * loader/SubresourceLoader.cpp: |
+ (WebCore::SubresourceLoader::create): |
+ * loader/cache/CachedResourceLoader.cpp: |
+ (WebCore::CachedResourceLoader::canRequest): |
+ (WebCore::CachedResourceLoader::requestResource): |
+ - While I was understanding this code, I fixed the FIXME here. |
+ * loader/cache/CachedResourceLoader.h: |
+ |
+2011-04-22 Adrienne Walker <enne@google.com> |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ Clear shared graphics context when destroying CanvasRenderingContext2D. |
+ https://bugs.webkit.org/show_bug.cgi?id=59212 |
+ |
+ * html/canvas/CanvasRenderingContext2D.cpp: |
+ (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D): |
+ |
+2011-04-22 Levi Weintraub <leviw@chromium.org> |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ End/Home keys do not work in a contentEditable element |
+ https://bugs.webkit.org/show_bug.cgi?id=50564 |
+ |
+ Changing logical[Start/End]OfLine to return a valid VisiblePosition for for editable contexts that are |
+ inline and share a line with non-editable content. |
+ |
+ Test: editing/selection/modify-by-lineboundary-in-inline-editable-contexts.html |
+ |
+ * editing/visible_units.cpp: |
+ (WebCore::logicalStartOfLine): |
+ (WebCore::logicalEndOfLine): |
+ |
+2011-04-22 Dimitri Glazkov <dglazkov@chromium.org> |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ Make showTree/showTreeForThis aware of the shadow DOM |
+ https://bugs.webkit.org/show_bug.cgi?id=52965 |
+ |
+ No new tests, because this code is only compiled in DEBUG. |
+ |
+ * dom/Node.cpp: |
+ (WebCore::traverseTreeAndMark): Moved tree traversal logic here, adding |
+ recursive sub-traversal of the shadow tree. |
+ (WebCore::Node::showTreeAndMark): Changed to use the new tree traversal function. |
+ |
+2011-04-22 Sam Weinig <sam@webkit.org> |
+ |
+ Reviewed by Gavin Barraclough and Oliver Hunt. |
+ |
+ Arrays should participate in global object forwarding fun |
+ https://bugs.webkit.org/show_bug.cgi?id=59215 |
+ |
+ Change callers of constructArray to use the new variant that takes |
+ a global object. |
+ |
+ * bindings/js/JSClipboardCustom.cpp: |
+ (WebCore::JSClipboard::types): |
+ * bindings/js/JSConsoleCustom.cpp: |
+ (WebCore::JSConsole::profiles): |
+ * bindings/js/JSJavaScriptCallFrameCustom.cpp: |
+ (WebCore::JSJavaScriptCallFrame::scopeChain): |
+ * bindings/js/JSMessageEventCustom.cpp: |
+ (WebCore::JSMessageEvent::ports): |
+ * bindings/js/JSScriptProfileNodeCustom.cpp: |
+ (WebCore::JSScriptProfileNode::children): |
+ * bindings/js/JSWebGLRenderingContextCustom.cpp: |
+ (WebCore::toJS): |
+ (WebCore::JSWebGLRenderingContext::getAttachedShaders): |
+ (WebCore::JSWebGLRenderingContext::getSupportedExtensions): |
+ |
+2011-04-22 Csaba Osztrogonác <ossy@webkit.org> |
+ |
+ [Qt] Unreviewed typo fix after r84522. |
+ |
+ * WebCore.pro: |
+ |
+2011-04-22 Daniel Bates <dbates@rim.com> |
+ |
+ Fix misspelled word in comment; tagets => targets. |
+ |
+ * page/EventHandler.cpp: |
+ (WebCore::EventHandler::handleTouchEvent): |
+ |
+2011-04-21 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Reviewed by Oliver Hunt. |
+ |
+ Removed a use of markDOMObjectWrapper: Element and Document |
+ https://bugs.webkit.org/show_bug.cgi?id=59178 |
+ |
+ * GNUmakefile.list.am: |
+ * UseJSC.cmake: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/js/JSBindingsAllInOne.cpp: Build! |
+ |
+ * bindings/js/JSDOMImplementationCustom.cpp: |
+ (WebCore::JSDOMImplementationOwner::isReachableFromOpaqueRoots): |
+ (WebCore::JSDOMImplementationOwner::finalize): |
+ (WebCore::wrapperOwner): |
+ (WebCore::wrapperContext): |
+ (WebCore::toJS): Use the opaque roots system for DOMImplementation. Also, |
+ DOMImplementation does not need to keep its document wrapper alive, since |
+ there's no DOM API for getting a DOMImplementation's document. |
+ |
+ * bindings/js/JSDOMStringMapCustom.cpp: |
+ (WebCore::JSDOMStringMapOwner::isReachableFromOpaqueRoots): |
+ (WebCore::JSDOMStringMapOwner::finalize): |
+ (WebCore::wrapperOwner): |
+ (WebCore::wrapperContext): |
+ (WebCore::toJS): Use the opaque roots system for DOMStringMap. |
+ |
+ * bindings/js/JSDOMTokenListCustom.cpp: Added. |
+ (WebCore::JSDOMTokenListOwner::isReachableFromOpaqueRoots): |
+ (WebCore::JSDOMTokenListOwner::finalize): |
+ (WebCore::wrapperOwner): |
+ (WebCore::wrapperContext): |
+ (WebCore::toJS): Use the opaque roots system for DOMTokenList. |
+ |
+ * bindings/js/JSDocumentCustom.cpp: |
+ (WebCore::JSDocument::visitChildren): |
+ * bindings/js/JSElementCustom.cpp: No more need for explicit marking. |
+ |
+ * bindings/scripts/CodeGeneratorV8.pm: Boo on whoever made this design decision. |
+ |
+ * dom/DOMImplementation.cpp: |
+ (WebCore::DOMImplementation::DOMImplementation): |
+ (WebCore::DOMImplementation::createDocument): |
+ (WebCore::DOMImplementation::createHTMLDocument): |
+ * dom/DOMImplementation.h: |
+ (WebCore::DOMImplementation::create): |
+ (WebCore::DOMImplementation::ref): |
+ (WebCore::DOMImplementation::deref): |
+ (WebCore::DOMImplementation::document): Fixed the DOMImplementation |
+ ownership model to match other satellite objects in the DOM. This was |
+ necessary to fix some crashes due to incorrect reference counting. |
+ |
+ * dom/DOMImplementation.idl: |
+ * dom/DOMStringMap.idl: |
+ * dom/Document.cpp: |
+ (WebCore::Document::~Document): |
+ * dom/Document.h: |
+ * dom/Element.cpp: |
+ * dom/Element.h: |
+ * dom/Element.idl: |
+ * html/DOMTokenList.idl: Updated to match changes above. |
+ |
+2011-04-22 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Rounded corners don't looks smooth when background-image is a gradient |
+ https://bugs.webkit.org/show_bug.cgi?id=59213 |
+ |
+ Add the "shrink background" behavior to the slow background |
+ drawing code path. |
+ |
+ Test: fast/backgrounds/gradient-background-leakage.html |
+ |
+ * rendering/RenderBoxModelObject.cpp: |
+ (WebCore::backgroundRectAdjustedForBleedAvoidance): |
+ Utility function that returns a shrunk border rect based |
+ on the context scale. |
+ (WebCore::RenderBoxModelObject::paintFillLayerExtended): |
+ Use backgroundRectAdjustedForBleedAvoidance() in both the fast |
+ and slow paths. |
+ |
+2011-04-22 Xiaomei Ji <xji@chromium.org> |
+ |
+ Reviewed by David Hyatt. |
+ |
+ Local caret rectangle calculation should be relative to its containing block. |
+ https://bugs.webkit.org/show_bug.cgi?id=49508. |
+ |
+ InlineBox and caret rectangle are positioned relative to its containing block. |
+ So its left and right edge value should be relative to its containing block as well. |
+ |
+ Test: fast/forms/cursor-at-editable-content-boundary.html |
+ |
+ * rendering/RenderText.cpp: |
+ (WebCore::RenderText::localCaretRect): |
+ |
+2011-04-22 Levi Weintraub <leviw@chromium.org> |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ REGRESSION: left property broken with position:fixed elements in RTL documents |
+ https://bugs.webkit.org/show_bug.cgi?id=59204 |
+ http://code.google.com/p/chromium/issues/detail?id=80216 |
+ |
+ Test: fast/block/positioning/rtl-fixed-positioning.html |
+ fast/block/positioning/vertical-rl/fixed-positioning.html |
+ |
+ Returning the proper scroll offsets for fixed position content in RTL documents. |
+ We regressed to X and Y offsets not updating while scrolling when we clamped to zero, |
+ but RTL documents scroll in negative space. |
+ |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::scrollXForFixedPosition): Properly handling RTL documents where |
+ the scroll origin and offsets are negative. |
+ (WebCore::FrameView::scrollYForFixedPosition): Properly handling vertical writing- |
+ mode RTL documents, like above. |
+ * platform/ScrollView.h: |
+ (WebCore::ScrollView::scrollOrigin): Changing this accessor to const. |
+ |
+2011-04-22 Justin Schuh <jschuh@chromium.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Should assert on invalid type in FEComponentTransfer::apply |
+ https://bugs.webkit.org/show_bug.cgi?id=57959 |
+ |
+ No functional change. No new tests needed. |
+ |
+ * platform/graphics/filters/FEComponentTransfer.cpp: |
+ (WebCore::FEComponentTransfer::apply): |
+ |
+2011-04-22 MORITA Hajime <morrita@google.com> |
+ |
+ Unreviewed crash fix. |
+ |
+ * html/HTMLDetailsElement.cpp: |
+ (WebCore::DetailsSummaryElement::shouldInclude): |
+ |
2011-04-22 Dan Bernstein <mitz@apple.com> |
Reviewed by Maciej Stachowiak. |