Issue 6974011: Don't send a reference to a string that goes out of scope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6974011: Don't send a reference to a string that goes out of scope. (Closed)

Created:
9 years, 7 months ago by Sam Kerner (Chrome)

Modified:
9 years, 7 months ago

Reviewers:
asargent_no_longer_on_chrome, USE_CHROMIUM_ACCT_INSTEAD

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Don't send a reference to a string that goes out of scope. Send a reference to a string on an object that lives longer than the callback which uses the string. Committed because the change is simple, and fixes failures on the waterfall. Antony, I would be happy to roll back if you feel this is not the correct solution. TBR=asargent BUG=83592 TEST=sync integration tests on mac Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86289

Patch Set 1 : Add bug to comments. #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
	M	chrome/common/net/url_fetcher.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/common/net/url_fetcher.cc	View		3 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages