Issue 6974008: Add missing SMI checks to fix reliability bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6974008: Add missing SMI checks to fix reliability bots (Closed)

Created:
9 years, 7 months ago by danno

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add missing SMI checks to fix reliability bots R=ager@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=7989

Patch Set 1 #

Total comments: 3

Patch Set 2 : fix whitespace #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
M	src/arm/stub-cache-arm.cc	View		4 chunks	+8 lines, -0 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		4 chunks	+8 lines, -0 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	4 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 7 months ago (2011-05-23 11:34:12 UTC) #2

LGTM, thanks!

http://codereview.chromium.org/6974008/diff/1/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):

http://codereview.chromium.org/6974008/diff/1/src/ia32/stub-cache-ia32.cc#new...
src/ia32/stub-cache-ia32.cc:2675: __ JumpIfSmi(edx, &miss);
Label::kNear?

http://codereview.chromium.org/6974008/diff/1/src/ia32/stub-cache-ia32.cc#new...
src/ia32/stub-cache-ia32.cc:3141: __ JumpIfSmi(edx, &miss);
Label::kNear?

http://codereview.chromium.org/6974008/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):

http://codereview.chromium.org/6974008/diff/1/src/x64/stub-cache-x64.cc#newco...
src/x64/stub-cache-x64.cc:2505: __ JumpIfSmi(rdx, &miss);
Near jump? And below as well?

Expand Messages | Collapse Messages