webkit/glue/webmenurunner_mac.mm - Issue 6974007: Move setToolTipText related functions from RenderView to RenderWidget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/webmenurunner_mac.mm

Issue 6974007: Move setToolTipText related functions from RenderView to RenderWidget. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Add Mac change. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/glue/webmenurunner_mac.mm

diff --git a/webkit/glue/webmenurunner_mac.mm b/webkit/glue/webmenurunner_mac.mm

index 7dce0a6bbc89ad605c8338da753f1b03c9cca43f..6efe8bb729d569bb3280ffa856dc5fda9bd24c08 100644

--- a/webkit/glue/webmenurunner_mac.mm

+++ b/webkit/glue/webmenurunner_mac.mm

@@ -66,6 +66,8 @@ static NSString* NSWritingDirectionAttributeName = @"NSWritingDirection";

NSMenuItem* menuItem = [menu_ addItemWithTitle:title

action:@selector(menuItemSelected:)

keyEquivalent:@""];

+ NSString* toolTip = base::SysUTF16ToNSString(item.toolTip);

+ [menuItem setToolTip:toolTip];

Nico 2011/05/25 17:12:58 Do you only want to do this if the toolTip isn't t

honten.org 2011/05/25 17:25:49 You are right. We don't have to set the string, i

[menuItem setEnabled:(item.enabled && item.type != WebMenuItem::GROUP)];

[menuItem setTarget:self];

« no previous file with comments | « webkit/glue/webmenuitem.cc ('k') | no next file » | no next file with comments »