Move setToolTipText related functions from RenderView to RenderWidget.

Move setToolTipText related functions from RenderView to RenderWidget.

WebPopupMenuImpl is derived from WebKit::WebWidget, not WebKit::WebView. So to call setToolTipText() function, we have to move the function from WebKit::WebWidget to WebKit::WebView. This change also includes WebKit change.
 https://bugs.webkit.org/show_bug.cgi?id=61260


BUG=12721
TEST=1, Make html file in BUT=12721. 2, Make sure tooptip is shown.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88023

[honten.org, 2011-05-23 05:53:42]

Please review.

[honten.org, 2011-05-25 02:46:47]

Please review.

It includes Mac change.

On 2011/05/23 05:53:42, honten wrote:
> Please review.

[honten.org, 2011-05-25 16:54:43]

Added Nico.

Nico, how have you been?

I believe you are the Mac expert!! So could you review this patch in Mac part?

Thanks,

[Nico, 2011-05-25 17:03:00]

Hm, I'm pretty sure this won't work on mac, where we use a native menu aas
select popup. Does the html5 spec state that title on select options should show
tooltips?

[takano.naoki_gmail.com, 2011-05-25 17:06:19]

Really? Could you check webmenurunner_mac.mm,  and
https://bugs.webkit.org/show_bug.cgi?id=61260

At least, in my environment, it worked.


We need to show tool tip in select popup.

Please refer to
http://code.google.com/p/chromium/issues/detail?id=12721

Thanks,

On Wed, May 25, 2011 at 10:03 AM,  <thakis@chromium.org> wrote:
> Hm, I'm pretty sure this won't work on mac, where we use a native menu aas
> select popup. Does the html5 spec state that title on select options should
> show
> tooltips?
>
> http://codereview.chromium.org/6974007/
>

[Nico, 2011-05-25 17:12:58]

Mac parts LGTM

http://codereview.chromium.org/6974007/diff/3001/webkit/glue/webmenurunner_ma...
File webkit/glue/webmenurunner_mac.mm (right):

http://codereview.chromium.org/6974007/diff/3001/webkit/glue/webmenurunner_ma...
webkit/glue/webmenurunner_mac.mm:70: [menuItem setToolTip:toolTip];
Do you only want to do this if the toolTip isn't the empty string?

[honten.org, 2011-05-25 17:25:49]

http://codereview.chromium.org/6974007/diff/3001/webkit/glue/webmenurunner_ma...
File webkit/glue/webmenurunner_mac.mm (right):

http://codereview.chromium.org/6974007/diff/3001/webkit/glue/webmenurunner_ma...
webkit/glue/webmenurunner_mac.mm:70: [menuItem setToolTip:toolTip];
You are right.

We don't have to set the string, if it's empty.

I'll add check routine.

On 2011/05/25 17:12:58, Nico wrote:
> Do you only want to do this if the toolTip isn't the empty string?

[honten.org, 2011-05-26 01:42:09]

I fixed empty check in Mac code.

Please review Win and Linux part.

Thanks,

On 2011/05/25 17:25:49, honten wrote:
>
http://codereview.chromium.org/6974007/diff/3001/webkit/glue/webmenurunner_ma...
> File webkit/glue/webmenurunner_mac.mm (right):
> 
>
http://codereview.chromium.org/6974007/diff/3001/webkit/glue/webmenurunner_ma...
> webkit/glue/webmenurunner_mac.mm:70: [menuItem setToolTip:toolTip];
> You are right.
> 
> We don't have to set the string, if it's empty.
> 
> I'll add check routine.
> 
> On 2011/05/25 17:12:58, Nico wrote:
> > Do you only want to do this if the toolTip isn't the empty string?

[honten.org, 2011-05-27 18:29:26]

Added Darin.

On 2011/05/26 01:42:09, honten wrote:
> I fixed empty check in Mac code.
> 
> Please review Win and Linux part.
> 
> Thanks,
> 
> On 2011/05/25 17:25:49, honten wrote:
> >
>
http://codereview.chromium.org/6974007/diff/3001/webkit/glue/webmenurunner_ma...
> > File webkit/glue/webmenurunner_mac.mm (right):
> > 
> >
>
http://codereview.chromium.org/6974007/diff/3001/webkit/glue/webmenurunner_ma...
> > webkit/glue/webmenurunner_mac.mm:70: [menuItem setToolTip:toolTip];
> > You are right.
> > 
> > We don't have to set the string, if it's empty.
> > 
> > I'll add check routine.
> > 
> > On 2011/05/25 17:12:58, Nico wrote:
> > > Do you only want to do this if the toolTip isn't the empty string?

[honten.org, 2011-05-31 17:55:17]

Could you review Win and Linux part?

On 2011/05/27 18:29:26, honten wrote:
> Added Darin.
> 
> On 2011/05/26 01:42:09, honten wrote:
> > I fixed empty check in Mac code.
> > 
> > Please review Win and Linux part.
> > 
> > Thanks,
> > 
> > On 2011/05/25 17:25:49, honten wrote:
> > >
> >
>
http://codereview.chromium.org/6974007/diff/3001/webkit/glue/webmenurunner_ma...
> > > File webkit/glue/webmenurunner_mac.mm (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/6974007/diff/3001/webkit/glue/webmenurunner_ma...
> > > webkit/glue/webmenurunner_mac.mm:70: [menuItem setToolTip:toolTip];
> > > You are right.
> > > 
> > > We don't have to set the string, if it's empty.
> > > 
> > > I'll add check routine.
> > > 
> > > On 2011/05/25 17:12:58, Nico wrote:
> > > > Do you only want to do this if the toolTip isn't the empty string?

[honten.org, 2011-06-01 19:21:26]

Does anybody review this patch?

I'm waiting for almost a week, but I cannot get any response about Win and Linux
part.

On 2011/05/31 17:55:17, honten wrote:
> Could you review Win and Linux part?
> 
> On 2011/05/27 18:29:26, honten wrote:
> > Added Darin.
> > 
> > On 2011/05/26 01:42:09, honten wrote:
> > > I fixed empty check in Mac code.
> > > 
> > > Please review Win and Linux part.
> > > 
> > > Thanks,
> > > 
> > > On 2011/05/25 17:25:49, honten wrote:
> > > >
> > >
> >
>
http://codereview.chromium.org/6974007/diff/3001/webkit/glue/webmenurunner_ma...
> > > > File webkit/glue/webmenurunner_mac.mm (right):
> > > > 
> > > >
> > >
> >
>
http://codereview.chromium.org/6974007/diff/3001/webkit/glue/webmenurunner_ma...
> > > > webkit/glue/webmenurunner_mac.mm:70: [menuItem setToolTip:toolTip];
> > > > You are right.
> > > > 
> > > > We don't have to set the string, if it's empty.
> > > > 
> > > > I'll add check routine.
> > > > 
> > > > On 2011/05/25 17:12:58, Nico wrote:
> > > > > Do you only want to do this if the toolTip isn't the empty string?

[Nico, 2011-06-02 16:26:36]

Rest LGTM as well.

Sorry for the poor review experience, I should've reviewed the whole patch the
first time round :-(

[honten.org, 2011-06-02 16:40:02]

Thanks, Nico.

But do not commit right now.

Because we have to wait webkit side landing, and still I'm waiting...

On 2011/06/02 16:26:36, Nico wrote:
> Rest LGTM as well.
> 
> Sorry for the poor review experience, I should've reviewed the whole patch the
> first time round :-(

[commit-bot: I haz the power, 2011-06-05 01:26:51]

Presubmit check for 6974007-10001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Takano.Naoki@gmail.com is not in AUTHORS file. If you are a new contributor,
please visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/renderer/render_widget.cc,content/browser/renderer_host/render_view_host.h,content/renderer/render_view.cc,content/browser/renderer_host/render_widget_host.cc,content/browser/renderer_host/render_widget_host.h,content/renderer/render_view.h,content/renderer/render_widget.h,content/browser/renderer_host/render_view_host.cc,content/common/view_messages.h

Presubmit checks took 1.0s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[honten.org, 2011-06-05 01:28:18]

I confirmed WebKit side patch landing.

Could you land my patch on behalf of me?

Still I'm not committer.

Thanks,

On 2011/06/05 01:26:51, commit-bot wrote:
> Presubmit check for 6974007-10001 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Warnings **
> mailto:Takano.Naoki@gmail.com is not in AUTHORS file. If you are a new
contributor,
> please visit
> http://www.chromium.org/developers/contributing-code and read the "Legal"
> section
> If you are a chromite, verify the contributor signed the CLA.
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for:
>
content/renderer/render_widget.cc,content/browser/renderer_host/render_view_host.h,content/renderer/render_view.cc,content/browser/renderer_host/render_widget_host.cc,content/browser/renderer_host/render_widget_host.h,content/renderer/render_view.h,content/renderer/render_widget.h,content/browser/renderer_host/render_view_host.cc,content/common/view_messages.h
> 
> Presubmit checks took 1.0s to calculate.
> 
> Was the presubmit check useful? Please send feedback & hate mail to
> maruel@chromium.org!

[Nico, 2011-06-06 13:55:04]

darin, jam: OWNERS stamp, please.

[jam, 2011-06-06 17:21:21]

lgtm

[commit-bot: I haz the power, 2011-06-06 17:37:01]

Presubmit check for 6974007-10001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Takano.Naoki@gmail.com is not in AUTHORS file. If you are a new contributor,
please visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

Presubmit checks took 1.0s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2011-06-06 20:11:33]

Change committed as 88023