Issue 6974006: dom-ui sync: When hitting the 'Customize' button, retain 'keep everything sync'd state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6974006: dom-ui sync: When hitting the 'Customize' button, retain 'keep everything sync'd state. (Closed)

Created:
9 years, 7 months ago by csilv

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

dom-ui sync: When hitting the 'Customize' button, retain 'keep everything sync'd state. BUG=81603 TEST=Verify that 'Sync everything' is selcted on toggle between 'Customize' and 'Use default settings'. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86243

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/options/sync_setup_overlay.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

9 years, 7 months ago (2011-05-22 21:03:51 UTC) #2

LGTM, though it's not clear to me from the conversations with the sync folks
that this is the correct solution.  Let's start with this and then move the
conversation forward after commit.

Expand Messages | Collapse Messages