Issue 6974005: download: Add a GetMenuModel() that grabs the correct model.

Issue 6974005: download: Add a GetMenuModel() that grabs the correct model. (Closed)

Created:
9 years, 7 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
asanka, dmazzoni, Randy Smith (Not in Mondays)

CC:
chromium-reviews, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

download: Add a GetMenuModel() that grabs the correct model. It returns the correct menu model depending on the state of download_item(). BUG=28978 TEST=None R=dmazzoni@chromium.org,asanka@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86281

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -52 lines)			Patch
M	chrome/browser/download/download_shelf_context_menu.h	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/download/download_shelf_context_menu.cc	View	1 2	2 chunks	+47 lines, -42 lines	0 comments	Download
M	chrome/browser/ui/gtk/download/download_shelf_context_menu_gtk.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/browser/ui/views/download/download_shelf_context_menu_view.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Randy Smith (Not in Mondays)

Quick question before rubber-stamp LGTM: Why no cocoa changes?

9 years, 7 months ago (2011-05-23 14:58:12 UTC) #4

dmazzoni

The Cocoa menu model is stored in a resource file rather than code: chrome/app/nibs/DownloadItem.xib - ...

9 years, 7 months ago (2011-05-23 16:18:47 UTC) #5

Randy Smith (Not in Mondays)

9 years, 7 months ago (2011-05-23 16:30:59 UTC) #6

On 2011/05/23 16:18:47, Dominic Mazzoni wrote:
> The Cocoa menu model is stored in a resource file rather than
> code: chrome/app/nibs/DownloadItem.xib - The equivalent code to choose the
> model is here: chrome/browser/ui/cocoa/download/
> download_item_controller.mm:234
> 
> - Dominic
> 
> On Mon, May 23, 2011 at 7:58 AM, <mailto:rdsmith@chromium.org> wrote:
> 
> > Quick question before rubber-stamp LGTM: Why no cocoa changes?
> >
> >
> >
> > http://codereview.chromium.org/6974005/
> >

Ok.  Rubber-stamp LGTM.

Expand Messages | Collapse Messages