src/arm/stub-cache-arm.cc - Issue 6973063: Extend GCMole with poor man's data flow analysis to catch dead raw pointer vars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/stub-cache-arm.cc

Issue 6973063: Extend GCMole with poor man's data flow analysis to catch dead raw pointer vars. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/stub-cache-arm.cc

diff --git a/src/arm/stub-cache-arm.cc b/src/arm/stub-cache-arm.cc

index 7a3c80f7b5797ef7337d12f0b7197dd6dea09711..89b87acd4e261739d54fe1e4a78ac3429748493d 100644

--- a/src/arm/stub-cache-arm.cc

+++ b/src/arm/stub-cache-arm.cc

@@ -3528,7 +3528,8 @@ MaybeObject* ExternalArrayStubCompiler::CompileKeyedLoadStub(

__ Ret();

} else {

WriteInt32ToHeapNumberStub stub(value, r0, r3);

- __ TailCallStub(&stub);

+ MaybeObject* stub_code = masm()->TryTailCallStub(&stub);

+ if (stub_code->IsFailure()) return stub_code;

}

} else if (array_type == kExternalUnsignedIntArray) {

// The test is different for unsigned int values. Since we need

« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/bootstrapper.cc » ('j') | src/bootstrapper.cc » ('J')