Extend GCMole with poor man's data flow analysis to catch dead raw pointer vars.

src/bootstrapper.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1683 matching lines @@
 #undef INSTALL_BUILTIN_ID
 }
 
 
 // Do not forget to update macros.py with named constant
 // of cache id.
 #define JSFUNCTION_RESULT_CACHE_LIST(F) \
   F(16, global_context()->regexp_function())
 
 
-static FixedArray* CreateCache(int size, JSFunction* factory_function) {
+static FixedArray* CreateCache(int size, Handle<JSFunction> factory_function) {
   Factory* factory = factory_function->GetIsolate()->factory();
   // Caches are supposed to live for a long time, allocate in old space.
   int array_size = JSFunctionResultCache::kEntriesIndex + 2 * size;
   // Cannot use cast as object is not fully initialized yet.
   JSFunctionResultCache* cache = reinterpret_cast<JSFunctionResultCache*>(
       *factory->NewFixedArrayWithHoles(array_size, TENURED));
-  cache->set(JSFunctionResultCache::kFactoryIndex, factory_function);
+  cache->set(JSFunctionResultCache::kFactoryIndex, *factory_function);
   cache->MakeZeroSize();
   return cache;
 }
 
 
 void Genesis::InstallJSFunctionResultCaches() {
   const int kNumberOfCaches = 0 +
 #define F(size, func) + 1
     JSFUNCTION_RESULT_CACHE_LIST(F)
 #undef F
   ;
 
   Handle<FixedArray> caches = FACTORY->NewFixedArray(kNumberOfCaches, TENURED);
 
   int index = 0;
 
 #define F(size, func) do {                           \

[Mads Ager (chromium), 2011/05/16 06:10:27]

Restore alignment of '\'

-    FixedArray* cache = CreateCache((size), (func)); \
+    FixedArray* cache = CreateCache((size), Handle<JSFunction>(func));  \
     caches->set(index++, cache);                     \
   } while (false)
 
   JSFUNCTION_RESULT_CACHE_LIST(F);
 
 #undef F
 
   global_context()->set_jsfunction_result_caches(*caches);
 }
 
@@ skipping 420 matching lines @@
   return from + sizeof(NestingCounterType);
 }
 
 
 // Called when the top-level V8 mutex is destroyed.
 void Bootstrapper::FreeThreadResources() {
   ASSERT(!IsActive());
 }
 
 } }  // namespace v8::internal