Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2289)

Unified Diff: chrome/browser/download/base_file.h

Issue 6973052: When the download folder does not exist, change the download folder to a user's "Downloads" (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Remove DownloadTest.DownloadFolder2 and SavePageBrowserTest.SaveFolder4 Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/download/base_file.cc » ('j') | chrome/browser/download/download_item.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/base_file.h
diff --git a/chrome/browser/download/base_file.h b/chrome/browser/download/base_file.h
index 02563b7e6b92deb0f93dba96a9a178d75577188f..ab7cb323105dfd2d098d8214e0c510d0fa03ed2d 100644
--- a/chrome/browser/download/base_file.h
+++ b/chrome/browser/download/base_file.h
@@ -32,8 +32,11 @@ class BaseFile {
const linked_ptr<net::FileStream>& file_stream);
virtual ~BaseFile();
- // If calculate_hash is true, sha256 hash will be calculated.
- bool Initialize(bool calculate_hash);
+ // If |calculate_hash| is true, sha256 hash will be calculated.
+ // If the file path is not decided yet (i.e. if we do not specify the
+ // file path when we create this BaseFile object), this method creates
+ // the file under |save_path|.
+ bool Initialize(bool calculate_hash, const FilePath& save_path);
// Write a new chunk of data to the file. Returns true on success (all bytes
// written to the file).
« no previous file with comments | « no previous file | chrome/browser/download/base_file.cc » ('j') | chrome/browser/download/download_item.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698