Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: chrome/browser/download/download_util.h

Issue 6973052: When the download folder does not exist, change the download folder to a user's "Downloads" (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Reflected Pawel's comments Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_util.h
diff --git a/chrome/browser/download/download_util.h b/chrome/browser/download/download_util.h
index c279973a768eecd21a2a755a128d63c7499afb88..e2efb28719ef358e9b550d19df49d92241e3ee22 100644
--- a/chrome/browser/download/download_util.h
+++ b/chrome/browser/download/download_util.h
@@ -50,12 +50,12 @@ namespace download_util {
// Download temporary file creation --------------------------------------------
-// Return the default download directory.
-const FilePath& GetDefaultDownloadDirectory();
-
-// Create a temporary file for a download in the user's default download
-// directory and return true if was successful in creating the file.
-bool CreateTemporaryFileForDownload(FilePath* path);
+// Returns the user's default "Downloads" folder provided by PathService.
+// This method always returns the folder provided by PathService
+// even if the folder is being overridden. We should use
+// DownloadPrefs::GetDefaultDownloadDirectory() instead unless we really
+// want the folder directly provided by PathService.
+FilePath GetDefaultDownloadDirectoryFromPathService();
// Return true if the |download_path| is dangerous path.
bool DownloadPathIsDangerous(const FilePath& download_path);

Powered by Google App Engine
This is Rietveld 408576698