chrome/browser/download/download_manager.h - Issue 6973052: When the download folder does not exist, change the download folder to a user's "Downloads"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_manager.h

Issue 6973052: When the download folder does not exist, change the download folder to a user's "Downloads" (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Add ChooseSavableDirectory() and ScopedDefaultDownloadDirectory Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_browsertest.cc ('k') | chrome/browser/download/download_manager.cc » ('j') | chrome/browser/download/download_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_manager.h

diff --git a/chrome/browser/download/download_manager.h b/chrome/browser/download/download_manager.h

index 79018bec672195496af041f0f6dbaff25c8d91de..a8bd2516e4109aa62c4596f6b7491775955aed7d 100644

--- a/chrome/browser/download/download_manager.h

+++ b/chrome/browser/download/download_manager.h

@@ -86,7 +86,9 @@ class DownloadManager

// Called immediately after the DownloadManager puts up a select file

// dialog.

// |id| indicates which download opened the dialog.

- virtual void SelectFileDialogDisplayed(int32 id) {}

+ // |suggested_path| indicates the path suggested in the dialog.

+ virtual void SelectFileDialogDisplayed(

+ int32 id, const FilePath& suggested_path) {}

protected:

virtual ~Observer() {}

@@ -285,7 +287,7 @@ class DownloadManager

// stalls from interacting with the file system.

void CheckIfSuggestedPathExists(int32 download_id,

DownloadStateInfo state,

- const FilePath& default_path);

+ const FilePath& download_save_dir);

// Called on the UI thread once the DownloadManager has determined whether the

// suggested file path exists.