chrome/browser/download/download_manager_unittest.cc - Issue 6973052: When the download folder does not exist, change the download folder to a user's "Downloads"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_manager_unittest.cc

Issue 6973052: When the download folder does not exist, change the download folder to a user's "Downloads" (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Added URLRequestMockHTTPJob.test_dir_ and URLRequestMockHTTPJob.temp_dir_ Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_manager.cc ('k') | chrome/browser/download/download_prefs.cc » ('j') | content/browser/net/url_request_mock_http_job.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_manager_unittest.cc

diff --git a/chrome/browser/download/download_manager_unittest.cc b/chrome/browser/download/download_manager_unittest.cc

index e8cda1c6bc4e0eb8bafab991170948a3fc72a90a..4c7180133eae91ecc21e3be4bcf59ce04e0f8ede 100644

--- a/chrome/browser/download/download_manager_unittest.cc

+++ b/chrome/browser/download/download_manager_unittest.cc

@@ -235,7 +235,8 @@ class SelectFileObserver : public DownloadManager::Observer {

// Downloadmanager::Observer functions.

virtual void ModelChanged() {}

virtual void ManagerGoingDown() {}

- virtual void SelectFileDialogDisplayed(int32 id) {

+ virtual void SelectFileDialogDisplayed(int32 id,

+ const FilePath& suggested_path) {

file_dialog_ids_.insert(id);

}

@@ -292,8 +293,11 @@ class ItemObserver : public DownloadItem::Observer {

TEST_F(DownloadManagerTest, StartDownload) {

BrowserThread io_thread(BrowserThread::IO, &message_loop_);

+ ScopedTempDir download_save_dir;

+ ASSERT_TRUE(download_save_dir.CreateUniqueTempDir());

PrefService* prefs = profile_->GetPrefs();

- prefs->SetFilePath(prefs::kDownloadDefaultDirectory, FilePath());

+ prefs->SetFilePath(prefs::kDownloadDefaultDirectory,

+ download_save_dir.path());

download_manager_->download_prefs()->EnableAutoOpenBasedOnExtension(

FilePath(FILE_PATH_LITERAL("example.pdf")));