When the download folder does not exist, change the download folder to a user's "Downloads"

chrome/browser/download/download_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_manager.h"
 
 #include "base/callback.h"
 #include "base/file_util.h"
 #include "base/i18n/case_conversion.h"
 #include "base/logging.h"
@@ skipping 350 matching lines @@
           download->id(),
           state,
           download_prefs()->download_path()));
 }
 
 void DownloadManager::CheckIfSuggestedPathExists(int32 download_id,
                                                  DownloadStateInfo state,
                                                  const FilePath& default_path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
 
-  // Make sure the default download directory exists.
-  // TODO(phajdan.jr): only create the directory when we're sure the user
-  // is going to save there and not to another directory of his choice.
-  file_util::CreateDirectory(default_path);
-
   // Check writability of the suggested path. If we can't write to it, default
-  // to the user's "My Documents" directory. We'll prompt them in this case.
+  // to the user's "Downloads" directory. We'll prompt them in this case.
   FilePath dir = state.suggested_path.DirName();
   FilePath filename = state.suggested_path.BaseName();
   if (!file_util::PathIsWritable(dir)) {
     VLOG(1) << "Unable to write to directory \"" << dir.value() << "\"";
     state.prompt_user_for_save_location = true;
-    PathService::Get(chrome::DIR_USER_DOCUMENTS, &state.suggested_path);
-    state.suggested_path = state.suggested_path.Append(filename);
+    if (!PathService::Get(
+            chrome::DIR_DEFAULT_DOWNLOADS, &state.suggested_path)) {

[Randy Smith (Not in Mondays), 2011/06/02 19:13:57]

Are we testing this case?

+      LOG(ERROR) << "Cannot find the user's \"Downloads\" folder.";

[Randy Smith (Not in Mondays), 2011/06/02 19:13:57]

I'm inclined to suggest you make this a VLOG rather than a LOG(ERROR).  It is an
uncommon case, but it's not really broken from the user's perspective--they may
have some very good (or bad, but still their choice) reason to delete the
default downloads directory, and I don't think we want to dump stuff to the
error output on release builds because of it.  It's rarely a good idea to do
non-VLOG release build logging.

[haraken1, 2011/06/03 06:50:27]

Done.

+      // If the user's "Downloads" folder does not exist, use the
+      // originally suggested path even if the path does not exist
+      // (This is a rare case).
+      state.suggested_path = dir.Append(filename);
+    } else {
+      state.suggested_path = state.suggested_path.Append(filename);
+    }
   }
 
   // If the download is deemed dangerous, we'll use a temporary name for it.
   if (state.IsDangerous()) {
     state.target_name = FilePath(state.suggested_path).BaseName();
     // Create a temporary file to hold the file until the user approves its
     // download.
     FilePath::StringType file_name;
     FilePath path;
 #if defined(OS_WIN)
@@ skipping 93 matching lines @@
     // FileSelectionCancelled().
     int32* id_ptr = new int32;
     *id_ptr = download_id;
     select_file_dialog_->SelectFile(SelectFileDialog::SELECT_SAVEAS_FILE,
                                     string16(),
                                     suggested_path,
                                     &file_type_info, 0, FILE_PATH_LITERAL(""),
                                     contents, owning_window,
                                     reinterpret_cast<void*>(id_ptr));
     FOR_EACH_OBSERVER(Observer, observers_,
-                      SelectFileDialogDisplayed(download_id));
+                      SelectFileDialogDisplayed(download_id, suggested_path));
   } else {
     // No prompting for download, just continue with the suggested name.
     ContinueDownloadWithPath(download, suggested_path);
   }
 }
 
 void DownloadManager::CreateDownloadItem(DownloadCreateInfo* info) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   DownloadItem* download = new DownloadItem(this, *info,
@@ skipping 768 matching lines @@
     observed_download_manager_->RemoveObserver(this);
 }
 
 void DownloadManager::OtherDownloadManagerObserver::ModelChanged() {
   observing_download_manager_->NotifyModelChanged();
 }
 
 void DownloadManager::OtherDownloadManagerObserver::ManagerGoingDown() {
   observed_download_manager_ = NULL;
 }