When the download folder does not exist, change the download folder to a user's "Downloads"

chrome/browser/download/download_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/path_service.h"
 #include "base/scoped_temp_dir.h"
 #include "base/test/test_file_util.h"
@@ skipping 73 matching lines @@
     std::set<DownloadItem*>::iterator it = downloads_observed_.begin();
     for (; it != downloads_observed_.end(); ++it) {
       (*it)->RemoveObserver(this);
     }
     download_manager_->RemoveObserver(this);
   }
 
   // State accessors.
   bool select_file_dialog_seen() { return select_file_dialog_seen_; }
 
+  // Checks if the select file dialog suggesting |path| was displayed.
+  bool IsSeenSelectFileDialogWithPath(FilePath& path) {
+    return select_file_dialog_seen_ && suggested_path_ == path;
+  }
+
   // Wait for whatever state was specified in the constructor.
   void WaitForFinished() {
     if (!IsFinished()) {
       waiting_ = true;
       ui_test_utils::RunMessageLoop();
       waiting_ = false;
     }
   }
 
   // Return true if everything's happened that we're configured for.
@@ skipping 40 matching lines @@
       // If it is finished and we are observing it, stop.
       if (finished_it != finished_downloads_.end() &&
           observed_it != downloads_observed_.end()) {
         (*it)->RemoveObserver(this);
         downloads_observed_.erase(observed_it);
         continue;
       }
     }
   }
 
-  virtual void SelectFileDialogDisplayed(int32 /* id */) {
+  virtual void SelectFileDialogDisplayed(int32 /* id */, FilePath& path) {
     select_file_dialog_seen_ = true;
+    suggested_path_ = path;
     SignalIfFinished();
   }
 
  private:
   // Called when we know that a download item is in a final state.
   // Note that this is not the same as it first transitioning in to the
   // final state; multiple notifications may occur once the item is in
   // that state.  So we keep our own track of transitions into final.
   void DownloadInFinalState(DownloadItem* download) {
     if (finished_downloads_.find(download) != finished_downloads_.end()) {
@@ skipping 45 matching lines @@
   // The state on which to consider the DownloadItem finished.
   DownloadItem::DownloadState download_finished_state_;
 
   // True if we should transition the DownloadsObserver to finished if
   // the select file dialog comes up.
   bool finish_on_select_file_;
 
   // True if we've seen the select file dialog.
   bool select_file_dialog_seen_;
 
+  // The suggested file path in the select file dialog.
+  FilePath suggested_path_;
+
   DISALLOW_COPY_AND_ASSIGN(DownloadsObserver);
 };
 
 // WaitForFlush() returns after:
 //      * There are no IN_PROGRESS download items remaining on the
 //        DownloadManager.
 //      * There have been two round trip messages through the file and
 //        IO threads.
 // This almost certainly means that a Download cancel has propagated through
 // the system.
@@ skipping 229 matching lines @@
     if (!downloads_directory_.CreateUniqueTempDir())
       return false;
 
     browser->profile()->GetPrefs()->SetFilePath(
         prefs::kDownloadDefaultDirectory,
         downloads_directory_.path());
 
     return true;
   }
 
+  // Delete the default folder for downloaded files.
+  bool DeleteDownloadsDirectory() {
+    return downloads_directory_.Delete();
+  }
+
   DownloadPrefs* GetDownloadPrefs(Browser* browser) {
     return browser->profile()->GetDownloadManager()->download_prefs();
   }
 
   FilePath GetDownloadDirectory(Browser* browser) {
     DownloadManager* download_mananger =
         browser->profile()->GetDownloadManager();
     return download_mananger->download_prefs()->download_path();
   }
 
@@ skipping 16 matching lines @@
         browser->profile()->GetDownloadManager();
     return new DownloadsObserver(
         download_manager, num_downloads,
         DownloadItem::IN_PROGRESS,      // Has started
         true);                          // Bail on select file
   }
 
   // Download |url|, then wait for the download to finish.
   // |disposition| indicates where the navigation occurs (current tab, new
   // foreground tab, etc).
-  // |expectation| indicates whether or not a Select File dialog should be
+  // |expectation| indicates whether or not a select file dialog should be
   // open when the download is finished, or if we don't care.
   // If the dialog appears, the routine exits.  The only effect |expectation|
   // has is whether or not the test succeeds.
   // |browser_test_flags| indicate what to wait for, and is an OR of 0 or more
   // values in the ui_test_utils::BrowserTestWaitFlags enum.
   void DownloadAndWaitWithDisposition(Browser* browser,
                                       const GURL& url,
                                       WindowOpenDisposition disposition,
                                       SelectExpectation expectation,
                                       int browser_test_flags) {
@@ skipping 254 matching lines @@
 // Files for these tests are found in DIR_TEST_DATA (currently
 // "chrome\test\data\", see chrome_paths.cc).
 // Mock responses have extension .mock-http-headers appended to the file name.
 
 // Download a file due to the associated MIME type.
 IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadMimeType) {
   ASSERT_TRUE(InitialSetup(false));
   FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
   GURL url(URLRequestMockHTTPJob::GetMockUrl(file));
 
-  // Download the file and wait.  We do not expect the Select File dialog.
+  // Download the file and wait.  We do not expect the select file dialog.
   DownloadAndWait(browser(), url, EXPECT_NO_SELECT_DIALOG);
 
   // Check state.
   EXPECT_EQ(1, browser()->tab_count());
   CheckDownload(browser(), file, file);
   EXPECT_TRUE(IsDownloadUIVisible(browser()));
 }
 
+IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadedDirectory) {
+  ASSERT_TRUE(InitialSetup(false));
+  FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
+  GURL url(URLRequestMockHTTPJob::GetMockUrl(file));
+
+  // Download the file and wait.  We do not expect the select file dialog.
+  DownloadAndWait(browser(), url, EXPECT_NO_SELECT_DIALOG);
+
+  FilePath file_path(DestinationFile(browser(), file));
+  EXPECT_TRUE(file_util::PathExists(file_path));
+  CheckDownload(browser(), file, file);
+  EXPECT_EQ(1, browser()->tab_count());
+  EXPECT_TRUE(IsDownloadUIVisible(browser()));
+
+  // Delete the default folder for downloaded files.

[Paweł Hajdan Jr., 2011/05/31 17:15:53]

Do we only need to do the setup above to get the file name? It's weird to
download something first and then delete some things.

[haraken1, 2011/06/02 09:13:22]

Done.

+  ASSERT_TRUE(DeleteDownloadsDirectory());
+  ASSERT_FALSE(file_util::PathExists(file_path));
+
+  // Download the file and wait.  We expect the select file dialog.
+  DownloadAndWait(browser(), url, EXPECT_SELECT_DIALOG);
+
+  FilePath default_downloads_path;
+  PathService::Get(chrome::DIR_DEFAULT_DOWNLOADS, &default_downloads_path);

[Paweł Hajdan Jr., 2011/05/31 17:15:53]

Please check the return value.

[haraken1, 2011/06/02 09:13:22]

Done.

+  file_path = default_downloads_path.Append(file);
+  EXPECT_FALSE(file_util::PathExists(file_path));

[Randy Smith (Not in Mondays), 2011/05/31 23:03:10]

Would it be also appropriate to confirm that we didn't create the downloads
directory?

[haraken1, 2011/06/02 09:13:22]

Done.

+  EXPECT_EQ(1, browser()->tab_count());
+
+  scoped_ptr<DownloadsObserver> observer(CreateWaiter(browser(), 1));
+  ui_test_utils::NavigateToURLWithDisposition(

[Paweł Hajdan Jr., 2011/05/31 17:15:53]

Why do we have a second navigation to |url|? By "first" I mean DownloadAndWait
on line 823.

[haraken1, 2011/06/02 09:13:22]

I cannot yet say the exact reason but this NavigateToURLWithDisposition() is
required. I confirmed that if I remove this NavigateToURLWithDisposition(), then
a file select dialog remains displayed and this test does not proceed any more. 

[Randy Smith (Not in Mondays), 2011/06/02 19:13:57]

Haraken: Let's figure out why the test isn't behaving properly; I'm a big
believer in "If you don't understand it, it's dangerous" :-}.  I notice that the
observer isn't being used correctly; it needs to be created before doing the
download that you want to track and WaitForFinished() called afterwards, to
resolve race conditions; it only waits for downloads that were started after its
creation.  Maybe this is the problem?

[haraken1, 2011/06/03 06:50:26]

Ahh, I got it. Thank you. 

After all, for simplicity, I added the check of the suggested path to
DownloadAndWait(). 

+      browser(), url, CURRENT_TAB,
+      ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
+
+  // Waits for the download to complete.
+  observer->WaitForFinished();
+
+  EXPECT_TRUE(observer->IsSeenSelectFileDialogWithPath(file_path));
+}
+
 #if defined(OS_WIN)
 // Download a file and confirm that the zone identifier (on windows)
 // is set to internet.
 IN_PROC_BROWSER_TEST_F(DownloadTest, CheckInternetZone) {
   ASSERT_TRUE(InitialSetup(false));
   FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
   GURL url(URLRequestMockHTTPJob::GetMockUrl(file));
 
-  // Download the file and wait.  We do not expect the Select File dialog.
+  // Download the file and wait.  We do not expect the select file dialog.
   DownloadAndWait(browser(), url, EXPECT_NO_SELECT_DIALOG);
 
   // Check state.  Special file state must be checked before CheckDownload,
   // as CheckDownload will delete the output file.
   EXPECT_EQ(1, browser()->tab_count());
   FilePath downloaded_file(DestinationFile(browser(), file));
   if (file_util::VolumeSupportsADS(downloaded_file))
     EXPECT_TRUE(file_util::HasInternetZoneIdentifier(downloaded_file));
   CheckDownload(browser(), file, file);
   EXPECT_TRUE(IsDownloadUIVisible(browser()));
 }
 #endif
 
-// Put up a Select File dialog when the file is downloaded, due to its MIME
+// Put up a select file dialog when the file is downloaded, due to its MIME
 // type.
 //
 // This test runs correctly, but leaves behind turds in the test user's
 // download directory because of http://crbug.com/62099.  No big loss; it
 // was primarily confirming DownloadsObserver wait on select file dialog
 // functionality anyway.
 IN_PROC_BROWSER_TEST_F(DownloadTest, DISABLED_DownloadMimeTypeSelect) {
   ASSERT_TRUE(InitialSetup(true));
   FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
   GURL url(URLRequestMockHTTPJob::GetMockUrl(file));
 
-  // Download the file and wait.  We expect the Select File dialog to appear
+  // Download the file and wait.  We expect the select file dialog to appear
   // due to the MIME type.
   DownloadAndWait(browser(), url, EXPECT_SELECT_DIALOG);
 
   // Check state.
   EXPECT_EQ(1, browser()->tab_count());
-  // Since we exited while the Select File dialog was visible, there should not
+  // Since we exited while the select file dialog was visible, there should not
   // be anything in the download shelf and so it should not be visible.
   EXPECT_FALSE(IsDownloadUIVisible(browser()));
 }
 
 // Access a file with a viewable mime-type, verify that a download
 // did not initiate.
 IN_PROC_BROWSER_TEST_F(DownloadTest, NoDownload) {
   ASSERT_TRUE(InitialSetup(false));
   FilePath file(FILE_PATH_LITERAL("download-test2.html"));
   GURL url(URLRequestMockHTTPJob::GetMockUrl(file));
@@ skipping 458 matching lines @@
 
 // Confirm a download makes it into the history properly.
 IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadHistoryCheck) {
   ASSERT_TRUE(InitialSetup(false));
   FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
   GURL url(URLRequestMockHTTPJob::GetMockUrl(file));
   FilePath origin_file(OriginFile(file));
   int64 origin_size;
   file_util::GetFileSize(origin_file, &origin_size);
 
-  // Download the file and wait.  We do not expect the Select File dialog.
+  // Download the file and wait.  We do not expect the select file dialog.
   DownloadAndWait(browser(), url, EXPECT_NO_SELECT_DIALOG);
 
   // Get details of what downloads have just happened.
   std::vector<DownloadItem*> downloads;
   GetDownloads(browser(), &downloads);
   ASSERT_EQ(1u, downloads.size());
   int64 db_handle = downloads[0]->db_handle();
 
   // Check state.
   EXPECT_EQ(1, browser()->tab_count());
@@ skipping 97 matching lines @@
       string16(), &downloads);
   ASSERT_EQ(1u, downloads.size());
   EXPECT_EQ(DownloadItem::COMPLETE, downloads[0]->state());
   EXPECT_TRUE(downloads[0]->opened());
 
   // As long as we're here, confirmed everything else is good.
   EXPECT_EQ(1, browser()->tab_count());
   CheckDownload(browser(), file, file);
   EXPECT_FALSE(IsDownloadUIVisible(browser()));  // Auto-opened.
 }