When the download folder does not exist, change the download folder to a user's "Downloads"

chrome/browser/download/download_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_manager.h"
 
 #include "base/callback.h"
 #include "base/file_util.h"
 #include "base/i18n/case_conversion.h"
 #include "base/logging.h"
@@ skipping 322 matching lines @@
           &DownloadManager::CheckIfSuggestedPathExists,
           info,
           download_prefs()->download_path()));
 }
 
 void DownloadManager::CheckIfSuggestedPathExists(DownloadCreateInfo* info,
                                                  const FilePath& default_path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
   DCHECK(info);
 
-  // Make sure the default download directory exists.
-  // TODO(phajdan.jr): only create the directory when we're sure the user

[Paweł Hajdan Jr., 2011/05/13 09:16:22]

By this comment I meant that in DownloadManager::CheckIfSuggestedPathExists
we're still not sure whether |default_path| will be the final destination
directory. 

Some users are annoyed when we create the default directory even if they choose
a custom location for each download, so this TODO was put here to remove that
annoyance. Some more context might be present in the svn log / svn blame of
those lines.

[Randy Smith (Not in Mondays), 2011/05/16 21:31:05]

Pawel: I'm trying to think about how I'd ideally fix this problem.  My sense is
that if the user chooses a custom location, the file chooser dialog will make
sure that we have the parents to that location.  This CL would deal with having
a correct default location.  We still have to worry about races with someone
deleting directories at just the right time, but we always have to worry about
that, and it's unlikely enough that I think just failing the download is fine. 
So I think if a fix for this issue is implemented, we can in fact get rid of
your extra CreateDirectory() here.  Do you check me on that logic?

[haraken1, 2011/05/17 04:29:05]

I would like to wait Pawel's reply. 

[Paweł Hajdan Jr., 2011/05/17 16:33:33]

Yeah, generally the TODO is about removing this code. I'm not sure whether the
chooser dialog is entirely correct. Ideally we should write some tests for all
scenarios that users reported as buggy.

[haraken1, 2011/05/30 13:40:52]

Finally, I removed these codes.

-  // is going to save there and not to another directory of his choice.
-  file_util::CreateDirectory(default_path);
-
   // Check writability of the suggested path. If we can't write to it, default
   // to the user's "My Documents" directory. We'll prompt them in this case.
   FilePath dir = info->suggested_path.DirName();
   FilePath filename = info->suggested_path.BaseName();
   if (!file_util::PathIsWritable(dir)) {
     VLOG(1) << "Unable to write to directory \"" << dir.value() << "\"";
     info->prompt_user_for_save_location = true;
     PathService::Get(chrome::DIR_USER_DOCUMENTS, &info->suggested_path);
     info->suggested_path = info->suggested_path.Append(filename);
   }
@@ skipping 817 matching lines @@
     observed_download_manager_->RemoveObserver(this);
 }
 
 void DownloadManager::OtherDownloadManagerObserver::ModelChanged() {
   observing_download_manager_->NotifyModelChanged();
 }
 
 void DownloadManager::OtherDownloadManagerObserver::ManagerGoingDown() {
   observed_download_manager_ = NULL;
 }