Issue 6973051: Remove MockWebFrame in favour of MockWebFrameClient and update corresponding tests.

Issue 6973051: Remove MockWebFrame in favour of MockWebFrameClient and update corresponding tests. (Closed)

Created:
9 years, 7 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, darin (slow to review)

CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), pam+watch_chromium.org, d.belchugov

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

Description

Remove MockWebFrame in favour of MockWebFrameClient and update corresponding tests. This should help reduce WebKit gardening pain since all WebFrame implementations will reside in WebKit itself. BUG=none TEST=test_shell_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85343

Patch Set 1 #

Patch Set 2 : forgot file #

Patch Set 3 : nits #

Patch Set 4 : whitespace #

Total comments: 6

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -723 lines)			Patch
M	webkit/glue/media/buffered_data_source_unittest.cc	View		6 chunks	+16 lines, -7 lines	2 comments	Download
M	webkit/glue/media/buffered_resource_loader_unittest.cc	View	1 2	6 chunks	+14 lines, -7 lines	2 comments	Download
M	webkit/glue/media/simple_data_source_unittest.cc	View	1 2 3	6 chunks	+21 lines, -10 lines	2 comments	Download
D	webkit/mocks/mock_webframe.h	View		1 chunk	+0 lines, -250 lines	0 comments	Download
D	webkit/mocks/mock_webframe.cc	View		1 chunk	+0 lines, -447 lines	0 comments	Download
A	webkit/mocks/mock_webframeclient.h	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gypi	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

darin: we cool w/ a WebFrameClient impl inside Chromium? All the methods are pre-declared so ...

9 years, 7 months ago (2011-05-13 05:17:11 UTC) #1

acolwell GONE FROM CHROMIUM

LGTM w/ µ-nits http://codereview.chromium.org/6973051/diff/8/webkit/glue/media/buffered_data_source_unittest.cc File webkit/glue/media/buffered_data_source_unittest.cc (right): http://codereview.chromium.org/6973051/diff/8/webkit/glue/media/buffered_data_source_unittest.cc#newcode106 webkit/glue/media/buffered_data_source_unittest.cc:106: if (view_) { nit: braces not ...

9 years, 7 months ago (2011-05-13 17:36:37 UTC) #2

acolwell GONE FROM CHROMIUM

9 years, 7 months ago (2011-05-13 17:36:37 UTC) #3

scherkus (not reviewing)

9 years, 7 months ago (2011-05-13 19:35:20 UTC) #5

thanks for the review!

deleting code woooooooooohoo!

http://codereview.chromium.org/6973051/diff/8/webkit/glue/media/buffered_data...
File webkit/glue/media/buffered_data_source_unittest.cc (right):

http://codereview.chromium.org/6973051/diff/8/webkit/glue/media/buffered_data...
webkit/glue/media/buffered_data_source_unittest.cc:106: if (view_) {
On 2011/05/13 17:36:37, acolwell wrote:
> nit: braces not necessary

Done.

http://codereview.chromium.org/6973051/diff/8/webkit/glue/media/buffered_reso...
File webkit/glue/media/buffered_resource_loader_unittest.cc (right):

http://codereview.chromium.org/6973051/diff/8/webkit/glue/media/buffered_reso...
webkit/glue/media/buffered_resource_loader_unittest.cc:77: if (view_) {
On 2011/05/13 17:36:37, acolwell wrote:
> nit: braces not necessary

Done.

http://codereview.chromium.org/6973051/diff/8/webkit/glue/media/simple_data_s...
File webkit/glue/media/simple_data_source_unittest.cc (right):

http://codereview.chromium.org/6973051/diff/8/webkit/glue/media/simple_data_s...
webkit/glue/media/simple_data_source_unittest.cc:61: if (view_) {
On 2011/05/13 17:36:37, acolwell wrote:
> nit:braces

Done.

Expand Messages | Collapse Messages