Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 6973037: GTK: Bring global menu out of about:flags. (Closed)

Created:
9 years, 7 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

GTK: Bring global menu out of about:flags. BUG=30213 TEST=memory bots, since they're now running w/ the code on. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85330

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -41 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/global_menu_bar.cc View 2 chunks +0 lines, -13 lines 1 comment Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
http://codereview.chromium.org/6973037/diff/1/chrome/browser/ui/gtk/global_menu_bar.cc File chrome/browser/ui/gtk/global_menu_bar.cc (left): http://codereview.chromium.org/6973037/diff/1/chrome/browser/ui/gtk/global_menu_bar.cc#oldcode63 chrome/browser/ui/gtk/global_menu_bar.cc:63: // TODO(erg): Redo I have no idea how to ...
9 years, 7 months ago (2011-05-12 23:21:18 UTC) #1
Elliot Glaysher
trying a different Evan (M).
9 years, 7 months ago (2011-05-13 19:48:42 UTC) #2
Evan Martin
LGTM
9 years, 7 months ago (2011-05-13 20:25:25 UTC) #3
Evan Stade
9 years, 7 months ago (2011-05-13 20:35:10 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698