Issue 6973037: GTK: Bring global menu out of about:flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6973037: GTK: Bring global menu out of about:flags. (Closed)

Created:
9 years, 7 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, Evan Stade

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

GTK: Bring global menu out of about:flags. BUG=30213 TEST=memory bots, since they're now running w/ the code on. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85330

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -41 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/global_menu_bar.cc	View	2 chunks	+0 lines, -13 lines	1 comment	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

http://codereview.chromium.org/6973037/diff/1/chrome/browser/ui/gtk/global_menu_bar.cc File chrome/browser/ui/gtk/global_menu_bar.cc (left): http://codereview.chromium.org/6973037/diff/1/chrome/browser/ui/gtk/global_menu_bar.cc#oldcode63 chrome/browser/ui/gtk/global_menu_bar.cc:63: // TODO(erg): Redo I have no idea how to ...

9 years, 7 months ago (2011-05-12 23:21:18 UTC) #1

lgtm

Expand Messages | Collapse Messages