Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5246)

Unified Diff: chrome/browser/download/download_manager.cc

Issue 6973035: Move download stuff to download tab helper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment tweak Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_manager.cc
diff --git a/chrome/browser/download/download_manager.cc b/chrome/browser/download/download_manager.cc
index fb9fb7b033c3cd2c04eb3451e860e5844c69f5a7..a22eae4f2017500440b0cdf5a49fcf0bd2302e17 100644
--- a/chrome/browser/download/download_manager.cc
+++ b/chrome/browser/download/download_manager.cc
@@ -33,6 +33,8 @@
#include "chrome/browser/tab_contents/tab_util.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/download/download_tab_helper.h"
+#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
#include "chrome/common/chrome_paths.h"
#include "content/browser/browser_thread.h"
#include "content/browser/renderer_host/render_process_host.h"
@@ -1068,7 +1070,7 @@ void DownloadManager::ShowDownloadInBrowser(
// The 'contents' may no longer exist if the user closed the tab before we
// get this start completion event. If it does, tell the origin TabContents
// to display its download shelf.
- TabContents* contents = process_handle->GetTabContents();
+ TabContentsWrapper* contents = process_handle->GetTabContentsWrapper();
// If the contents no longer exists, we start the download in the last active
// browser. This is not ideal but better than fully hiding the download from
@@ -1076,13 +1078,13 @@ void DownloadManager::ShowDownloadInBrowser(
if (!contents) {
Browser* last_active = BrowserList::GetLastActive();
if (last_active)
- contents = last_active->GetSelectedTabContents();
+ contents = last_active->GetSelectedTabContentsWrapper();
}
if (!contents)
return;
- contents->OnStartDownload(download);
+ contents->download_tab_helper()->OnStartDownload(download);
}
// Clears the last download path, used to initialize "save as" dialogs.
« no previous file with comments | « no previous file | chrome/browser/download/download_process_handle.h » ('j') | chrome/browser/tab_contents/tab_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698