Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4027)

Unified Diff: chrome/chrome_exe.gypi

Issue 6973032: linux: enable PIE (ASLR) for chrome executable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: typoi Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi
index a2f0a4991d348ee8a9380a8c896ddc0438f2b96e..bcdf7e6c1b209379062008ee457d70c7b9d18381 100644
--- a/chrome/chrome_exe.gypi
+++ b/chrome/chrome_exe.gypi
@@ -194,11 +194,21 @@
],
},
],
- # TODO(rkc): Remove this once we have a fix for remote gdb
- # and are able to correctly get section header offsets for
- # pie executables. Currently -pie breaks remote debugging.
+ # TODO(rkc): Remove disable_pie (and instead always use
+ # -pie) once we have a fix for remote gdb and are able to
+ # correctly get section header offsets for pie
+ # executables. Currently -pie breaks remote debugging.
['disable_pie==1', {
- 'ldflags' : ['-nopie'],
+ 'ldflags': ['-nopie'],
+ }, {
+ # Building with -fPIE fails on ARM and ia32 bots.
+ # http://code.google.com/p/chromium/issues/detail?id=57908
+ # Until that is fixed, at least use it on other platforms.
+ 'conditions': [
+ ['target_arch!="arm" and target_arch!="ia32"', {
+ 'ldflags': ['-pie'],
+ }],
+ ],
}],
['use_system_xdg_utils==0', {
'copies': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698