Issue 6973031: Options: Notify overlays that they will be closed if the options tab is closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6973031: Options: Notify overlays that they will be closed if the options tab is closed. (Closed)

Created:
9 years, 7 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Options: Notify overlays that they will be closed if the options tab is closed. This fixes an issue with the Sync setup UI where closing the tab in the middle of a setup operation would hose the setup UI because the backend thought a setup operation was still in progress. BUG=81564 TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85166

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	chrome/browser/resources/options/options.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/resources/options/options_page.js	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages