Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4319)

Unified Diff: chrome/browser/chromeos/login/dom_login_display.cc

Issue 6973029: Integrate WebUI Login with cros. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Updated code in response to review comments Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/dom_login_display.cc
diff --git a/chrome/browser/chromeos/login/dom_login_display.cc b/chrome/browser/chromeos/login/dom_login_display.cc
index 008b2c7a4b7cd2346123eee5b76e3fc8f6ecfd96..f60ce93b22f830e30f64cfe93e4c05d78a362afa 100644
--- a/chrome/browser/chromeos/login/dom_login_display.cc
+++ b/chrome/browser/chromeos/login/dom_login_display.cc
@@ -4,10 +4,10 @@
#include "chrome/browser/chromeos/login/dom_login_display.h"
-#include "chrome/browser/chromeos/frame/dom_browser.h"
#include "chrome/browser/chromeos/wm_ipc.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/ui/browser_window.h"
+#include "views/widget/widget.h"
namespace {
const char kLoginURL[] = "chrome://login";
@@ -18,8 +18,8 @@ namespace chromeos {
// DOMLoginDisplay, public: ---------------------------------------------------
DOMLoginDisplay::~DOMLoginDisplay() {
- if (login_screen_)
- login_screen_->CloseWindow();
+ if (webui_login_window_)
+ webui_login_window_->Close();
}
// DOMLoginDisplay, Singleton implementation: ----------------------------------
@@ -31,9 +31,25 @@ DOMLoginDisplay* DOMLoginDisplay::GetInstance() {
// LoginDisplay implementation: ------------------------------------------------
+// static
+views::Widget* DOMLoginDisplay::GetCurrentLoginWindow() {
+ return DOMLoginDisplay::GetInstance()->LoginWindow();
+}
+
+views::Widget* DOMLoginDisplay::LoginWindow() {
+ return webui_login_window_;
+}
+
void DOMLoginDisplay::Destroy() {
background_bounds_ = gfx::Rect();
delegate_ = NULL;
+
+ if (webui_login_window_) {
+ webui_login_window_->Close();
+ }
oshima 2011/05/19 01:45:19 nuke {}
rharrison 2011/05/19 16:45:28 Done.
+
+ webui_login_window_ = NULL;
+ webui_login_view_ = NULL;
}
void DOMLoginDisplay::Init(const std::vector<UserManager::User>& users,
@@ -45,10 +61,11 @@ void DOMLoginDisplay::Init(const std::vector<UserManager::User>& users,
// TODO(rharrison): Add mechanism to pass in the show_guest and show_new_user
// values.
- login_screen_ = DOMBrowser::CreateForDOM(ProfileManager::GetDefaultProfile());
- login_screen_->AddSelectedTabWithURL(GURL(kLoginURL),
- PageTransition::START_PAGE);
- login_screen_->window()->Show();
+ webui_login_window_ = WebUILoginView::CreateWindowContainingView(
+ background_bounds_,
+ GURL(kLoginURL),
+ &webui_login_view_);
+ webui_login_window_->Show();
}
void DOMLoginDisplay::OnBeforeUserRemoved(const std::string& username) {
@@ -104,6 +121,9 @@ void DOMLoginDisplay::LoginAsGuest() {
DOMLoginDisplay::DOMLoginDisplay()
: LoginDisplay(NULL, gfx::Rect()),
LoginUIHandlerDelegate(),
- login_screen_(NULL) {}
+ webui_login_window_(NULL) {
oshima 2011/05/19 01:45:19 webui_login_view_(NULL)
rharrison 2011/05/19 16:45:28 Done.
+
oshima 2011/05/19 01:45:19 remove empty line
rharrison 2011/05/19 16:45:28 Done.
+}
+
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698