Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: src/x64/code-stubs-x64.h

Issue 6973001: Propagate a Failure from GenerateDictionaryNegativeLookup instead of causing GC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 422 matching lines...) Expand 10 before | Expand all | Expand 10 after
433 enum LookupMode { POSITIVE_LOOKUP, NEGATIVE_LOOKUP }; 433 enum LookupMode { POSITIVE_LOOKUP, NEGATIVE_LOOKUP };
434 434
435 StringDictionaryLookupStub(Register dictionary, 435 StringDictionaryLookupStub(Register dictionary,
436 Register result, 436 Register result,
437 Register index, 437 Register index,
438 LookupMode mode) 438 LookupMode mode)
439 : dictionary_(dictionary), result_(result), index_(index), mode_(mode) { } 439 : dictionary_(dictionary), result_(result), index_(index), mode_(mode) { }
440 440
441 void Generate(MacroAssembler* masm); 441 void Generate(MacroAssembler* masm);
442 442
443 static void GenerateNegativeLookup(MacroAssembler* masm, 443 MUST_USE_RESULT static MaybeObject* GenerateNegativeLookup(
444 Label* miss, 444 MacroAssembler* masm,
445 Label* done, 445 Label* miss,
446 Register properties, 446 Label* done,
447 String* name, 447 Register properties,
448 Register r0); 448 String* name,
449 Register r0);
449 450
450 static void GeneratePositiveLookup(MacroAssembler* masm, 451 static void GeneratePositiveLookup(MacroAssembler* masm,
451 Label* miss, 452 Label* miss,
452 Label* done, 453 Label* done,
453 Register elements, 454 Register elements,
454 Register name, 455 Register name,
455 Register r0, 456 Register r0,
456 Register r1); 457 Register r1);
457 458
458 private: 459 private:
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
491 Register dictionary_; 492 Register dictionary_;
492 Register result_; 493 Register result_;
493 Register index_; 494 Register index_;
494 LookupMode mode_; 495 LookupMode mode_;
495 }; 496 };
496 497
497 498
498 } } // namespace v8::internal 499 } } // namespace v8::internal
499 500
500 #endif // V8_X64_CODE_STUBS_X64_H_ 501 #endif // V8_X64_CODE_STUBS_X64_H_
OLDNEW
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698