Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: src/ia32/code-stubs-ia32.h

Issue 6973001: Propagate a Failure from GenerateDictionaryNegativeLookup instead of causing GC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 425 matching lines...) Expand 10 before | Expand all | Expand 10 after
436 enum LookupMode { POSITIVE_LOOKUP, NEGATIVE_LOOKUP }; 436 enum LookupMode { POSITIVE_LOOKUP, NEGATIVE_LOOKUP };
437 437
438 StringDictionaryLookupStub(Register dictionary, 438 StringDictionaryLookupStub(Register dictionary,
439 Register result, 439 Register result,
440 Register index, 440 Register index,
441 LookupMode mode) 441 LookupMode mode)
442 : dictionary_(dictionary), result_(result), index_(index), mode_(mode) { } 442 : dictionary_(dictionary), result_(result), index_(index), mode_(mode) { }
443 443
444 void Generate(MacroAssembler* masm); 444 void Generate(MacroAssembler* masm);
445 445
446 static void GenerateNegativeLookup(MacroAssembler* masm, 446 MUST_USE_RESULT static MaybeObject* GenerateNegativeLookup(
447 Label* miss, 447 MacroAssembler* masm,
448 Label* done, 448 Label* miss,
449 Register properties, 449 Label* done,
450 String* name, 450 Register properties,
451 Register r0); 451 String* name,
452 Register r0);
452 453
453 static void GeneratePositiveLookup(MacroAssembler* masm, 454 static void GeneratePositiveLookup(MacroAssembler* masm,
454 Label* miss, 455 Label* miss,
455 Label* done, 456 Label* done,
456 Register elements, 457 Register elements,
457 Register name, 458 Register name,
458 Register r0, 459 Register r0,
459 Register r1); 460 Register r1);
460 461
461 private: 462 private:
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
494 Register dictionary_; 495 Register dictionary_;
495 Register result_; 496 Register result_;
496 Register index_; 497 Register index_;
497 LookupMode mode_; 498 LookupMode mode_;
498 }; 499 };
499 500
500 501
501 } } // namespace v8::internal 502 } } // namespace v8::internal
502 503
503 #endif // V8_IA32_CODE_STUBS_IA32_H_ 504 #endif // V8_IA32_CODE_STUBS_IA32_H_
OLDNEW
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698