Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: src/arm/code-stubs-arm.h

Issue 6973001: Propagate a Failure from GenerateDictionaryNegativeLookup instead of causing GC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/code-stubs-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 595 matching lines...) Expand 10 before | Expand all | Expand 10 after
606 606
607 607
608 class StringDictionaryLookupStub: public CodeStub { 608 class StringDictionaryLookupStub: public CodeStub {
609 public: 609 public:
610 enum LookupMode { POSITIVE_LOOKUP, NEGATIVE_LOOKUP }; 610 enum LookupMode { POSITIVE_LOOKUP, NEGATIVE_LOOKUP };
611 611
612 explicit StringDictionaryLookupStub(LookupMode mode) : mode_(mode) { } 612 explicit StringDictionaryLookupStub(LookupMode mode) : mode_(mode) { }
613 613
614 void Generate(MacroAssembler* masm); 614 void Generate(MacroAssembler* masm);
615 615
616 static void GenerateNegativeLookup(MacroAssembler* masm, 616 MUST_USE_RESULT static MaybeObject* GenerateNegativeLookup(
617 Label* miss, 617 MacroAssembler* masm,
618 Label* done, 618 Label* miss,
619 Register receiver, 619 Label* done,
620 Register properties, 620 Register receiver,
621 String* name, 621 Register properties,
622 Register scratch0) ; 622 String* name,
623 Register scratch0);
623 624
624 static void GeneratePositiveLookup(MacroAssembler* masm, 625 static void GeneratePositiveLookup(MacroAssembler* masm,
625 Label* miss, 626 Label* miss,
626 Label* done, 627 Label* done,
627 Register elements, 628 Register elements,
628 Register name, 629 Register name,
629 Register r0, 630 Register r0,
630 Register r1); 631 Register r1);
631 632
632 private: 633 private:
(...skipping 23 matching lines...) Expand all
656 657
657 class LookupModeBits: public BitField<LookupMode, 0, 1> {}; 658 class LookupModeBits: public BitField<LookupMode, 0, 1> {};
658 659
659 LookupMode mode_; 660 LookupMode mode_;
660 }; 661 };
661 662
662 663
663 } } // namespace v8::internal 664 } } // namespace v8::internal
664 665
665 #endif // V8_ARM_CODE_STUBS_ARM_H_ 666 #endif // V8_ARM_CODE_STUBS_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | src/arm/code-stubs-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698