net: Add NET_API to net/base

base/threading/non_thread_safe.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_THREADING_NON_THREAD_SAFE_H_
 #define BASE_THREADING_NON_THREAD_SAFE_H_
 #pragma once
 
+// Classes deriving from NonThreadSafe may need to supress warning 4275.
+#include "base/compiler_specific.h"

[wtc, 2011/05/16 20:55:17]

We discussed this issue in person.

Your current solution is fine, but we should explain in this
file what warning 4275 is (at least note it's a MSVC warning)
and how one can fix the compiler warning.

A problem with including "base/compiler_specific.h" in this
file is that this file itself doesn't use
"base/compiler_specific.h".  I understand why you do it this
way after looking at the other files, but I was wondering
about it when I first saw it.

[rvargas (doing something else), 2011/05/16 22:41:56]

I updated the comment to be more explicit about the #include, and to point out
the macro that I'm adding.


On 2011/05/16 20:55:17, wtc wrote:

+
 #ifndef NDEBUG
 #include "base/threading/non_thread_safe_impl.h"
 #endif
 
 namespace base {
 
 // Do nothing implementation of NonThreadSafe, for release mode.
 //
 // Note: You should almost always use the NonThreadSafe class to get
 // the right version of the class for your build configuration.
@@ skipping 29 matching lines @@
 class NonThreadSafe : public NonThreadSafeImpl {
 };
 #else
 class NonThreadSafe : public NonThreadSafeDoNothing {
 };
 #endif  // NDEBUG
 
 }  // namespace base
 
 #endif  // BASE_NON_THREAD_SAFE_H_