Start generating translated policy templates

Start generating translated policy templates

-Add output nodes of translations into policy_templates.grd.
-Copy translated string tables into the Mac bundle.
-Work around the problem that the zip tool would get too long command-line arguments if all the translated templates were enumerated as arguments.
-Fix importing of UTF-8 strings into the template generator

BUG=61779
TEST=Check that there are translated adml, adm and html files in policy_templates.zip.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86476

[gfeher, 2011-05-19 14:23:44]

Hi Tony,

Please review this. Let me know if you'd like me to find other reviewers for
some of the changes. Thanks,

Gábor

[tony, 2011-05-19 18:49:24]

http://codereview.chromium.org/6969064/diff/10001/chrome/tools/build/win/make...
File chrome/tools/build/win/make_policy_zip.py (right):

http://codereview.chromium.org/6969064/diff/10001/chrome/tools/build/win/make...
chrome/tools/build/win/make_policy_zip.py:19: # specified for Windows in
app/policy/policy_templates.grd
Hmm, is it possible for you to import tools/grit/grit_info.py and get this
programmatically?  It may require some sys.path hacking.

[Jói, 2011-05-23 13:13:51]

I have a couple of comments; if they are off the mark or you have good reasons
for the way you're doing it, feel free to commit without my final LGTM as I am
away today (it's a holiday up here in Canada) and I'll take a look afterwards.

http://codereview.chromium.org/6969064/diff/12001/tools/grit/grit/format/poli...
File tools/grit/grit/format/policy_templates/policy_template_generator.py
(right):

http://codereview.chromium.org/6969064/diff/12001/tools/grit/grit/format/poli...
tools/grit/grit/format/policy_templates/policy_template_generator.py:19: msg_txt
= msg_txt.decode('utf-8')
This looks OK, but just to confirm:  You are reading this data yourself right
from the JSON file, so this is the one and only place where you decode it,
right?

http://codereview.chromium.org/6969064/diff/12001/tools/grit/grit/format/poli...
File tools/grit/grit/format/policy_templates/template_formatter.py (right):

http://codereview.chromium.org/6969064/diff/12001/tools/grit/grit/format/poli...
tools/grit/grit/format/policy_templates/template_formatter.py:99:
pseudo_if_not_available=False,
pseudo_if_not_available and fallback_to_english are usually fetched via
item.PseudoAllowed() and item.ShouldFallbackToEnglish(), where they are
retrieved as attributes from the appropriate enclosing nodes
(fallback_to_english from the enclosing <structures>, <includes>, <messages> or
<identifiers> node, allow_pseudo from the <release> node).  Is there a reason
not to do that here?

[gfeher, 2011-05-23 20:55:09]

Thanks Jói. Are you also okay with the way I use grit in make_policy_zip.py? (I
am not in a rush with this CL as long as I can get it into M13.)

http://codereview.chromium.org/6969064/diff/12001/tools/grit/grit/format/poli...
File tools/grit/grit/format/policy_templates/policy_template_generator.py
(right):

http://codereview.chromium.org/6969064/diff/12001/tools/grit/grit/format/poli...
tools/grit/grit/format/policy_templates/policy_template_generator.py:19: msg_txt
= msg_txt.decode('utf-8')
Exactly.

http://codereview.chromium.org/6969064/diff/12001/tools/grit/grit/format/poli...
File tools/grit/grit/format/policy_templates/template_formatter.py (right):

http://codereview.chromium.org/6969064/diff/12001/tools/grit/grit/format/poli...
tools/grit/grit/format/policy_templates/template_formatter.py:99:
pseudo_if_not_available=False,
Done!

[tony, 2011-05-23 21:47:29]

LGTM, but feel free to wait for Joi to reply.

[Jói, 2011-05-24 01:04:02]

LGTM