Fix hover state in wrench menu

Fix hover state in wrench menu

Hiding the bookmark bar from the wrench menu would cause the wrench menu to get stuck with a hover state.

The problem was that when the super view is resized we don't get a mouse exited event in the button cell.

In this change I'm working around this by re-checking if the mouse is in the view once the wrench menu is closed. An alternative would be to use NSTrackingArea to get mouse entered/exited events. I think using NSTrackingArea would be a lot more work but if people would like me to use that I'll update this change to use that.

BUG=82456
TEST=Ran and verified that the hover state was no longer stuck.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85427

[Nico, 2011-05-14 21:49:08]

LGTM

http://codereview.chromium.org/6969058/diff/1/chrome/browser/ui/cocoa/menu_bu...
File chrome/browser/ui/cocoa/menu_button.mm (right):

http://codereview.chromium.org/6969058/diff/1/chrome/browser/ui/cocoa/menu_bu...
chrome/browser/ui/cocoa/menu_button.mm:142: if (![self cr_isMouseInView]) {
Add a comment that says why this is necessary (what you wrote in the CL
description), with a reference to http://crbug.com/82456

[sail, 2011-05-15 20:19:56]

http://codereview.chromium.org/6969058/diff/1/chrome/browser/ui/cocoa/menu_bu...
File chrome/browser/ui/cocoa/menu_button.mm (right):

http://codereview.chromium.org/6969058/diff/1/chrome/browser/ui/cocoa/menu_bu...
chrome/browser/ui/cocoa/menu_button.mm:142: if (![self cr_isMouseInView]) {
On 2011/05/14 21:49:08, Nico wrote:
> Add a comment that says why this is necessary (what you wrote in the CL
> description), with a reference to http://crbug.com/82456

Done.

[commit-bot: I haz the power, 2011-05-15 21:19:06]

Change committed as 85427