Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 6969037: Make the code flushing candidate field explicit in code objects. (Closed)

Created:
9 years, 7 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make the code flushing candidate field explicit in code objects. This way it is counted and the rounding of the size will just work without extra tweaking if you want to add an extra field to code objects. R=vegorov@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7872

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M src/heap.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/mark-compact.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M src/objects.h View 1 2 chunks +11 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
9 years, 7 months ago (2011-05-12 13:03:21 UTC) #1
Vyacheslav Egorov (Chromium)
LGTM http://codereview.chromium.org/6969037/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/6969037/diff/1/src/heap.cc#newcode2802 src/heap.cc:2802: code->set_code_flushing_candidate(undefined_value()); better call it next_code_flushing_candidate.
9 years, 7 months ago (2011-05-12 13:05:12 UTC) #2
Mads Ager (chromium)
9 years, 7 months ago (2011-05-12 13:07:28 UTC) #3
http://codereview.chromium.org/6969037/diff/1/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/6969037/diff/1/src/heap.cc#newcode2802
src/heap.cc:2802: code->set_code_flushing_candidate(undefined_value());
On 2011/05/12 13:05:12, Vyacheslav Egorov wrote:
> better call it next_code_flushing_candidate.

Will do. Thanks.

Powered by Google App Engine
This is Rietveld 408576698