Adding chrome://sessions webui for prototyping NTP stuff.

Adding chrome://sessions webui for prototyping tab sync NTP stuff.

This adds the necessary plumbing for chrome://sessions webui page which shows a hierarchy of sessions and their windows and tabs as well as a "magic" list of suggested tabs. The magic list is currently just the last 10 tabs by timestamp for now - but can later be changed to prototype other heuristics.

BUG=none
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88334
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88364

[Alexei Svitkine (slow), 2011-06-03 14:49:19]

ping

[Alexei Svitkine (slow), 2011-06-03 14:59:03]

Seems arv@ is on a sabbatical. jhawkins@, could you review the webui part?

[Alexei Svitkine (slow), 2011-06-06 17:34:59]

ping

On Fri, Jun 3, 2011 at 10:59 AM,  <asvitkine@chromium.org> wrote:
> Seems arv@ is on a sabbatical. jhawkins@, could you review the webui part?
>
> http://codereview.chromium.org/6969016/
>

[tim (not reviewing), 2011-06-06 23:42:19]

I'm not a good reviewer for any html/css stuff, James or Ben (cc'd) are more
appropriate.  The other changes seem fine with me, but I suggest having Nicolas
and/or Drew take a look, as they're more familiar with the code.

[Nicolas Zea, 2011-06-07 00:37:49]

Couple minor comments, otherwise LGTM

http://codereview.chromium.org/6969016/diff/13001/chrome/browser/ui/webui/ses...
File chrome/browser/ui/webui/sessions_ui.cc (right):

http://codereview.chromium.org/6969016/diff/13001/chrome/browser/ui/webui/ses...
chrome/browser/ui/webui/sessions_ui.cc:154: ProfileSyncService* service =
web_ui_->GetProfile()->GetProfileSyncService();
GetProfileSyncService performs lazy-creation of the sync service. You should
probably use HasProfileSyncService.

http://codereview.chromium.org/6969016/diff/13001/chrome/browser/ui/webui/ses...
chrome/browser/ui/webui/sessions_ui.cc:163: return
web_ui_->GetProfile()->GetProfileSyncService()->
return "model_associator" instead.

http://codereview.chromium.org/6969016/diff/13001/chrome/browser/ui/webui/ses...
chrome/browser/ui/webui/sessions_ui.cc:171: SessionTab* tab = *it;
const SessionTab* tab?

http://codereview.chromium.org/6969016/diff/13001/chrome/browser/ui/webui/ses...
chrome/browser/ui/webui/sessions_ui.cc:191: SessionWindow* window = *it;
const here too

[Nicolas Zea, 2011-06-07 00:38:30]

Note that I only looked at the sync stuff, not the webui/resources

On 2011/06/07 00:37:49, nzea wrote:
> Couple minor comments, otherwise LGTM
> 
>
http://codereview.chromium.org/6969016/diff/13001/chrome/browser/ui/webui/ses...
> File chrome/browser/ui/webui/sessions_ui.cc (right):
> 
>
http://codereview.chromium.org/6969016/diff/13001/chrome/browser/ui/webui/ses...
> chrome/browser/ui/webui/sessions_ui.cc:154: ProfileSyncService* service =
> web_ui_->GetProfile()->GetProfileSyncService();
> GetProfileSyncService performs lazy-creation of the sync service. You should
> probably use HasProfileSyncService.
> 
>
http://codereview.chromium.org/6969016/diff/13001/chrome/browser/ui/webui/ses...
> chrome/browser/ui/webui/sessions_ui.cc:163: return
> web_ui_->GetProfile()->GetProfileSyncService()->
> return "model_associator" instead.
> 
>
http://codereview.chromium.org/6969016/diff/13001/chrome/browser/ui/webui/ses...
> chrome/browser/ui/webui/sessions_ui.cc:171: SessionTab* tab = *it;
> const SessionTab* tab?
> 
>
http://codereview.chromium.org/6969016/diff/13001/chrome/browser/ui/webui/ses...
> chrome/browser/ui/webui/sessions_ui.cc:191: SessionWindow* window = *it;
> const here too

[Alexei Svitkine (slow), 2011-06-07 14:52:46]

Can anyone review the webui stuff?

http://codereview.chromium.org/6969016/diff/13001/chrome/browser/ui/webui/ses...
File chrome/browser/ui/webui/sessions_ui.cc (right):

http://codereview.chromium.org/6969016/diff/13001/chrome/browser/ui/webui/ses...
chrome/browser/ui/webui/sessions_ui.cc:154: ProfileSyncService* service =
web_ui_->GetProfile()->GetProfileSyncService();
On 2011/06/07 00:37:49, nzea wrote:
> GetProfileSyncService performs lazy-creation of the sync service. You should
> probably use HasProfileSyncService.

Done.

http://codereview.chromium.org/6969016/diff/13001/chrome/browser/ui/webui/ses...
chrome/browser/ui/webui/sessions_ui.cc:163: return
web_ui_->GetProfile()->GetProfileSyncService()->
On 2011/06/07 00:37:49, nzea wrote:
> return "model_associator" instead.

Refactored so GetSessionModelAssociator() is only called once.

http://codereview.chromium.org/6969016/diff/13001/chrome/browser/ui/webui/ses...
chrome/browser/ui/webui/sessions_ui.cc:171: SessionTab* tab = *it;
On 2011/06/07 00:37:49, nzea wrote:
> const SessionTab* tab?

Done.

http://codereview.chromium.org/6969016/diff/13001/chrome/browser/ui/webui/ses...
chrome/browser/ui/webui/sessions_ui.cc:191: SessionWindow* window = *it;
On 2011/06/07 00:37:49, nzea wrote:
> const here too

Done.

[James Hawkins, 2011-06-07 18:33:31]

LGTM with nits.

http://codereview.chromium.org/6969016/diff/25001/chrome/browser/resources/se...
File chrome/browser/resources/sessions.css (right):

http://codereview.chromium.org/6969016/diff/25001/chrome/browser/resources/se...
chrome/browser/resources/sessions.css:21: #countBannerOld {
HTML element IDs should be dash-form.

http://codereview.chromium.org/6969016/diff/25001/chrome/browser/resources/se...
chrome/browser/resources/sessions.css:42: margin-top: 12px;
nit: Alphabetize properties, here and elsewhere.

[Alexei Svitkine (slow), 2011-06-07 21:03:29]

Thanks!

http://codereview.chromium.org/6969016/diff/25001/chrome/browser/resources/se...
File chrome/browser/resources/sessions.css (right):

http://codereview.chromium.org/6969016/diff/25001/chrome/browser/resources/se...
chrome/browser/resources/sessions.css:21: #countBannerOld {
On 2011/06/07 18:33:31, James Hawkins wrote:
> HTML element IDs should be dash-form.

Done.

http://codereview.chromium.org/6969016/diff/25001/chrome/browser/resources/se...
chrome/browser/resources/sessions.css:42: margin-top: 12px;
On 2011/06/07 18:33:31, James Hawkins wrote:
> nit: Alphabetize properties, here and elsewhere.

Done.

[commit-bot: I haz the power, 2011-06-07 23:30:00]

Try job failure for 6969016-38001 on mac for step unit_tests:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2011-06-08 14:55:50]

Change committed as 88334